devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa
Date: Mon, 8 Dec 2025 09:15:39 +0200	[thread overview]
Message-ID: <aTZ7G8M-FvmEuQ8X@lipo.home.arpa> (raw)
In-Reply-To: <44adc9d6-2520-4282-8c6e-1fedf5319e77@kernel.org>


hello Krzysztof, 

On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2025 07:00, Petre Rodan wrote:
> > Adds binding for digital Honeywell ABP2 series pressure and temperature
> > sensors.
> > The i2c address is hardcoded and depends on the part number.
> > There is an optional interrupt that signals the end of conversion.
> > 
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

[..]

> If a tag was not added on purpose, please state why and what changed.
> </form letter>

I removed the tag on purpose since the yaml file was modified in v4 as per the
changelog that is below the commit message.

> I will not be doing work twice and, without explanation, forcing me to
> do that is disrespectful to my time.

sorry about that. the single thing that changed was that

---- 8< --------------------------------------------
@@ -76,8 +71,7 @@ properties:
   spi-max-frequency:
     maximum: 800000
 
-  vdd-supply:
-    description: provide VDD power to the sensor.
+  vdd-supply: true
 
 required:
   - compatible
---- >8 --------------------------------------------

I checked the resulting file with make dt_binding_check, yet I was not sure if your previous tag would still validate the work.

best regards,
peter

  reply	other threads:[~2025-12-08  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-07  6:00 [PATCH v4 0/2] iio: pressure: add Honeywell ABP2 driver Petre Rodan
2025-12-07  6:00 ` [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa Petre Rodan
2025-12-08  5:01   ` Krzysztof Kozlowski
2025-12-08  7:15     ` Petre Rodan [this message]
2025-12-08  7:21       ` Krzysztof Kozlowski
2025-12-14 15:20         ` Jonathan Cameron
2025-12-07  6:00 ` [PATCH v4 2/2] iio: pressure: add Honeywell ABP2 driver Petre Rodan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTZ7G8M-FvmEuQ8X@lipo.home.arpa \
    --to=petre.rodan@subdimension.ro \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).