Re: [PATCH v3 5/5] clk: spacemit: k3: add the clock tree

[Yao Zi <me@ziyao.cc>]

On Fri, Dec 26, 2025 at 07:01:20PM +0800, Yixun Lan wrote:
> Add clock support to SpacemiT K3 SoC, the clock tree consist of several
> blocks which are APBC, APBS, APMU, DCIU, MPUM.
> 
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
>  drivers/clk/spacemit/Kconfig      |    6 +
>  drivers/clk/spacemit/Makefile     |    3 +
>  drivers/clk/spacemit/ccu-k3.c     | 1482 +++++++++++++++++++++++++++++++++++++
>  drivers/clk/spacemit/ccu_common.c |    3 +-
>  4 files changed, 1493 insertions(+), 1 deletion(-)

...

> diff --git a/drivers/clk/spacemit/ccu_common.c b/drivers/clk/spacemit/ccu_common.c
> index f1a837aafb46..5132f73be68d 100644
> --- a/drivers/clk/spacemit/ccu_common.c
> +++ b/drivers/clk/spacemit/ccu_common.c
> @@ -144,7 +144,8 @@ int spacemit_ccu_probe(struct platform_device *pdev)
>  	 * are in APBS region. Reference to MPMU syscon is required to check PLL
>  	 * status.
>  	 */
> -	if (of_device_is_compatible(dev->of_node, "spacemit,k1-pll")) {
> +	if (of_device_is_compatible(dev->of_node, "spacemit,k1-pll") ||
> +		of_device_is_compatible(dev->of_node, "spacemit,k3-pll")) {

To me it's better to add a argument to spacemit_ccu_probe to specify the
compatible of PLL, so we don't need to modify ccu_common.c each time a
new SoC is introduced, and the condition won't be pretty long in the
future.

It isn't a serious issue for now, and I think this piece of code is
acceptable.

>  		struct device_node *mpmu = of_parse_phandle(dev->of_node,
>  							    "spacemit,mpmu", 0);
>  		if (!mpmu)

Regards,
Yao Zi