Re: [PATCH 7/7] LoongArch: dts: loongson-2k1000: Fix i2c-gpio node names

[Yao Zi <me@ziyao.cc>]

On Tue, Dec 16, 2025 at 03:56:59PM +0800, Binbin Zhou wrote:
> From: Binbin Zhou <zhoubb.aaron@gmail.com>
> 
> The binding wants the node to be named "i2c-number", alternatively
> "i2c@address", but those are named "i2c-gpio-number" instead.
> 
> Rename those to i2c-0, i2c-1 to adhere to the binding and suppress
> dtbs_check warnings.

I think this is an unintended breakage in dtschema upstream, but not
really a violation. As I've mentioned in my original cover-letter,

> which IMHO is a regression caused by dt-schema commit 57138f5b8c92
> ("schemas: i2c: Avoid extra characters in i2c nodename pattern"). Commit
> 647181a1f8ff ("schemas: i2c: Allow for 'i2c-.*' node names") fails to
> fix the case, as it doesn't take nodenames with multiple hyphens in
> account. I'll start a separate series for this.

So I think it should probably be fixed in dt-schema instead. i2c-gpio-X
provides more information to me, and I don't think it causes any
inconsistency or ambiguity.

By the way, we also have dozens of arm dtb targets shipping nodes named
like i2c-gpio-*, mostly microchip and st ones, fixing the regex in
dtschema upstream will also eliminate warnings for them.

Best regards,
Yao Zi

> Signed-off-by: Binbin Zhou <zhoubb.aaron@gmail.com>
> ---
>  arch/loongarch/boot/dts/loongson-2k1000.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> index fa1c000fd3e0..f70b245c8bc4 100644
> --- a/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> +++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> @@ -46,7 +46,7 @@ cpuintc: interrupt-controller {
>  	};
>  
>  	/* i2c of the dvi eeprom edid */
> -	i2c-gpio-0 {
> +	i2c-0 {
>  		compatible = "i2c-gpio";
>  		scl-gpios = <&gpio0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  		sda-gpios = <&gpio0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -57,7 +57,7 @@ i2c-gpio-0 {
>  	};
>  
>  	/* i2c of the eeprom edid */
> -	i2c-gpio-1 {
> +	i2c-1 {
>  		compatible = "i2c-gpio";
>  		scl-gpios = <&gpio0 33 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  		sda-gpios = <&gpio0 32 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> -- 
> 2.47.3
>