From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E8672E8B87 for ; Wed, 17 Dec 2025 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765974086; cv=none; b=ZgG/sEMYEbX3QGoUDWvcxmhe+Up6AmNpr3abiCABxQPECaF3wx15EzLT/+GMXVcOj3FFCmVLYayH7gODZijyIUkzwDHtwQgNsBC2E7En3CncrJ9sSpLpnDUBc+vR97qsA/vJ1I4J7ghO5OKGQCK437/S2DdLQ27w4ktfPcRTf5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765974086; c=relaxed/simple; bh=fny9SFTxturF7015JakyAPXxKQIp2Ma/cwO/hVKlOlQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HoSVPLuqWKp4fAJPinWCVJ67kurtc32HzGgO1DTKtqUhZOaJPI54Z1EBHGEizDyOeYAyg6kA9LCUDte+gx/MRj8TqfwYPwjeLqVm1EnsohlwxPmvglZgeIqpiuhjoS3GgZADmcbjmchnKKIjUZsong6hR1H6TGYF7K48H4T0NnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SNMV+RRd; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SNMV+RRd" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso25014125e9.1 for ; Wed, 17 Dec 2025 04:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765974082; x=1766578882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DYXq2m6KIBeaHm0Y860B+iQgDTaW343HwilrkCCxiCU=; b=SNMV+RRd6noDNpXs2aKVhos/B28mz0h992v9tw4Rb2eWuEIE8FaQlpeELC4w85+Xgx 3Syxrufaeu+7L2zMEvd0V4ByRSFlmltdrPjyM4UUQKKbyuFXiYvYP6egaqyLaNDaCjYN 3vt0ZX4VECLqxLzgC95/J8cea2rj9JC/RolhB7sqpY/DSwSm8nvAWtnIGZK1a9i6uMGX wZqVwbsmAtEVaGDEr5hdm8ee1cEpi1UXEtJ9TZvF+QveAHcuZziMzxFN0dRb1iwssIlf WzUAPnXxbpn1ff7JO+xrDmukXlsfYjjGv2GwQAeDyPEEZ9brEWzmIitMaxTa7BXkdKeS NfLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765974082; x=1766578882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DYXq2m6KIBeaHm0Y860B+iQgDTaW343HwilrkCCxiCU=; b=P7JfsyPXiqTRflqSPQVwMj2hVv/TkTc6CWnHbC5Gpxxm+EVQWBjPphQy1h+HD4Rnq0 bhd/rsgiC6asxnCzvSMgUudwvCFvObXdc3rTG0tUul46ervDLWGbQ6DUqW30mcLBBXkG jqHi0alIbanYuUI2up0BXdix9QhK5/RlOetf2Pg1CpaQMq38M1ytuzl0BpztqJN6SnMA BAhSU9ksHXhZHT2nNa4Le2GVfw60lloocMbLD6Y9mhwSNRJ2G6qOy+F2VarDXOcq+6uP QwVXc3AKZHxsyGtfO4dFuSe4OWJVOSn91hBGqJa20PE8dkSIZtMJL49wjxeOX4KGwqck O8IA== X-Forwarded-Encrypted: i=1; AJvYcCXKLwbPmwYPGbBWdblbnpks3jKvwOurEf52nyjTF8YdmBZRPphmxBxDQhMJVZu4NMEf/3v9C+aO3FZe@vger.kernel.org X-Gm-Message-State: AOJu0Yze8PGY6cGGLzMrRMfzrbphTKNgh2U0PcAfIWwMuD0n4nZQvCHb Mw34lXIH+zrw0Ptf04a4aSe+yd3DEZbkmRBR0w+86SDo70BDc4Xxl8MF X-Gm-Gg: AY/fxX47GrIvWahYRFR+3BqJlxnSX9r/dgHXGaz+O8nnvWjWyQqODH5jl4W9ILVJTAj PEmQAgmZ5AG0RDTjfCnAAFbV4bPr5NEHGXGWUZvw6Qtm7pYJ52mWZoCPoAAa2M+QNa1Q2ONfDuL 5376iJqGZRMOMHjj5HJkippAO8bFwzANfMU2UiENsOCwF6NdqUH7ry4bT/2rD27OceIQe1/E3E2 y/T/HIJnx0JB4rdJsXfv6fJ0Utz6bDFddm9m4LFQks6HWi2cuj0ATcg7j8L2SibWNALXHClZ9qN 127LU9Sh/WWa6MxF7Ldp/AXB297SvzOj8QkGscBSJotF30bSON2eWsxlcIRp1rVxue+lqhl8tcs iHeukMhjy+3hsTTMBPrqE4gZHsDUmTBRnK7S0dRYVAl2JWIQEAS/nt748L179suQTwB5C0qM9fJ jMK0VXb49tzAE= X-Google-Smtp-Source: AGHT+IEHnifimtj7VdGfz6MjbhY2lEOpq0xdu6/7cpFkjgiXCk7n3y9Quh4Rc68+jvf5AZydr2IWWA== X-Received: by 2002:a05:600c:3486:b0:477:561f:6fc8 with SMTP id 5b1f17b1804b1-47a8f8a79e4mr188945585e9.5.1765974082138; Wed, 17 Dec 2025 04:21:22 -0800 (PST) Received: from eichest-laptop ([2a02:168:af72:0:b288:1a0e:e6f7:d63a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1d991fsm37975775e9.5.2025.12.17.04.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 04:21:21 -0800 (PST) Date: Wed, 17 Dec 2025 13:21:19 +0100 From: Stefan Eichenberger To: Rob Herring Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, geert+renesas@glider.be, ben.dooks@codethink.co.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com, rafael.beims@toradex.com, Stefan Eichenberger Subject: Re: [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd Message-ID: References: <20251212084657.29239-1-eichest@gmail.com> <20251212084657.29239-3-eichest@gmail.com> <20251215140330.GA2360845-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 17, 2025 at 10:58:54AM +0100, Stefan Eichenberger wrote: > On Mon, Dec 15, 2025 at 08:03:30AM -0600, Rob Herring wrote: > > On Fri, Dec 12, 2025 at 09:46:17AM +0100, Stefan Eichenberger wrote: > > > From: Stefan Eichenberger > > > > > > Add a property to activate a Micrel PHY feature that keeps the preamble > > > enabled before the SFD (Start Frame Delimiter) is transmitted. > > > > > > This allows to workaround broken Ethernet controllers as found on the > > > NXP i.MX8MP. Specifically, errata ERR050694 that states: > > > ENET_QOS: MAC incorrectly discards the received packets when Preamble > > > Byte does not precede SFD or SMD. > > > > It doesn't really work right if you have to change the DT to work-around > > a quirk in the kernel. You should have all the information needed > > already in the DT. The compatible string for the i.MX8MP ethernet > > controller is not sufficient? > > Is doing something like this acceptable in a phy driver? > if (of_machine_is_compatible("fsl,imx8mp")) { > ... > } > > That would be a different option, rather than having to add a new DT > property. Unfortunately, the workaround affects the PHY rather than the > MAC driver. This is why we considered adding a DT property. Francesco made a good point about this. The i.MX8MP has two MACs, but only one of them is affected. Therefore, checking the machine's compatible string would not be correct. As far as I know, checking the MAC's compatible string from within the PHY driver is also not good practice, is it?