From: Stefan Eichenberger <eichest@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh@kernel.org>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
geert+renesas@glider.be, ben.dooks@codethink.co.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, francesco.dolcini@toradex.com,
rafael.beims@toradex.com,
Stefan Eichenberger <stefan.eichenberger@toradex.com>
Subject: Re: [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd
Date: Thu, 18 Dec 2025 09:59:37 +0100 [thread overview]
Message-ID: <aUPCeeRkLwUBBlax@eichest-laptop> (raw)
In-Reply-To: <49385cb4-6ce9-4120-9dd6-c08d763f0564@lunn.ch>
Hi Andrew,
On Wed, Dec 17, 2025 at 06:04:56PM +0100, Andrew Lunn wrote:
> > > I think the ideal implementation would be the MAC driver calling some
> > > phy API to apply the quirk, and then that gets passed on to the phy
> > > driver. Surely this isn't the first case of a MAC-PHY combination
> > > needing to go fiddle with some special setting.
> >
> > I was also hoping to find something like that, but I couldn't really
> > find it. However, I will try looking in that direction. At least we can
> > identify the broken MAC via the compatible string of the MAC driver, as
> > they use two different compatibles: 'fsl,imx8mp-fec' (fine) and
> > 'nxp,imx8mp-dwmac-eqos' (affected by the errata).
>
> Maybe see if you can use phy_register_fixup_for_id().
That sounds really promising. Thanks a lot for the tip! I'll try to
address our problem by registering a fixup.
Regards,
Stefan
next prev parent reply other threads:[~2025-12-18 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 8:46 [PATCH net-next v1 0/3] Convert Micrel bindings to YAML, add keep-preamble-before-sfd Stefan Eichenberger
2025-12-12 8:46 ` [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to YAML schema Stefan Eichenberger
2025-12-12 10:29 ` Rob Herring (Arm)
2025-12-12 14:51 ` Stefan Eichenberger
2025-12-12 14:16 ` Simon Horman
2025-12-12 14:52 ` Stefan Eichenberger
2025-12-15 14:37 ` Rob Herring
2025-12-17 9:41 ` Stefan Eichenberger
2025-12-12 8:46 ` [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd Stefan Eichenberger
2025-12-12 10:29 ` Rob Herring (Arm)
2025-12-15 14:03 ` Rob Herring
2025-12-17 9:58 ` Stefan Eichenberger
2025-12-17 12:21 ` Stefan Eichenberger
2025-12-17 13:55 ` Rob Herring
2025-12-17 14:30 ` Stefan Eichenberger
2025-12-17 17:04 ` Andrew Lunn
2025-12-18 8:59 ` Stefan Eichenberger [this message]
2025-12-12 8:46 ` [PATCH net-next v1 3/3] net: phy: micrel: Add keep-preamble-before-sfd property Stefan Eichenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUPCeeRkLwUBBlax@eichest-laptop \
--to=eichest@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=ben.dooks@codethink.co.uk \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael.beims@toradex.com \
--cc=robh@kernel.org \
--cc=stefan.eichenberger@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox