* [PATCH 0/2] battery: Add SiLION battery technology
@ 2025-11-24 11:12 Rakesh Kota
2025-11-24 11:12 ` [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology Rakesh Kota
2025-11-24 11:12 ` [PATCH 2/2] power: supply: core: Add SiLION battery technology Rakesh Kota
0 siblings, 2 replies; 9+ messages in thread
From: Rakesh Kota @ 2025-11-24 11:12 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu,
Rakesh Kota
This patch series updates the battery dt-bindings and
driver to add support for SiLION battery technology.
Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
Rakesh Kota (2):
dt-bindings: battery: Add SiLION battery bindings technology
power: supply: core: Add SiLION battery technology
Documentation/ABI/testing/sysfs-class-power | 2 +-
Documentation/devicetree/bindings/power/supply/battery.yaml | 1 +
drivers/power/supply/power_supply_core.c | 2 ++
drivers/power/supply/power_supply_sysfs.c | 1 +
drivers/power/supply/test_power.c | 3 ++-
include/linux/power_supply.h | 1 +
6 files changed, 8 insertions(+), 2 deletions(-)
---
base-commit: d724c6f85e80a23ed46b7ebc6e38b527c09d64f5
change-id: 20251124-add_silion_battery-5b4a97494559
Best regards,
--
Rakesh Kota <rakesh.kota@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology 2025-11-24 11:12 [PATCH 0/2] battery: Add SiLION battery technology Rakesh Kota @ 2025-11-24 11:12 ` Rakesh Kota 2025-11-24 11:37 ` Krzysztof Kozlowski 2025-11-24 11:12 ` [PATCH 2/2] power: supply: core: Add SiLION battery technology Rakesh Kota 1 sibling, 1 reply; 9+ messages in thread From: Rakesh Kota @ 2025-11-24 11:12 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu, Rakesh Kota Document a new battery chemistry for silicon-anode lithium-ion cells. Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> --- Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml index 491488e7b970397b409c248fb0c2a524301686a9..49cbd03956eeb9fc8be72540d8bf35840ccd7156 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.yaml +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml @@ -44,6 +44,7 @@ properties: - const: lithium-ion-polymer - const: lithium-ion-iron-phosphate - const: lithium-ion-manganese-oxide + - const: lithium-ion-silicon-anode over-voltage-threshold-microvolt: description: battery over-voltage limit -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology 2025-11-24 11:12 ` [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology Rakesh Kota @ 2025-11-24 11:37 ` Krzysztof Kozlowski 2025-11-25 14:59 ` Rakesh Kota 0 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2025-11-24 11:37 UTC (permalink / raw) To: Rakesh Kota, Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu On 24/11/2025 12:12, Rakesh Kota wrote: > Document a new battery chemistry for silicon-anode lithium-ion > cells. > > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml > index 491488e7b970397b409c248fb0c2a524301686a9..49cbd03956eeb9fc8be72540d8bf35840ccd7156 100644 > --- a/Documentation/devicetree/bindings/power/supply/battery.yaml > +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml > @@ -44,6 +44,7 @@ properties: > - const: lithium-ion-polymer > - const: lithium-ion-iron-phosphate > - const: lithium-ion-manganese-oxide > + - const: lithium-ion-silicon-anode Where is any DTS user of this? You have entire cover letter to explain the background WHY you are doing this. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology 2025-11-24 11:37 ` Krzysztof Kozlowski @ 2025-11-25 14:59 ` Rakesh Kota 2025-11-26 8:14 ` Krzysztof Kozlowski 0 siblings, 1 reply; 9+ messages in thread From: Rakesh Kota @ 2025-11-25 14:59 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu On Mon, Nov 24, 2025 at 12:37:01PM +0100, Krzysztof Kozlowski wrote: > On 24/11/2025 12:12, Rakesh Kota wrote: > > Document a new battery chemistry for silicon-anode lithium-ion > > cells. > > > > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> > > --- > > Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml > > index 491488e7b970397b409c248fb0c2a524301686a9..49cbd03956eeb9fc8be72540d8bf35840ccd7156 100644 > > --- a/Documentation/devicetree/bindings/power/supply/battery.yaml > > +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml > > @@ -44,6 +44,7 @@ properties: > > - const: lithium-ion-polymer > > - const: lithium-ion-iron-phosphate > > - const: lithium-ion-manganese-oxide > > + - const: lithium-ion-silicon-anode > > > Where is any DTS user of this? You have entire cover letter to explain > the background WHY you are doing this. This new lithium-ion-silicon-anode chemistry is intended for the Kaanapali platform, where we validate the silicon-anode Li-ion cells. The bindings and driver changes were tested with the Kaanapali device. I will update the background in the cover-letter in the next revision. Best regards Rakesh > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology 2025-11-25 14:59 ` Rakesh Kota @ 2025-11-26 8:14 ` Krzysztof Kozlowski 2025-11-26 13:06 ` Rakesh Kota 0 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2025-11-26 8:14 UTC (permalink / raw) To: Rakesh Kota Cc: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu On 25/11/2025 15:59, Rakesh Kota wrote: > On Mon, Nov 24, 2025 at 12:37:01PM +0100, Krzysztof Kozlowski wrote: >> On 24/11/2025 12:12, Rakesh Kota wrote: >>> Document a new battery chemistry for silicon-anode lithium-ion >>> cells. >>> >>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> >>> --- >>> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> index 491488e7b970397b409c248fb0c2a524301686a9..49cbd03956eeb9fc8be72540d8bf35840ccd7156 100644 >>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml >>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> @@ -44,6 +44,7 @@ properties: >>> - const: lithium-ion-polymer >>> - const: lithium-ion-iron-phosphate >>> - const: lithium-ion-manganese-oxide >>> + - const: lithium-ion-silicon-anode >> >> >> Where is any DTS user of this? You have entire cover letter to explain >> the background WHY you are doing this. > This new lithium-ion-silicon-anode chemistry is intended for the > Kaanapali platform, where we validate the silicon-anode Li-ion cells. > The bindings and driver changes were tested with the Kaanapali device. Again: DTS. Please answer that part. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology 2025-11-26 8:14 ` Krzysztof Kozlowski @ 2025-11-26 13:06 ` Rakesh Kota 0 siblings, 0 replies; 9+ messages in thread From: Rakesh Kota @ 2025-11-26 13:06 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu On Wed, Nov 26, 2025 at 09:14:23AM +0100, Krzysztof Kozlowski wrote: > On 25/11/2025 15:59, Rakesh Kota wrote: > > On Mon, Nov 24, 2025 at 12:37:01PM +0100, Krzysztof Kozlowski wrote: > >> On 24/11/2025 12:12, Rakesh Kota wrote: > >>> Document a new battery chemistry for silicon-anode lithium-ion > >>> cells. > >>> > >>> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> > >>> --- > >>> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml > >>> index 491488e7b970397b409c248fb0c2a524301686a9..49cbd03956eeb9fc8be72540d8bf35840ccd7156 100644 > >>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml > >>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml > >>> @@ -44,6 +44,7 @@ properties: > >>> - const: lithium-ion-polymer > >>> - const: lithium-ion-iron-phosphate > >>> - const: lithium-ion-manganese-oxide > >>> + - const: lithium-ion-silicon-anode > >> > >> > >> Where is any DTS user of this? You have entire cover letter to explain > >> the background WHY you are doing this. > > This new lithium-ion-silicon-anode chemistry is intended for the > > Kaanapali platform, where we validate the silicon-anode Li-ion cells. > > The bindings and driver changes were tested with the Kaanapali device. > Again: DTS. Please answer that part. > Actually, the device-chemistry property (lithium-ion-silicon-anode) is not added in Kaanapali DT because this battery chemistry and other information is obtained from the charger firmware, which runs on the remote processor. I added this change mainly for completeness. If you feel it isn’t necessary, I’m fine with dropping it and proceeding without this change. Best regards, Rakesh > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] power: supply: core: Add SiLION battery technology 2025-11-24 11:12 [PATCH 0/2] battery: Add SiLION battery technology Rakesh Kota 2025-11-24 11:12 ` [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology Rakesh Kota @ 2025-11-24 11:12 ` Rakesh Kota 2025-12-21 12:57 ` Sebastian Reichel 1 sibling, 1 reply; 9+ messages in thread From: Rakesh Kota @ 2025-11-24 11:12 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu, Rakesh Kota Add support for lithium-ion-silicon-anode (SiLION) battery technology to enable proper identification of devices using this newer battery chemistry. Without this change, such batteries would report as unknown technology. Introduce POWER_SUPPLY_TECHNOLOGY_SiLION and update technology mappings across core, sysfs, and test interfaces. Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> --- Documentation/ABI/testing/sysfs-class-power | 2 +- drivers/power/supply/power_supply_core.c | 2 ++ drivers/power/supply/power_supply_sysfs.c | 1 + drivers/power/supply/test_power.c | 3 ++- include/linux/power_supply.h | 1 + 5 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power index 4b21d5d2325136be65126d4d1d6e64608280fe44..1f42e6f138ea8ae0fe8c232c38d0ff6fb20180e7 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -525,7 +525,7 @@ Description: Valid values: "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", - "NiCd", "LiMn" + "NiCd", "LiMn", "Si-Li-ion" What: /sys/class/power_supply/<supply_name>/voltage_avg, diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index 9a28381e2607d650fa9b719b683af375bb118fad..385ab8aa7e69f3f804e7ac0ee3782446f18e2c3f 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c @@ -677,6 +677,8 @@ int power_supply_get_battery_info(struct power_supply *psy, info->technology = POWER_SUPPLY_TECHNOLOGY_LiFe; else if (!strcmp("lithium-ion-manganese-oxide", value)) info->technology = POWER_SUPPLY_TECHNOLOGY_LiMn; + else if (!strcmp("lithium-ion-silicon-anode", value)) + info->technology = POWER_SUPPLY_TECHNOLOGY_SiLION; else dev_warn(&psy->dev, "%s unknown battery type\n", value); } diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index 198405f7126f96a57a549cd1ecb9b71089b9c3d0..f2a5ec519b2ef60fb5ede101ca461d899218e186 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -122,6 +122,7 @@ static const char * const POWER_SUPPLY_TECHNOLOGY_TEXT[] = { [POWER_SUPPLY_TECHNOLOGY_LiFe] = "LiFe", [POWER_SUPPLY_TECHNOLOGY_NiCd] = "NiCd", [POWER_SUPPLY_TECHNOLOGY_LiMn] = "LiMn", + [POWER_SUPPLY_TECHNOLOGY_SiLION] = "Si-Li-ion", }; static const char * const POWER_SUPPLY_CAPACITY_LEVEL_TEXT[] = { diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c index 2c0e9ad820c0db23165758303a16bddac1a1634b..64bd4a1147ca06566a909513a80760ad707a8605 100644 --- a/drivers/power/supply/test_power.c +++ b/drivers/power/supply/test_power.c @@ -437,6 +437,7 @@ static struct battery_property_map map_technology[] = { { POWER_SUPPLY_TECHNOLOGY_LiFe, "LiFe" }, { POWER_SUPPLY_TECHNOLOGY_NiCd, "NiCd" }, { POWER_SUPPLY_TECHNOLOGY_LiMn, "LiMn" }, + { POWER_SUPPLY_TECHNOLOGY_SiLION, "SiLION" }, { -1, NULL }, }; @@ -733,7 +734,7 @@ MODULE_PARM_DESC(battery_present, module_param(battery_technology, battery_technology, 0644); MODULE_PARM_DESC(battery_technology, - "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn>"); + "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn|SiLION>"); module_param(battery_health, battery_health, 0644); MODULE_PARM_DESC(battery_health, diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 360ffdf272dab86241f1aac4650d1a91a088a84b..04996037219d5a22d2b2a7f136e5d3565a4507ca 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -83,6 +83,7 @@ enum { POWER_SUPPLY_TECHNOLOGY_LiFe, POWER_SUPPLY_TECHNOLOGY_NiCd, POWER_SUPPLY_TECHNOLOGY_LiMn, + POWER_SUPPLY_TECHNOLOGY_SiLION, }; enum { -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] power: supply: core: Add SiLION battery technology 2025-11-24 11:12 ` [PATCH 2/2] power: supply: core: Add SiLION battery technology Rakesh Kota @ 2025-12-21 12:57 ` Sebastian Reichel 2025-12-23 9:11 ` Rakesh Kota 0 siblings, 1 reply; 9+ messages in thread From: Sebastian Reichel @ 2025-12-21 12:57 UTC (permalink / raw) To: Rakesh Kota Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu Hi, On Mon, Nov 24, 2025 at 04:42:41PM +0530, Rakesh Kota wrote: > Add support for lithium-ion-silicon-anode (SiLION) battery technology > to enable proper identification of devices using this newer battery > chemistry. Without this change, such batteries would report as > unknown technology. > > Introduce POWER_SUPPLY_TECHNOLOGY_SiLION and update technology > mappings across core, sysfs, and test interfaces. > > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> > --- The change itself looks good to me, but it must be submitted with a user (e.g. an update to the qcom_battmgr) as a follow-up patch. Greetings, -- Sebastian > Documentation/ABI/testing/sysfs-class-power | 2 +- > drivers/power/supply/power_supply_core.c | 2 ++ > drivers/power/supply/power_supply_sysfs.c | 1 + > drivers/power/supply/test_power.c | 3 ++- > include/linux/power_supply.h | 1 + > 5 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 4b21d5d2325136be65126d4d1d6e64608280fe44..1f42e6f138ea8ae0fe8c232c38d0ff6fb20180e7 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -525,7 +525,7 @@ Description: > > Valid values: > "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", > - "NiCd", "LiMn" > + "NiCd", "LiMn", "Si-Li-ion" > > > What: /sys/class/power_supply/<supply_name>/voltage_avg, > diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c > index 9a28381e2607d650fa9b719b683af375bb118fad..385ab8aa7e69f3f804e7ac0ee3782446f18e2c3f 100644 > --- a/drivers/power/supply/power_supply_core.c > +++ b/drivers/power/supply/power_supply_core.c > @@ -677,6 +677,8 @@ int power_supply_get_battery_info(struct power_supply *psy, > info->technology = POWER_SUPPLY_TECHNOLOGY_LiFe; > else if (!strcmp("lithium-ion-manganese-oxide", value)) > info->technology = POWER_SUPPLY_TECHNOLOGY_LiMn; > + else if (!strcmp("lithium-ion-silicon-anode", value)) > + info->technology = POWER_SUPPLY_TECHNOLOGY_SiLION; > else > dev_warn(&psy->dev, "%s unknown battery type\n", value); > } > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index 198405f7126f96a57a549cd1ecb9b71089b9c3d0..f2a5ec519b2ef60fb5ede101ca461d899218e186 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -122,6 +122,7 @@ static const char * const POWER_SUPPLY_TECHNOLOGY_TEXT[] = { > [POWER_SUPPLY_TECHNOLOGY_LiFe] = "LiFe", > [POWER_SUPPLY_TECHNOLOGY_NiCd] = "NiCd", > [POWER_SUPPLY_TECHNOLOGY_LiMn] = "LiMn", > + [POWER_SUPPLY_TECHNOLOGY_SiLION] = "Si-Li-ion", > }; > > static const char * const POWER_SUPPLY_CAPACITY_LEVEL_TEXT[] = { > diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c > index 2c0e9ad820c0db23165758303a16bddac1a1634b..64bd4a1147ca06566a909513a80760ad707a8605 100644 > --- a/drivers/power/supply/test_power.c > +++ b/drivers/power/supply/test_power.c > @@ -437,6 +437,7 @@ static struct battery_property_map map_technology[] = { > { POWER_SUPPLY_TECHNOLOGY_LiFe, "LiFe" }, > { POWER_SUPPLY_TECHNOLOGY_NiCd, "NiCd" }, > { POWER_SUPPLY_TECHNOLOGY_LiMn, "LiMn" }, > + { POWER_SUPPLY_TECHNOLOGY_SiLION, "SiLION" }, > { -1, NULL }, > }; > > @@ -733,7 +734,7 @@ MODULE_PARM_DESC(battery_present, > > module_param(battery_technology, battery_technology, 0644); > MODULE_PARM_DESC(battery_technology, > - "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn>"); > + "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn|SiLION>"); > > module_param(battery_health, battery_health, 0644); > MODULE_PARM_DESC(battery_health, > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 360ffdf272dab86241f1aac4650d1a91a088a84b..04996037219d5a22d2b2a7f136e5d3565a4507ca 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -83,6 +83,7 @@ enum { > POWER_SUPPLY_TECHNOLOGY_LiFe, > POWER_SUPPLY_TECHNOLOGY_NiCd, > POWER_SUPPLY_TECHNOLOGY_LiMn, > + POWER_SUPPLY_TECHNOLOGY_SiLION, > }; > > enum { > > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] power: supply: core: Add SiLION battery technology 2025-12-21 12:57 ` Sebastian Reichel @ 2025-12-23 9:11 ` Rakesh Kota 0 siblings, 0 replies; 9+ messages in thread From: Rakesh Kota @ 2025-12-23 9:11 UTC (permalink / raw) To: Sebastian Reichel Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-pm, devicetree, linux-kernel, kamal.wadhwa, fenglin.wu On Sun, Dec 21, 2025 at 09:57:01PM +0900, Sebastian Reichel wrote: > Hi, > > On Mon, Nov 24, 2025 at 04:42:41PM +0530, Rakesh Kota wrote: > > Add support for lithium-ion-silicon-anode (SiLION) battery technology > > to enable proper identification of devices using this newer battery > > chemistry. Without this change, such batteries would report as > > unknown technology. > > > > Introduce POWER_SUPPLY_TECHNOLOGY_SiLION and update technology > > mappings across core, sysfs, and test interfaces. > > > > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com> > > --- > > The change itself looks good to me, but it must be submitted with a > user (e.g. an update to the qcom_battmgr) as a follow-up patch. > Actually, we do not have any changes in the qcom_battmgr driver or in the device tree related to this battery chemistry technology text. The battery chemistry is obtained from the charger firmware, which runs on the remote processor. The charger FW shares the battmgr->info.technology value with us, and based on this value the power supply framework derives and prints the corresponding battery chemistry string. There is no local hard-coding or DT-based battery chemistry mapping. Best regards, Rakesh > Greetings, > > -- Sebastian > > > Documentation/ABI/testing/sysfs-class-power | 2 +- > > drivers/power/supply/power_supply_core.c | 2 ++ > > drivers/power/supply/power_supply_sysfs.c | 1 + > > drivers/power/supply/test_power.c | 3 ++- > > include/linux/power_supply.h | 1 + > > 5 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > > index 4b21d5d2325136be65126d4d1d6e64608280fe44..1f42e6f138ea8ae0fe8c232c38d0ff6fb20180e7 100644 > > --- a/Documentation/ABI/testing/sysfs-class-power > > +++ b/Documentation/ABI/testing/sysfs-class-power > > @@ -525,7 +525,7 @@ Description: > > > > Valid values: > > "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", > > - "NiCd", "LiMn" > > + "NiCd", "LiMn", "Si-Li-ion" > > > > > > What: /sys/class/power_supply/<supply_name>/voltage_avg, > > diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c > > index 9a28381e2607d650fa9b719b683af375bb118fad..385ab8aa7e69f3f804e7ac0ee3782446f18e2c3f 100644 > > --- a/drivers/power/supply/power_supply_core.c > > +++ b/drivers/power/supply/power_supply_core.c > > @@ -677,6 +677,8 @@ int power_supply_get_battery_info(struct power_supply *psy, > > info->technology = POWER_SUPPLY_TECHNOLOGY_LiFe; > > else if (!strcmp("lithium-ion-manganese-oxide", value)) > > info->technology = POWER_SUPPLY_TECHNOLOGY_LiMn; > > + else if (!strcmp("lithium-ion-silicon-anode", value)) > > + info->technology = POWER_SUPPLY_TECHNOLOGY_SiLION; > > else > > dev_warn(&psy->dev, "%s unknown battery type\n", value); > > } > > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > > index 198405f7126f96a57a549cd1ecb9b71089b9c3d0..f2a5ec519b2ef60fb5ede101ca461d899218e186 100644 > > --- a/drivers/power/supply/power_supply_sysfs.c > > +++ b/drivers/power/supply/power_supply_sysfs.c > > @@ -122,6 +122,7 @@ static const char * const POWER_SUPPLY_TECHNOLOGY_TEXT[] = { > > [POWER_SUPPLY_TECHNOLOGY_LiFe] = "LiFe", > > [POWER_SUPPLY_TECHNOLOGY_NiCd] = "NiCd", > > [POWER_SUPPLY_TECHNOLOGY_LiMn] = "LiMn", > > + [POWER_SUPPLY_TECHNOLOGY_SiLION] = "Si-Li-ion", > > }; > > > > static const char * const POWER_SUPPLY_CAPACITY_LEVEL_TEXT[] = { > > diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c > > index 2c0e9ad820c0db23165758303a16bddac1a1634b..64bd4a1147ca06566a909513a80760ad707a8605 100644 > > --- a/drivers/power/supply/test_power.c > > +++ b/drivers/power/supply/test_power.c > > @@ -437,6 +437,7 @@ static struct battery_property_map map_technology[] = { > > { POWER_SUPPLY_TECHNOLOGY_LiFe, "LiFe" }, > > { POWER_SUPPLY_TECHNOLOGY_NiCd, "NiCd" }, > > { POWER_SUPPLY_TECHNOLOGY_LiMn, "LiMn" }, > > + { POWER_SUPPLY_TECHNOLOGY_SiLION, "SiLION" }, > > { -1, NULL }, > > }; > > > > @@ -733,7 +734,7 @@ MODULE_PARM_DESC(battery_present, > > > > module_param(battery_technology, battery_technology, 0644); > > MODULE_PARM_DESC(battery_technology, > > - "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn>"); > > + "battery technology <NiMH|LION|LIPO|LiFe|NiCd|LiMn|SiLION>"); > > > > module_param(battery_health, battery_health, 0644); > > MODULE_PARM_DESC(battery_health, > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > > index 360ffdf272dab86241f1aac4650d1a91a088a84b..04996037219d5a22d2b2a7f136e5d3565a4507ca 100644 > > --- a/include/linux/power_supply.h > > +++ b/include/linux/power_supply.h > > @@ -83,6 +83,7 @@ enum { > > POWER_SUPPLY_TECHNOLOGY_LiFe, > > POWER_SUPPLY_TECHNOLOGY_NiCd, > > POWER_SUPPLY_TECHNOLOGY_LiMn, > > + POWER_SUPPLY_TECHNOLOGY_SiLION, > > }; > > > > enum { > > > > -- > > 2.34.1 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-12-23 9:11 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-24 11:12 [PATCH 0/2] battery: Add SiLION battery technology Rakesh Kota 2025-11-24 11:12 ` [PATCH 1/2] dt-bindings: battery: Add SiLION battery bindings technology Rakesh Kota 2025-11-24 11:37 ` Krzysztof Kozlowski 2025-11-25 14:59 ` Rakesh Kota 2025-11-26 8:14 ` Krzysztof Kozlowski 2025-11-26 13:06 ` Rakesh Kota 2025-11-24 11:12 ` [PATCH 2/2] power: supply: core: Add SiLION battery technology Rakesh Kota 2025-12-21 12:57 ` Sebastian Reichel 2025-12-23 9:11 ` Rakesh Kota
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).