devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5
Date: Mon, 22 Dec 2025 14:24:57 +0100	[thread overview]
Message-ID: <aUlGPGFYYf8Ndn5D@venus> (raw)
In-Reply-To: <20251220100010.26643-1-amadeus@jmu.edu.cn>

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

Hi,

On Sat, Dec 20, 2025 at 06:00:08PM +0800, Chukun Pan wrote:
> According to the schematic, RTC is powered by vcc_3v3_s3.
> The vcc_3v3_rtc_s5 regulator does not exist, remove it.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---

That's true for all board revisions that have a public schematic
(1.1, 1.2 and 1.3), so:

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> index 3386084f6318..392ba83ab05a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> @@ -156,16 +156,6 @@ vcc_3v3_pcie: regulator-vcc-3v3-pcie {
>  		vin-supply = <&vcc_5v0_sys>;
>  	};
>  
> -	vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vcc_3v3_rtc_s5";
> -		regulator-boot-on;
> -		regulator-always-on;
> -		regulator-min-microvolt = <3300000>;
> -		regulator-max-microvolt = <3300000>;
> -		vin-supply = <&vcc_5v0_sys>;
> -	};
> -
>  	vcc_3v3_s0: regulator-vcc-3v3-s0 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc_3v3_s0";
> -- 
> 2.25.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2025-12-22 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
2025-12-20 10:00 ` [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin " Chukun Pan
2025-12-22 13:28   ` Sebastian Reichel
2025-12-20 10:00 ` [PATCH 3/3] arm64: dts: rockchip: enable saradc " Chukun Pan
2025-12-22 13:32   ` Sebastian Reichel
2025-12-22 13:39     ` Heiko Stuebner
2025-12-22 13:24 ` Sebastian Reichel [this message]
2025-12-22 13:38 ` [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUlGPGFYYf8Ndn5D@venus \
    --to=sebastian.reichel@collabora.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).