From: Lukas Timmermann <linux@timmermann.space>
To: Lee Jones <lee@kernel.org>,
pavel@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 0/2] Support for Osram as3668 LED driver
Date: Tue, 23 Dec 2025 22:52:14 +0100 [thread overview]
Message-ID: <aUsN9pK1i3u5D8Uc@archstation> (raw)
In-Reply-To: <176572651204.304949.14632935583958995926.b4-ty@kernel.org>
On Sun, Dec 14, 2025 at 03:35:12PM +0000, Lee Jones wrote:
> On Tue, 25 Nov 2025 12:40:13 +0100, Lukas Timmermann wrote:
> > This patch adds basic support for the as3668 driver IC via I2C interface.
> > The IC is capable of driving four individual LEDs up to 25.5mA per
> > channel. Hardware blinking would be theoretically possible, but this chip
> > only supports a few set on/off-delays which makes using that feature
> > unfeasable, therefore my driver doesn't offer that capability.
> > It's intended applications is in mobile devices such as phones,
> > tablets and cameras. This driver was tested and is working on
> > a google-manta which is running postmarketOS with a near mainline kernel.
> > Also there is a patch in the linux mailing list for that device:
> > https://lore.kernel.org/all/20251120201958.1970828-1-linux@timmermann.space/
> > The register names and values are taken from the official datasheet which
> > can be found here:
> > https://www.mouser.com/datasheet/2/588/AS3668_DS000196_1-00-1512816.pdf
> >
> > [...]
>
> Applied, thanks!
Overall great news, thanks. There is a newer version (v13) with a few fixes
available here:
https://lore.kernel.org/all/20251201230601.285641-1-linux@timmermann.space/
Have you seen this version?
There are smaller corrections around as3668_channel_mode_set()
Could be worth to drop this version and reapply. What are your thoughts on this?
Best regards
Lukas Timmermann
>
> [1/2] dt-bindings: leds: Add new as3668 support
> commit: a093bc82b6013c40add22b96deed4d2b67905f41
> [2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver
> commit: 8856d7fe1758937ac528770f552ec58c388c255b
>
> --
> Lee Jones [李琼斯]
>
>
prev parent reply other threads:[~2025-12-23 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:40 [PATCH v11 0/2] Support for Osram as3668 LED driver Lukas Timmermann
2025-11-25 11:40 ` [PATCH v11 1/2] dt-bindings: leds: Add new as3668 support Lukas Timmermann
2025-11-25 11:40 ` [PATCH v11 2/2] leds: as3668: Driver for the ams Osram 4-channel i2c LED driver Lukas Timmermann
2025-12-14 15:35 ` [PATCH v11 0/2] Support for Osram as3668 " Lee Jones
2025-12-23 21:52 ` Lukas Timmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUsN9pK1i3u5D8Uc@archstation \
--to=linux@timmermann.space \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox