From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B41152D7DEC; Wed, 24 Dec 2025 05:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766554135; cv=none; b=JKIJm276m0ENNqeZJkPzK4EzFhNYoE0f0v0aHYncQEMPGC9Bu7RviLfqH4QT/aDRCwaUEr6vWxAOZkdZYLZKcDXybpKk8QvEXabbVnbEeSERO51u7IZmIY1THAQ9h3ezhz8kR49lC2E5gVTzRkSD2mAVKM8xebC7aUOz9Pomc7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766554135; c=relaxed/simple; bh=C/GnFv5Pg+zL30Vai7m1dAM/fuNNOsDmUVTl2nzGmnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TdNUikdeRzedwGcpghAefLQPIyKhQcuXf1dMD5W+XTP8WqcSpFJqDA68fKmDRORwXKHdwmP7aKNlUOCsdatBH5eAfPGhUaaO8GLq/B3adRToBf9Q5OUEJM4km+MgAkwpxrnEjkcs46/JK2FffGJy7FJGLnQtqEk+uVDeZbpZyME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bqfPidJQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bqfPidJQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A6DC4CEFB; Wed, 24 Dec 2025 05:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766554135; bh=C/GnFv5Pg+zL30Vai7m1dAM/fuNNOsDmUVTl2nzGmnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bqfPidJQ/miNSrvls/TdR7kU/lfIuBMklmL10AS7LDhpmL3gBNFmwxacDsdB+GUA2 vFSdukiXuF5DEI14JKyOKdXPfKcwqC+b6X82OwNGaVEk7Xxw/7AHyVC0bddeMFqnfj CVjUoFmMxOOfqfe8H2vyhLrbGxk7u+FqgM8D28+DYj3kWxK5idnuoad//uZxkEQ2SK JERX6FjcM1IzxmzThOptRHAwlUS+fl1bocqPBhfWm4zP0B45GEHLVrAwCpugABEriT rZpzTQCa7xyILtgv+UrjNkIQ8ySIpUSoOs/dVk9kelHyxiPtTqoDimKImgSVxQPz0T SdFeLY6uaNHSQ== Date: Wed, 24 Dec 2025 10:58:51 +0530 From: Vinod Koul To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Krishna Kurapati , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Pengyu Luo , Johan Hovold , Luca Weiss , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Message-ID: References: <20251219173108.2119296-1-krishna.kurapati@oss.qualcomm.com> <20251219173108.2119296-2-krishna.kurapati@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 23-12-25, 21:16, Dmitry Baryshkov wrote: > On Tue, Dec 23, 2025 at 09:18:37PM +0530, Vinod Koul wrote: > > On 23-12-25, 15:16, Krzysztof Kozlowski wrote: > > > On 23/12/2025 15:11, Vinod Koul wrote: > > > > On 19-12-25, 23:01, Krishna Kurapati wrote: > > > >> Add squelch detect parameter update for synopsys eusb2 repeater. The > > > >> values (indicated in basis-points) depict a percentage change with > > > >> respect to the nominal value. > > > >> > > > >> Signed-off-by: Krishna Kurapati > > > >> Reviewed-by: Krzysztof Kozlowski > > > >> --- > > > >> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++ > > > >> 1 file changed, 8 insertions(+) > > > >> > > > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > > > >> index 5bf0d6c9c025..f2afcf0e986a 100644 > > > >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > > > >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml > > > >> @@ -59,6 +59,14 @@ properties: > > > >> minimum: 0 > > > >> maximum: 7 > > > >> > > > >> + qcom,squelch-detector-bp: > > > >> + description: > > > >> + This adjusts the voltage level for the threshold used to detect valid > > > >> + high-speed data. > > > >> + minimum: -6000 > > > > > > > > 6000Volts, mV, can you please document the units? > > > > > > > > > Code is correct, the '-bp' is the unit here. Unless the suffix was > > > chosen incorrectly? > > > > I was hoping it will be commented in the description here. > > For my reference, what is bp and where is it documented ? > > Base points, 0.01% Thanks Dmitry, where is this documented for people who dont know -- ~Vinod