* Re: [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart
2025-12-03 1:59 [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Sherry Sun
@ 2025-12-03 17:41 ` Frank Li
2025-12-04 7:44 ` Alexander Stein
2025-12-30 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-12-03 17:41 UTC (permalink / raw)
To: Sherry Sun
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, festevam,
alexander.stein, devicetree, kernel, linux-kernel, imx,
linux-arm-kernel
On Wed, Dec 03, 2025 at 09:59:56AM +0800, Sherry Sun wrote:
> The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel
> order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss
> update imx8qm-ss-dma.dtsi.
>
> The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart
> dma-names") just simple add dma-names as binding doc requirement.
>
> Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for
> the FSL_EDMA_RX flag.
>
> Fixes: 5a8e9b022e56 ("arm64: dts: imx8qm-ss-dma: Pass lpuart dma-names")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in V2:
> 1. Correct the fixes commit as Frank and Alexander suggested.
> ---
> arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> index 5f24850bf322..974e193f8dcb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> @@ -172,25 +172,25 @@ &flexcan3 {
>
> &lpuart0 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 13 0 0>, <&edma2 12 0 1>;
> + dmas = <&edma2 12 0 FSL_EDMA_RX>, <&edma2 13 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart1 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 15 0 0>, <&edma2 14 0 1>;
> + dmas = <&edma2 14 0 FSL_EDMA_RX>, <&edma2 15 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart2 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 17 0 0>, <&edma2 16 0 1>;
> + dmas = <&edma2 16 0 FSL_EDMA_RX>, <&edma2 17 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart3 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 19 0 0>, <&edma2 18 0 1>;
> + dmas = <&edma2 18 0 FSL_EDMA_RX>, <&edma2 19 0 0>;
> dma-names = "rx","tx";
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart
2025-12-03 1:59 [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Sherry Sun
2025-12-03 17:41 ` Frank Li
@ 2025-12-04 7:44 ` Alexander Stein
2025-12-30 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2025-12-04 7:44 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, festevam, frank.li,
Sherry Sun
Cc: devicetree, kernel, linux-kernel, imx, linux-arm-kernel
Hi,
Am Mittwoch, 3. Dezember 2025, 02:59:56 CET schrieb Sherry Sun:
> The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel
> order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss
> update imx8qm-ss-dma.dtsi.
>
> The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart
> dma-names") just simple add dma-names as binding doc requirement.
>
> Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for
> the FSL_EDMA_RX flag.
>
> Fixes: 5a8e9b022e56 ("arm64: dts: imx8qm-ss-dma: Pass lpuart dma-names")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in V2:
> 1. Correct the fixes commit as Frank and Alexander suggested.
> ---
> arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> index 5f24850bf322..974e193f8dcb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi
> @@ -172,25 +172,25 @@ &flexcan3 {
>
> &lpuart0 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 13 0 0>, <&edma2 12 0 1>;
> + dmas = <&edma2 12 0 FSL_EDMA_RX>, <&edma2 13 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart1 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 15 0 0>, <&edma2 14 0 1>;
> + dmas = <&edma2 14 0 FSL_EDMA_RX>, <&edma2 15 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart2 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 17 0 0>, <&edma2 16 0 1>;
> + dmas = <&edma2 16 0 FSL_EDMA_RX>, <&edma2 17 0 0>;
> dma-names = "rx","tx";
> };
>
> &lpuart3 {
> compatible = "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart";
> - dmas = <&edma2 19 0 0>, <&edma2 18 0 1>;
> + dmas = <&edma2 18 0 FSL_EDMA_RX>, <&edma2 19 0 0>;
> dma-names = "rx","tx";
> };
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart
2025-12-03 1:59 [PATCH V2] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Sherry Sun
2025-12-03 17:41 ` Frank Li
2025-12-04 7:44 ` Alexander Stein
@ 2025-12-30 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2025-12-30 2:34 UTC (permalink / raw)
To: Sherry Sun
Cc: robh, krzk+dt, conor+dt, s.hauer, festevam, alexander.stein,
frank.li, devicetree, kernel, linux-kernel, imx, linux-arm-kernel
On Wed, Dec 03, 2025 at 09:59:56AM +0800, Sherry Sun wrote:
> The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel
> order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss
> update imx8qm-ss-dma.dtsi.
>
> The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart
> dma-names") just simple add dma-names as binding doc requirement.
>
> Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for
> the FSL_EDMA_RX flag.
>
> Fixes: 5a8e9b022e56 ("arm64: dts: imx8qm-ss-dma: Pass lpuart dma-names")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread