From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28D183451DC; Mon, 19 Jan 2026 08:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768812062; cv=none; b=BwiC2PWoYkXDB/AAPnQ1jQWu2gtAfX+TVWd+fEoTt1kD059YZBDM04OwZeS5qQFibZB3uIWqmjsLlZ+h2MLPv7cD7f1BzFAN1zb/EqFsmJsekeKZ3efDgeEYVD9y37HGEdcB8AzB/CVetWeNGQgefchXV1hlVGkLuAnw1JbyKms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768812062; c=relaxed/simple; bh=/TyDRQqGCUqDJh9nuLPOvAdZ90y9Nua2yH0fzJ7GwYw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=frbb019FBGH3OWOhqjgKJnAvwBuh+s2TeeK1HByjf2gC+QzeHkpYsND1XyjFIoIFzUsT/dM03dXKme1CV3SYPxvs6bScxsxIJIwi5LQtlMgy8zv+nb2MpUhWl+JtsIeuOgJNZxSIMEKRpJm+XClHSsBgw+4qbD8j5HCueRuB1pA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ECxQfvhO; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ECxQfvhO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768812058; x=1800348058; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/TyDRQqGCUqDJh9nuLPOvAdZ90y9Nua2yH0fzJ7GwYw=; b=ECxQfvhOEAt0LyfF5I5mL74G921JUJCjJ+bGeDUDpK+IN7rdpZd+A2Py Ws0g/eSP9ddJAK6aRd9x+nV55UIRC9V1F1w4tjbYOE8K0cFcdLwRHkJEF rvTT498zzW7F8o7XVNhPeaHpzKytjRUUXE6ahwMio7I1qjzKZDmtLkzpP f7tyy1/Va4WQ+3n3Y0nWclXpbpJOa+5cl8cWeD1hgkteSLHZcWJ3jnUbH X/pWy93obllbG85YId1CLrDaNEEBXYSByaZvz9fCgNbjXxeDlC/qzwBuD +lhOh1ZTHZSfKSPEH1/lcRcM5rc/KuBm5kGj/tk2xtVKjVdLV2EQ/A+NI w==; X-CSE-ConnectionGUID: SqP9K6x3SFigwEONQPRbBw== X-CSE-MsgGUID: RjJoPBZ1Q8Si9ZBzKYT77g== X-IronPort-AV: E=McAfee;i="6800,10657,11675"; a="69218849" X-IronPort-AV: E=Sophos;i="6.21,237,1763452800"; d="scan'208";a="69218849" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 00:40:53 -0800 X-CSE-ConnectionGUID: fpwAu5blTI+YvN7Q9oRZhQ== X-CSE-MsgGUID: irTG1gvLTo6wpaj3MAMv1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,237,1763452800"; d="scan'208";a="228745604" Received: from rvuia-mobl.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.44]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 00:40:50 -0800 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 51CEF120280; Mon, 19 Jan 2026 10:40:53 +0200 (EET) Date: Mon, 19 Jan 2026 10:40:53 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Richard Acayan Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Tianshu Qiu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Robert Mader , Bryan O'Donoghue , Vladimir Zapolskiy , David Heidelberg , phone-devel@vger.kernel.org Subject: Re: [PATCH v7 1/5] dt-bindings: media: i2c: Add Sony IMX355 Message-ID: References: <20260117040657.27043-1-mailingradian@gmail.com> <20260117040657.27043-2-mailingradian@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260117040657.27043-2-mailingradian@gmail.com> Hi Richard, On Fri, Jan 16, 2026 at 11:06:53PM -0500, Richard Acayan wrote: > The IMX355 camera sensor is a camera sensor that can be found as the > front camera in some smartphones, such as the Pixel 3, Pixel 3 XL, Pixel > 3a, and Pixel 3a XL. It already has a driver, but needs support for > device tree. Document the IMX355 to support defining it in device tree. > > Reviewed-by: Vladimir Zapolskiy > Signed-off-by: Richard Acayan > --- > .../bindings/media/i2c/sony,imx355.yaml | 105 ++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml > new file mode 100644 > index 000000000000..0a3aa63b7b5f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/sony,imx355.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX355 Sensor > + > +maintainers: > + - Richard Acayan > + > +description: > + The IMX355 sensor is a 3280x2464 image sensor, commonly found as the front > + camera in smartphones. > + > +allOf: > + - $ref: /schemas/media/video-interface-devices.yaml# > + > +properties: > + compatible: > + const: sony,imx355 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + avdd-supply: > + description: Analog power supply. > + > + dvdd-supply: > + description: Digital power supply. > + > + dovdd-supply: > + description: Interface power supply. > + > + reset-gpios: > + description: Reset GPIO (active low). > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml > + unevaluatedProperties: false Can you add data-lanes property with the default of 4? That's what the driver uses and can't do anything else right now -- the driver should actually fail if the number of lanes differs; a patch to do that would be nice. > + > + required: > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - avdd-supply > + - dvdd-supply > + - dovdd-supply > + - port > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx355"; > + reg = <0x1a>; > + > + clocks = <&camcc CAM_CC_MCLK2_CLK>; > + > + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>; > + assigned-clock-rates = <24000000>; > + > + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>; > + > + avdd-supply = <&cam_front_ldo>; > + dvdd-supply = <&cam_front_ldo>; > + dovdd-supply = <&cam_vio_ldo>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&cam_front_default>; > + > + rotation = <270>; > + orientation = <0>; > + > + port { > + cam_front_endpoint: endpoint { > + link-frequencies = /bits/ 64 <360000000>; > + remote-endpoint = <&camss_endpoint1>; > + }; > + }; > + }; > + }; -- Kind regards, Sakari Ailus