From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: petr.hodina@protonmail.com
Cc: "Song Qiang" <songqiang1304521@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"David Heidelberg" <david@ixit.cz>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: proximity: vl53l0x-i2c: Fix reset sequence
Date: Mon, 19 Jan 2026 20:22:39 +0200 [thread overview]
Message-ID: <aW52bwvXOrsSUMLX@smile.fi.intel.com> (raw)
In-Reply-To: <20260119-vl53l0x-v1-3-cf71715a1353@protonmail.com>
On Mon, Jan 19, 2026 at 06:19:57PM +0100, Petr Hodina via B4 Relay wrote:
> Fix the reset GPIO handling and power-up timing to better match the
> VL53L0X reset requirements.
...
> - usleep_range(3200, 5000);
> + usleep_range(5000, 6000);
> + usleep_range(5000, 6000);
> + usleep_range(5000, 6000);
Can you switch to fsleep() while at it?
...
> - data->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH);
> + data->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_LOW);
> if (IS_ERR(data->reset_gpio))
> return dev_err_probe(&client->dev, PTR_ERR(data->reset_gpio),
> "Cannot get reset GPIO\n");
Wondering if in a future change this can be converted to use reset-gpio driver
instead of poking GPIOs directly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-19 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 17:19 [PATCH 0/4] iio: proximity: vl53l0x: power sequencing, optional VDDIO, raw I2C ID read Petr Hodina via B4 Relay
2026-01-19 17:19 ` [PATCH 1/4] iio: proximity: vl53l0x-i2c: Add optional vddio regulator Petr Hodina via B4 Relay
2026-01-20 10:35 ` Krzysztof Kozlowski
2026-01-20 10:41 ` Krzysztof Kozlowski
2026-01-19 17:19 ` [PATCH 2/4] iio: proximity: vl53l0x-i2c: Add optional vddio supply Petr Hodina via B4 Relay
2026-01-23 9:13 ` Jonathan Cameron
2026-01-19 17:19 ` [PATCH 3/4] iio: proximity: vl53l0x-i2c: Fix reset sequence Petr Hodina via B4 Relay
2026-01-19 18:22 ` Andy Shevchenko [this message]
2026-01-20 10:33 ` Krzysztof Kozlowski
2026-01-19 17:19 ` [PATCH 4/4] iio: proximity: vl53l0x-i2c: Use raw I2C access and read full device ID Petr Hodina via B4 Relay
2026-01-19 18:44 ` Andy Shevchenko
2026-01-20 10:42 ` Krzysztof Kozlowski
2026-01-23 9:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW52bwvXOrsSUMLX@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petr.hodina@protonmail.com \
--cc=robh@kernel.org \
--cc=songqiang1304521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox