From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: Rob Herring <robh@kernel.org>
Cc: conor@kernel.org, krzk+dt@kernel.org, pjw@kernel.org,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, alex@ghiti.fr, cyy@cyyself.name,
kingxukai@zohomail.com, TroyMitchell988@gmail.com,
gaohan@iscas.ac.cn, me@ziyao.cc
Subject: Re: [PATCH v2 2/2] riscv: dts: canaan: Add initial dshanpi board DT files
Date: Fri, 9 Jan 2026 09:49:24 +0800 [thread overview]
Message-ID: <aWBepFEpO45Ocowb@duge-virtual-machine> (raw)
In-Reply-To: <20260106182754.GA2506656-robh@kernel.org>
On Tue, Jan 06, 2026 at 12:27:54PM -0600, Rob Herring wrote:
> On Sun, Jan 04, 2026 at 03:09:11PM +0800, Jiayu Du wrote:
> > + model = "100ask CanMV-K230-Module-dshanpi";
> > + compatible = "100ask,canmv-k230-module-dshanpi",
> > + "canaan,kendryte-k230";
>
> These get overwritten, but aren't really valid on their own. Drop.
>
...
> > + timerx_pulse_in: clock-50m {
>
> clock-50000000
>
Thanks for your review. I will fix it in the v2.
prev parent reply other threads:[~2026-01-09 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 7:09 [PATCH v2 0/2] Initial support for 100ask CanMV-K230 DshanPi Jiayu Du
2026-01-04 7:09 ` [PATCH v2 1/2] dt-bindings: riscv: canaan: add 100ask K230 boards compatible strings Jiayu Du
2026-01-06 18:28 ` Rob Herring (Arm)
2026-01-04 7:09 ` [PATCH v2 2/2] riscv: dts: canaan: Add initial dshanpi board DT files Jiayu Du
2026-01-06 18:27 ` Rob Herring
2026-01-09 1:49 ` Jiayu Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWBepFEpO45Ocowb@duge-virtual-machine \
--to=jiayu.riscv@isrc.iscas.ac.cn \
--cc=TroyMitchell988@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=kingxukai@zohomail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@ziyao.cc \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox