Re: [PATCH v7 1/2] media: dt-bindings: i2c: add Himax HM1246 image sensor

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Matthias,

On Mon, Jan 12, 2026 at 03:49:32PM +0100, Matthias Fend wrote:
> Add YAML device tree binding for Himax HM1246 image sensor.
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
> ---
>  .../bindings/media/i2c/himax,hm1246.yaml           | 117 +++++++++++++++++++++
>  MAINTAINERS                                        |   7 ++
>  2 files changed, 124 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..deecc1105105a67e81d1ddb7f31324baa8188f88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Matthias Fend <matthias.fend@emfend.at>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/himax,hm1246.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax HM1246-AWD 1/3.7-Inch megapixel SoC image sensor
> +
> +maintainers:
> +  - Matthias Fend <matthias.fend@emfend.at>
> +
> +description:
> +  The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active
> +  array size of 1296 x 976. It is programmable through an I2C interface and
> +  connected via parallel bus.
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: himax,hm1246
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: Input reference clock (6 - 27 MHz)
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: Active low XSHUTDOWN pin
> +    maxItems: 1
> +
> +  avdd-supply:
> +    description: Power for analog circuit (3.0 - 3.6 V)
> +
> +  iovdd-supply:
> +    description: Power for I/O circuit (1.7 - 3.6 V)
> +
> +  dvdd-supply:
> +    description: Power for digital circuit (1.5 / 1.8 V)
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +    description: Parallel video output port
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          hsync-active:
> +            default: 1
> +
> +          vsync-active:
> +            default: 1
> +
> +          pclk-sample:
> +            default: 0

I think you should have bus-width here as well -- either make it mandatory
or add a default.

> +
> +        required:
> +          - link-frequencies
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - iovdd-supply
> +  - dvdd-supply
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@24 {
> +            compatible =  "himax,hm1246";
> +            reg = <0x24>;
> +
> +            clocks = <&hm1246_clk>;
> +
> +            reset-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
> +
> +            avdd-supply = <&hm1246_avdd>;
> +            iovdd-supply = <&hm1246_iovdd>;
> +            dvdd-supply = <&hm1246_dvdd>;
> +
> +            orientation = <2>;
> +            rotation = <0>;
> +
> +            port {
> +                endpoint {
> +                    remote-endpoint = <&isp_par_in>;
> +                    bus-width = <10>;
> +                    hsync-active = <1>; /* active high */
> +                    vsync-active = <1>; /* active high */
> +                    pclk-sample = <1>; /* sample on rising edge */
> +                    link-frequencies = /bits/ 64 <42200000>;
> +                };
> +            };
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 752ccaea38b0ee74282e06f233463eba122fa92c..c09de45c5260b70af8a524721d4a999a1efa415d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11290,6 +11290,13 @@ L:	linux-kernel@vger.kernel.org
>  S:	Maintained
>  F:	drivers/misc/hisi_hikey_usb.c
>  
> +HIMAX HM1246 SENSOR DRIVER
> +M:	Matthias Fend <matthias.fend@emfend.at>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +T:	git git://linuxtv.org/media_tree.git

I think this can be dropped as I understand you don't have commit access.

> +F:	Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> +
>  HIMAX HX83112B TOUCHSCREEN SUPPORT
>  M:	Job Noorman <job@noorman.info>
>  L:	linux-input@vger.kernel.org
> 

-- 
Kind regards,

Sakari Ailus