From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sirat <email@sirat.me>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
andy@kernel.org, geert@linux-m68k.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] auxdisplay: tm1637: Add driver for TM1637
Date: Tue, 13 Jan 2026 11:47:39 +0200 [thread overview]
Message-ID: <aWYUuyKuHTYzgBPd@smile.fi.intel.com> (raw)
In-Reply-To: <CANn+LW+PkAcZ2ZVSUpAQwYhDucruiiN90cAakDMXnayRPW0jUQ@mail.gmail.com>
On Tue, Jan 13, 2026 at 03:42:09PM +0600, Sirat wrote:
> Hi Andy,
>
> Thanks for the review. appreciate the mentorship on the coding style.
>
> On the I2C point: I did check, but the TM1637 is incompatible with
> standard I2C adapters. It expects LSB-first data and there's no slave
> address so bit-banging is the only option here.
As I replied earlier I do not see the problems there.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-13 9:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 4:02 [PATCH 0/4] auxdisplay: Add support for TM1637 7-segment display driver Siratul Islam
2026-01-13 4:02 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add titanmec Siratul Islam
2026-01-13 16:22 ` Krzysztof Kozlowski
2026-01-13 4:02 ` [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637 Siratul Islam
2026-01-13 16:24 ` Krzysztof Kozlowski
2026-01-13 4:02 ` [PATCH 3/4] auxdisplay: tm1637: Add driver for TM1637 Siratul Islam
2026-01-13 7:52 ` Andy Shevchenko
2026-01-13 9:42 ` Sirat
2026-01-13 9:47 ` Andy Shevchenko [this message]
2026-01-13 14:57 ` kernel test robot
2026-01-13 4:02 ` [PATCH 4/4] MAINTAINERS: Add entry " Siratul Islam
2026-01-13 6:54 ` [PATCH 0/4] auxdisplay: Add support for TM1637 7-segment display driver Andy Shevchenko
2026-01-13 6:56 ` Andy Shevchenko
[not found] ` <CANn+LWLECPY-F_fsDg1VxbjJdN-pLnkRpQn4OEFSa6yiARoU9A@mail.gmail.com>
2026-01-13 9:41 ` Andy Shevchenko
2026-01-13 9:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWYUuyKuHTYzgBPd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=email@sirat.me \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox