From: Stafford Horne <shorne@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux OpenRISC <linux-openrisc@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: (subset) [PATCH v6 0/6] OpenRISC de0 nano single and multicore boards
Date: Fri, 16 Jan 2026 16:36:57 +0000 [thread overview]
Message-ID: <aWppKQRWATsSuDeX@antec> (raw)
In-Reply-To: <56e0c7bf-8f51-47b4-9ec7-edcf1b815c06@kernel.org>
On Fri, Jan 16, 2026 at 01:02:15PM +0100, Krzysztof Kozlowski wrote:
> On 16/01/2026 12:57, Stafford Horne wrote:
> > On Thu, Jan 15, 2026 at 04:40:53PM +0100, Bartosz Golaszewski wrote:
> >>
> >> On Thu, 15 Jan 2026 15:09:56 +0000, Stafford Horne wrote:
> >>> Since v5:
> >>> - Adjust dt-binding patch based on suggestions from Geert and Krzysztof.
> >>> - Add reviewed-by's on the dt-binding patch.
> >>> Since v4:
> >>> - Rebased the series on linux-next to allow patches to be incremental.
> >>> - Rewrote the dt-bindings patch as an incremental patch, Due to this I
> >>> dropped reviewed-by's.
> >>> - Added acked-by to the IPI fix patch.
> >>> Since v3:
> >>> - Switch order of gpio-mmio driver and bindings patches to patch binding
> >>> first before driver. Suggested by Krzysztof.
> >>> - Removed example form binding suggested by Krzysztof.
> >>> - Added Reviewed-by's from Geert and Linus W.
> >>> Since v2:
> >>> - Fixup (replace) gpio-mmio patch to update driver compatible list and just add
> >>> opencores,gpio to mmio-gpio bindings. Discussed with Geert and Linus W
> >>> because the 8-bit opencores,gpio is not the same as the 32-bit broadcom
> >>> chip. [1].
> >>> - Update new device trees to use proper ordering, remove debug options, remove
> >>> unneeded "status" properties. Suggested by Geert.
> >>> Since v1:
> >>> - Use proper schema in gpio-mmio suggsted by Conor Dooley
> >>> - Remove 0 clock-frequency definitions in dtsi file
> >>>
> >>> [...]
> >>
> >> Applied, thanks!
> >>
> >> [1/6] dt-bindings: gpio-mmio: Correct opencores GPIO
> >> commit: b2b8d247ad8ee1abe860598cae70e2dbe8a09128
> >> [2/6] gpio: mmio: Add compatible for opencores GPIO
> >> commit: 3a6a36a3fc4e18e202eaf6c258553b5a17b91677
> >
> > Thanks, now that these commits are on gpio-next I would like to apply the rest
> > of the patches to my openrisc/for-next branch. Since the other patches depend
> > on the GPIO patches for system functionality, do you think it would be safe for
> > me to merge the gpio-next branch into my branch?
>
> They do not depend, unless I missed something. DTS cannot depend on
> drivers because it is an independent (huh, so circular logic) hardware
> description. It's also more explained in maintainer-soc-profile and DT
> submitting patches document.
>
> There is no single dependency here and you should never pull gpio-next
> or any other subsystem driver into your DTS branches.
>
> >
> > It seems a bit messy, Maybe I should just wait for the next cycle. But if you
>
> There is no mess, you do not have to wait for anything. Please follow
> standard rules like we follow for all other SoC-based architectures
> (arm, arm64, riscv).
>
> What happens when you apply *independently* DTS? What is broken, which
> was not broken so far? What features stop working? What existing DTS is
> affected? What existing code is doing worse than before?
Hi Krzysztof,
You are right, there is no build time dependency here only a dependency at
runtime. Also the dtbs_check will warn about missing "opencores,gpio" bindings
for the new soc devicestrees on my branch. Now, I understand that is no issue.
I was overthinking this, I will just apply the remaining bits to the OpenRISC
queue as per the maintainer-soc-profile. Thanks for pointing that out.
Thanks,
-Stafford
> > have any suggestions of experience with this any comments would be appreciated.
> >
> > -Stafford
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-01-16 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 15:09 [PATCH v6 0/6] OpenRISC de0 nano single and multicore boards Stafford Horne
2026-01-15 15:09 ` [PATCH v6 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO Stafford Horne
2026-01-18 23:19 ` Linus Walleij
2026-01-15 15:09 ` [PATCH v6 2/6] gpio: mmio: Add compatible for " Stafford Horne
2026-01-15 15:09 ` [PATCH v6 3/6] openrisc: dts: Add de0 nano config and devicetree Stafford Horne
2026-01-15 15:10 ` [PATCH v6 4/6] openrisc: Fix IPIs on simple multicore systems Stafford Horne
2026-01-15 15:10 ` [PATCH v6 5/6] openrisc: dts: Split simple smp dts to dts and dtsi Stafford Horne
2026-01-15 15:10 ` [PATCH v6 6/6] openrisc: dts: Add de0 nano multicore config and devicetree Stafford Horne
2026-01-15 15:40 ` (subset) [PATCH v6 0/6] OpenRISC de0 nano single and multicore boards Bartosz Golaszewski
2026-01-16 11:57 ` Stafford Horne
2026-01-16 12:02 ` Krzysztof Kozlowski
2026-01-16 16:36 ` Stafford Horne [this message]
2026-01-16 16:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWppKQRWATsSuDeX@antec \
--to=shorne@gmail.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox