From: Frank Li <Frank.li@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: imx8-apalis: Fix LEDs name collision
Date: Wed, 21 Jan 2026 15:05:14 -0500 [thread overview]
Message-ID: <aXExepw/T8OLcNwF@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260119103411.50397-1-francesco@dolcini.it>
On Mon, Jan 19, 2026 at 11:34:09AM +0100, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Ixora boards have multiple instances of status leds, to avoid a name
> collision add the function-enumerator property.
>
> This fixes the following Linux kernel warnings:
>
> leds-gpio leds: Led green:status renamed to green:status_1 due to name collision
> leds-gpio leds: Led red:status renamed to red:status_1 due to name collision
>
> Fixes: c083131c9021 ("arm64: dts: freescale: add apalis imx8 aka quadmax carrier board support")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
> index 7022de46b8bf..abb131d247c3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
> @@ -21,6 +21,7 @@ led-1 {
> color = <LED_COLOR_ID_GREEN>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <1>;
> gpios = <&lsio_gpio5 27 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -29,6 +30,7 @@ led-2 {
> color = <LED_COLOR_ID_RED>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <1>;
> gpios = <&lsio_gpio5 29 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -37,6 +39,7 @@ led-3 {
> color = <LED_COLOR_ID_GREEN>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <2>;
> gpios = <&lsio_gpio5 20 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -45,6 +48,7 @@ led-4 {
> color = <LED_COLOR_ID_RED>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <2>;
> gpios = <&lsio_gpio5 21 GPIO_ACTIVE_HIGH>;
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
> index 12732ed7f811..a0b452b92b3e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
> @@ -21,6 +21,7 @@ led-1 {
> color = <LED_COLOR_ID_GREEN>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <1>;
> gpios = <&lsio_gpio5 27 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -29,6 +30,7 @@ led-2 {
> color = <LED_COLOR_ID_RED>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <1>;
> gpios = <&lsio_gpio5 29 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -37,6 +39,7 @@ led-3 {
> color = <LED_COLOR_ID_GREEN>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <2>;
> gpios = <&lsio_gpio5 20 GPIO_ACTIVE_HIGH>;
> };
>
> @@ -45,6 +48,7 @@ led-4 {
> color = <LED_COLOR_ID_RED>;
> default-state = "off";
> function = LED_FUNCTION_STATUS;
> + function-enumerator = <2>;
> gpios = <&lsio_gpio5 21 GPIO_ACTIVE_HIGH>;
> };
> };
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-01-21 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 10:34 [PATCH v1] arm64: dts: imx8-apalis: Fix LEDs name collision Francesco Dolcini
2026-01-19 12:46 ` Daniel Baluta
2026-01-21 20:05 ` Frank Li [this message]
2026-02-24 17:00 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXExepw/T8OLcNwF@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox