From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7222376BFA for ; Thu, 22 Jan 2026 01:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769046703; cv=none; b=GjcnFMnsyg8xvD6iXyEquOloc040Z7QIerEl+pkVfbRTG0UXPPRfqFIGT7XXVEQqtjvp0AjhWqG+Z8lk7M6JSkimfIzfl7LaCpm4gVsNZoq/r5CyDOQkzvhLCWzSC+ZDi94v7RF8Rtqq4J7comn+pYNZH92NImmuJGvnDE3QNEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769046703; c=relaxed/simple; bh=ms5pWR92u/Sb/qm5qVz6BRpgwmPmV2/bOD5kn3A20VE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c71Vr9EBID8L7LCyvg8plcv84qNO/aoT1jUfkSi5Q8JYdKFVMeXAZCOGpaZCJWc+cUiuow0/q+8QfzSn4caUdJwLhDhEqR0bMMR75yElkMQZ1WIHC8rhEJ7FDZIoHyiAmQhd4p811G2C0VdHbjS5D0A7vjZZtIl6g6UNQoV6lIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VqTj094L; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VqTj094L" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-6610c5b014cso223805eaf.0 for ; Wed, 21 Jan 2026 17:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769046699; x=1769651499; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pGEOJU/uiNboJwAtLEE6S07BEXT+vA5BV+sOD/aPObo=; b=VqTj094LPxwvMXTBVhQStoJQAZ1p8CH0hpqj8bGVgdPSZ1C2KxYcwAMj5CxmhgAkev rbb8aTEjZbao72N8AShFWtHcykR8ELpxTYeg7INgdfaBj4VpF9Mbf5GYIBEYyegqRoLP sGMOV7OJktDJzpW3BwAheCENLsZVDCbmXs2CEcVfFqy0WktI9zScVck1qmshfO8I2kWm syUMY9n6IPQySTILAfxzz8H+8jBnV/MO7NQ7QOOkDPE79mTCKW4w/P9bTHg0s3Fj410j bZuBBItelXP3Di66FIVd+cRTLb3vKSGaxqTDzMEH3KXEPM0vZL1EDsQSwrwYgsndXTlg EWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769046699; x=1769651499; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pGEOJU/uiNboJwAtLEE6S07BEXT+vA5BV+sOD/aPObo=; b=is35kDSxWtGJeE/8qYpcL1z+CsxkLl1qRw6AiqHKYAfCsJK+yfPNLcR6ZDpuwVnbHB LRhffOS/XlQu5PdwJpB3A+fkXHmEajZObROnqE01xehOfD6yJ733EJe8dkCpONtZ9v/Z s/naVi0PM2X7zYHNvp8J6YL/uysFDmzrGlzCCrdir1Am/MiDTdUqWRiJjw1H31oRKNAO +d4OZrCApi6QQ1pf0JA+2VYsKrBePm/27uoYPgiNUVOKpLSxtHix4HOZ5iK4uvGW11x+ SUyazyMSlP5LD/AZJF8zMSTlmKRWaF9h/hmCjESpOgM50goQOyi1mzLNBss1vLMEwbuJ iY2Q== X-Forwarded-Encrypted: i=1; AJvYcCWHM2Esf4HZKJWRr2oU0vafHZVA5+dBS8AvQ5+5GGflKrxr0w0p4DJpEkEvJOE9bwgZ9AaEl9yL5FUr@vger.kernel.org X-Gm-Message-State: AOJu0YyKh+cyrmiEJC4I08z0a2lxOBfeZTxv7MTpdrmefZKv7IPocAH+ dHmizxwpfaJMXf6KUtkIHx8g7WJAtH+Np1va/aC4RKphSRhquIXLYjPLByG7RzfZ X-Gm-Gg: AZuq6aKSqBNbuKzDol+80TmxXWPQ0dZm8btqq9+L6as6skYE+jXC/GMX7J4Y/zk/rka 3qmnRd+IfeGJE8x7lM+5/ttdhyeQguiHuPRYelOdHKoudMIJDvR1XIsG1XwcIYP8qOWVpJIObiI vGL6vyDp/O0mzykzfaJ+iyUX5fTa7Zdi8FH9HsquwD0P8mIP9rxB1D2RaDrRtmb2C46+b/frTaZ r+bHlDqQD4N+BQMTyPjNC0gzSW67zEIaScUyGlEloOaSKnU8VAGhQTN30gs+azqo8SvpYBlLZI/ 3+04XkFMsFSubeZlSugvKHBvDwUBc9pP36m9XCfnoqsc8sA4PymzlNdrtF0OjvxpUUMaF//F/Eu nQfOU3cLnOz+cceoOqFC9hBOG7qJhUeUSYei53rKCs6qnF8hOccJWw+Ov5XjEdVSR86wbn7oVVD dlGDCy4CaYKw== X-Received: by 2002:a05:7301:408c:b0:2b7:143a:9a8f with SMTP id 5a478bee46e88-2b7143a9e6bmr2183820eec.7.1769039928585; Wed, 21 Jan 2026 15:58:48 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b361f5d4sm23459514eec.17.2026.01.21.15.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 15:58:48 -0800 (PST) Date: Thu, 22 Jan 2026 07:58:37 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Chen-Yu Tsai , Choong Yong Liang , Shangjuan Wei , Jernej Skrabec , Boon Khai Ng , Maxime Chevallier , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260121071315.940130-1-inochiama@gmail.com> <20260121071315.940130-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 21, 2026 at 12:05:30PM +0000, Russell King (Oracle) wrote: > On Wed, Jan 21, 2026 at 03:13:11PM +0800, Inochi Amaoto wrote: > > + mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN | > > + RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN; > > + val = FIELD_PREP(RGMII_TX_DLINE_STEP, tx_config) | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN | > > + FIELD_PREP(RGMII_RX_DLINE_STEP, rx_config) | > > + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN; > > So your reply where you basically stated that all the RGMII.*DLINE.* > constants here should be the same was nonsense. How can we trust your > replies? > Sorry, I have found there is a mistake for replying you. Now I give a detailed description about this registers. You can check it at https://lore.kernel.org/netdev/aXFnmXIwSdKCS9Uc@inochi.infowork/ Regards, Inochi > > +static int spacemit_dwmac_fix_delay(struct plat_stmmacenet_data *plat_dat, > > + struct regmap *apmu, > > + unsigned int dline_offset, > > + unsigned int tx_delay, unsigned int rx_delay) > > +{ > > + bool mac_rxid = rx_delay != 0; > > + bool mac_txid = tx_delay != 0; > > + unsigned int rx_config = 0; > > + unsigned int tx_config = 0; > > + int rx_code; > > + int tx_code; > > + > > + plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface, > > + mac_txid, > > + mac_rxid); > > Maybe Andrew can confirm, but this function was to fix up existing > broken DT, and shouldn't be used by brand new drivers. > > > + plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx"); > > + if (IS_ERR(plat_dat->clk_tx_i)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i), > > + "failed to get tx clock\n"); > > As stated on the previous series, please don't abuse clk_tx_i for > soemthing that isn't the dwmac's clk_tx_i signal. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!