From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C9C02E041D; Tue, 27 Jan 2026 09:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506570; cv=none; b=gTcNRdz/FmduXlgQulLAuIcWWIbTKqsiLNnwF4hIKz5qwQMhMNzFGSWNIvYyiUPBFmqsWyWasWtMScUS6gm/bk+Vyz5Wm20ODJPcMEV1poqcNkujktvC+nhlSSE93XFYHCtCe/c6cokPyRR1oqDj8MG/1C4AJgXy5JgJnRicn2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506570; c=relaxed/simple; bh=B7DFX5lqbjM4djzDpxG9RwFOYzDx+Gb3DTdEDYClDgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fGnbQ6KSghIb5Qowg8hIViK7wGSi8S41B71WUHAnShuvKP5YsslHgSgBjZ7gGvkjj1bgHelK+lF6jz6MN3vFkorSIU7dUp/USEX5QaDx6IihI8JHg92it0nx+LnoyJxZTPfM2F/pdRNHmWyPZHYemTGCvgVL3k1GPyE/0CLoaK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fk91wynQ; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fk91wynQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769506568; x=1801042568; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=B7DFX5lqbjM4djzDpxG9RwFOYzDx+Gb3DTdEDYClDgY=; b=fk91wynQeY5HY6m85CjKxll84cRN1lAgZhUn4WigcsGFI4fsH5bcGNP9 fqbAGihz18cj7S/9IQ4DAEJhkbLGAjEE4Le2l6VtxIWf87c62VDYsGea/ 9pwLLExQ4Loeo5yYYABMAiGVne3sBVrrozGXxqfSbrMjZt+7c8fnCUtXq m1QRtYlHlra76k2Lx4G/kxdHLcQRvauV9oamMca/2zZ+9RHMUkGeHgUZD Li6fv30TsQUKACtDuKy0wro5x1wTpwWsYDNWwm5KOObPguL0pR7ZaaHpw Rn70hlAxhlYU8YAnWfT3rYVsVLfVd+xlrZjgNXbodk/jFP+lideCd80KV Q==; X-CSE-ConnectionGUID: z61GA8IKQ5Sv+qKs7GUZwQ== X-CSE-MsgGUID: VHcFIsGbQN2vWzhaly6c0A== X-IronPort-AV: E=McAfee;i="6800,10657,11683"; a="70591300" X-IronPort-AV: E=Sophos;i="6.21,256,1763452800"; d="scan'208";a="70591300" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 01:36:08 -0800 X-CSE-ConnectionGUID: guJ6KiTnRaiQ+vatan35aw== X-CSE-MsgGUID: ZsJuwkAhRx+Hvslj9xkPuw== X-ExtLoop1: 1 Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.248]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 01:36:05 -0800 Date: Tue, 27 Jan 2026 11:36:03 +0200 From: Andy Shevchenko To: abdurrahman@nexthop.ai Cc: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , info@mocean-labs.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 2/6] i2c: xiic: make the clock optional Message-ID: References: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> <20260126-i2c-xiic-v5-2-88a16a28721c@nexthop.ai> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126-i2c-xiic-v5-2-88a16a28721c@nexthop.ai> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 26, 2026 at 05:08:17PM +0000, Abdurrahman Hussain via B4 Relay wrote: > The xiic driver is designed to operate without explicit clock configuration > when clocks are not specified in the firmware. This functionality is > already implemented in xiic_setclk(), which performs an early return when > either i2c_clk or input_clk are zero: > > This condition is satisfied when clocks are missing, as clk_get_rate(NULL) > returns zero, allowing the driver to rely on hardware-configured timing. Bingo! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko