From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6E02E0923; Tue, 27 Jan 2026 09:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507080; cv=none; b=p1Jdytwj73B9tRTSAZBFt+tUni7hgMj38U9hl1fFgyT1vzyQ9sCHhp0g4JhXQcPpraFQpRBoW3pyaMA0Yy62NjHG7zSbTitvwttoxHm37+79JUB6FzPal3A0n9Mu9HPgEWdOGl52ZVArdhkGq6fVHqP/smPlyrkWjlKuCInXxC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507080; c=relaxed/simple; bh=jPvLZnphMdcVN/l/3xsINCKdek0m9norh4P5F7hOiDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FqTcfT3ZrFFfTgso7nj0VmNR6SZB83EykaJKkQPlgdr01x41Zd8Yza6VaReD1zDnvPbE/ezVzx7WuiljE7Dor3DR/0fTXEytE8CwYlqnFlnfw0XFB5sxGiQFFhpBH87gtsme6ZPz28NKVi/1MSM4ko8DiiBGMaasyNs8IWlxfG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Z2nNllUn; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Z2nNllUn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769507079; x=1801043079; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jPvLZnphMdcVN/l/3xsINCKdek0m9norh4P5F7hOiDI=; b=Z2nNllUnUU0kPJ87c8W6YDULEOR1VRWKCQ17XsYMZeEH2qVbxKvwFD6j FtwtAWSx+EsirLE5Q56XDo1GQiIdQT79phZDdP7A6YDJq1dKN9WaB7Qau VTvOrQYI/7ANlf2fIC7urt5RPRDU0RtItMTpEeQofwIOI5w1+sApjNXo0 NCrOFjosZhhGVVy/iK3uSDRWOD+qekUzR5HaAKWNi6UDB2E7fwa03K+10 UUnwgzAJU8mjRpSmDvGdUpXsMow3nbd2Vy5r8x6dZn0QFV0BnllXlwGkd L81uVOCR9wkzVzFlJ0PtRsoXVkwTmHuC1ENXMJ5Nr0C0uvqBhYF8rxQmR A==; X-CSE-ConnectionGUID: ayEuhZyUTU+NTckLEzJPTw== X-CSE-MsgGUID: GNE3O3m1QmWoJN2Q3m98sg== X-IronPort-AV: E=McAfee;i="6800,10657,11683"; a="70416853" X-IronPort-AV: E=Sophos;i="6.21,256,1763452800"; d="scan'208";a="70416853" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 01:44:38 -0800 X-CSE-ConnectionGUID: 8UUpICqfQcST4/sJ1x6n/g== X-CSE-MsgGUID: k0n/UH1wQ0meFryrjQEfTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,256,1763452800"; d="scan'208";a="212909062" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.248]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 01:44:35 -0800 Date: Tue, 27 Jan 2026 11:44:32 +0200 From: Andy Shevchenko To: abdurrahman@nexthop.ai Cc: Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , info@mocean-labs.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 6/6] i2c: xiic: cosmetic cleanup Message-ID: References: <20260126-i2c-xiic-v5-0-88a16a28721c@nexthop.ai> <20260126-i2c-xiic-v5-6-88a16a28721c@nexthop.ai> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126-i2c-xiic-v5-6-88a16a28721c@nexthop.ai> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 26, 2026 at 05:08:21PM +0000, Abdurrahman Hussain via B4 Relay wrote: > Re-use dev pointer instead of referencing &pdev->dev everywhere. Reviewed-by: Andy Shevchenko A couple of nit-picks to be addressed though. ... > - i2c->dev = &pdev->dev; > - pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); > - pm_runtime_use_autosuspend(i2c->dev); > + i2c->dev = dev; + blank line here. > + pm_runtime_set_autosuspend_delay(dev, XIIC_PM_TIMEOUT); > + pm_runtime_use_autosuspend(dev); > ret = devm_pm_runtime_set_active_enabled(dev); > if (ret < 0) > return ret; ... > ret = xiic_reinit(i2c); > if (ret < 0) { > - dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); > + dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); > return ret; > } It should be integrated in the second patch or so, I have already commented on that. ... > - ret = pm_runtime_get_sync(i2c->dev); > + ret = pm_runtime_get_sync(dev); > Drop this blank line as well. > if (ret < 0) > - dev_warn(&pdev->dev, "Failed to activate device for removal (%pe)\n", > + dev_warn(dev, "Failed to activate device for removal (%pe)\n", > ERR_PTR(ret)); > else > xiic_deinit(i2c); -- With Best Regards, Andy Shevchenko