[PATCH 0/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[PATCH 0/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[Anton D. Stavinskii]

An incremental patch on top of 
"[PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC" 
adding the explanatory comments as requested.
https://lore.kernel.org/all/20260120-cv1800b-i2s-driver-v4-0-6ef787dc6426@gmail.com/

changes: 
 - added description for cv1800b_dac_mute function
 - fixed "extra change" from previos commit

Thanks

Signed-off-by: Anton D. Stavinskii <stavinsky@gmail.com>
---
Anton D. Stavinskii (2):
      ASoC: sophgo: cv1800b: document DAC overwrite handling
      ASoC: sophgo: cv1800b: tidy Kconfig spacing

 sound/soc/sophgo/Kconfig             | 1 +
 sound/soc/sophgo/cv1800b-sound-dac.c | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)
---
base-commit: bdc79da6c6206a12c9a13ed5e4eb1360d62b321e
change-id: 20260127-incremental-for-i2s-dvier-9ec60a002bdd

Best regards,
-- 
Anton D. Stavinskii <stavinsky@gmail.com>

[PATCH 1/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[Anton D. Stavinskii]

Add comments to cv1800b_dac_mute() and its caller to explain how the
overwrite mechanism works and why we force it off before playback.
---
 sound/soc/sophgo/cv1800b-sound-dac.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/soc/sophgo/cv1800b-sound-dac.c b/sound/soc/sophgo/cv1800b-sound-dac.c
index ccf386174639..135322bcf6ad 100644
--- a/sound/soc/sophgo/cv1800b-sound-dac.c
+++ b/sound/soc/sophgo/cv1800b-sound-dac.c
@@ -57,6 +57,10 @@ static void cv1800b_dac_enable(struct cv1800b_priv *priv, bool enable)
 	writel(val, priv->regs + CV1800B_TXDAC_CTRL0);
 }
 
+/*
+ * Control the DAC overwrite bits. When enabled, the DAC outputs the fixed
+ * overwrite value instead of samples from the I2S input.
+ */
 static void cv1800b_dac_mute(struct cv1800b_priv *priv, bool enable)
 {
 	u32 val;
@@ -105,7 +109,7 @@ static int cv1800b_dac_hw_params(struct snd_pcm_substream *substream,
 		dev_err(priv->dev, "rate %u is not supported\n", rate);
 		return -EINVAL;
 	}
-
+	/* Clear DAC overwrite so playback uses I2S data. */
 	cv1800b_dac_mute(priv, false);
 	/* minimal decimation for 48kHz is 64*/
 	ret = cv1800b_dac_decimation(priv, DECIMATION_64);

-- 
2.43.0

Re: [PATCH 1/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Tue, Jan 27, 2026 at 10:48:07PM +0400, Anton D. Stavinskii wrote:
> Add comments to cv1800b_dac_mute() and its caller to explain how the
> overwrite mechanism works and why we force it off before playback.
> ---
>  sound/soc/sophgo/cv1800b-sound-dac.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[Anton D. Stavinskii]

On Tue, Jan 27, 2026 at 06:49:14PM +0400, Mark Brown wrote:
> On Tue, Jan 27, 2026 at 10:48:07PM +0400, Anton D. Stavinskii wrote:
> > Add comments to cv1800b_dac_mute() and its caller to explain how the
> > overwrite mechanism works and why we force it off before playback.
> > ---
> >  sound/soc/sophgo/cv1800b-sound-dac.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> You've not provided a Signed-off-by for this so I can't do anything with
> it, please see Documentation/process/submitting-patches.rst for details
> on what this is and why it's important.

Sorry. I was relying on b4 prep --check. Looks like it was wrong. Should
I resend as v1? 

Re: [PATCH 1/2] ASoC: sophgo: cv1800b: document DAC overwrite handling

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Tue, Jan 27, 2026 at 10:57:43PM +0400, Anton D. Stavinskii wrote:
> On Tue, Jan 27, 2026 at 06:49:14PM +0400, Mark Brown wrote:

> > You've not provided a Signed-off-by for this so I can't do anything with
> > it, please see Documentation/process/submitting-patches.rst for details
> > on what this is and why it's important.

> Sorry. I was relying on b4 prep --check. Looks like it was wrong. Should
> I resend as v1? 

Probably easiest to just resend - sending as v2 is fine and probably
less likely to confuse tools.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH 2/2] ASoC: sophgo: cv1800b: tidy Kconfig spacing

[Anton D. Stavinskii]

Restore the empty line that was accidentally removed earlier

Signed-off-by: Anton D. Stavinskii <stavinsky@gmail.com>
---
 sound/soc/sophgo/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sophgo/Kconfig b/sound/soc/sophgo/Kconfig
index e4786f087589..9b454261bcfd 100644
--- a/sound/soc/sophgo/Kconfig
+++ b/sound/soc/sophgo/Kconfig
@@ -28,6 +28,7 @@ config SND_SOC_CV1800B_ADC_CODEC
 	help
 	  This driver provides an ASoC codec DAI for capture and basic
 	  control of the RXADC registers.
+
 	  Say Y or M to build support for the Sophgo CV1800B
 	  internal analog ADC codec block (RXADC).
 	  The module will be called cv1800b-sound-adc

-- 
2.43.0