From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1773E2BEFFF; Tue, 27 Jan 2026 21:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769548337; cv=none; b=gp8dvwvt5ydq6irNWiHro0WPSSCcDzwuD/Uplx5bwLzeF8sjsfjzUXJOYp4gbq3rzPGccUfjkVenZJcUcnTj7ERF2unaffNMYz7LuG3a0YHsydVdKeudbCZn8uZ0jCiZwGcz7Pm0z9JmJRl/UjSRcWk3w5K/MlVMwa9v0gB1ee0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769548337; c=relaxed/simple; bh=SnOm8uikqf5Mp5QGbuMMy35ul8EjebdXR8R8wDneajY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mu13bk2BSXa4Vu4/NTj97KyX3fYntVFZjCy+NG5FY1NJ964bI0o3sc/Bvkt84Y/yxWezGErB7jxBzBv391821cgAyeAUDccY2wUZG8+P+UexmhgRyT1X7gAIVgwdVmkykhjZNqbNsMyY8j+3oU9HeugTsbLUwrVn0plYfLkhuqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W+1omooF; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W+1omooF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769548337; x=1801084337; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SnOm8uikqf5Mp5QGbuMMy35ul8EjebdXR8R8wDneajY=; b=W+1omooFvmIoUoZwco0ZyPXmddWiUJ6smSgSr7SS0TmFggzHFf6eP5Ww //u8WfqAkVP2D+OD2nEDOxq05fYRH2oDb49togCb6c68Fllmti9g6GcxJ foRaQp0023q7sAbLX8MB9XPj/JQRzerU5++jpassjCWtCeH917o8gC9cm cGSHBHFVzatFVqlJ5aaeBMJ9eqPtFUiQgrgq1BoLi1CVl6k/ifcFZ+dT6 MLFMAal140vyTc4Xn5gGHTI695qYtF3tTr4/MsQggbhMfeQuqXDGMRRPR ryNJkDEGTq71FREA7f1sie9O1SQ7OCFXoYzPpI9RrJb74GfYGMjZjVDhO g==; X-CSE-ConnectionGUID: z5ItgC9FQfe7aXTvqlaJ/g== X-CSE-MsgGUID: TXY+zDVFTYC//2POw90EVA== X-IronPort-AV: E=McAfee;i="6800,10657,11684"; a="70649268" X-IronPort-AV: E=Sophos;i="6.21,257,1763452800"; d="scan'208";a="70649268" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 13:12:16 -0800 X-CSE-ConnectionGUID: Wx8/I1NbRp6BCzN4GLPdog== X-CSE-MsgGUID: 47MvwlwqTkicoF/4Ye5L0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,257,1763452800"; d="scan'208";a="207320252" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.248]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 13:12:12 -0800 Date: Tue, 27 Jan 2026 23:12:09 +0200 From: Andy Shevchenko To: rodrigo.alencar@analog.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 3/6] iio: amplifiers: ad8366: refactor device resource management Message-ID: References: <20260126-iio-ad8366-update-v2-0-c9a4d31aeb01@analog.com> <20260126-iio-ad8366-update-v2-3-c9a4d31aeb01@analog.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126-iio-ad8366-update-v2-3-c9a4d31aeb01@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 26, 2026 at 01:51:04PM +0000, Rodrigo Alencar via B4 Relay wrote: > Adhere modern device resource management with the following: > - Voltage regulator managed and enabled internally; > - Proper mutex lifecycle with devm_mutex_init(), replacing mutex_init(); > - IIO device registration handled with devm_iio_device_register(); > - removal of goto's from the probe function; > - ad8366_remove() removed as it is not needed anymore; > > Also, dev_err_probe() is used to report probe errors with created local > device pointer. And also it uses the temporary dev variable in the cases that are not covered by the above. So, three changes in one patch... Dunno if Jonathan is okay with this. I would rather split it. Code wise LGTM. -- With Best Regards, Andy Shevchenko