From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andy Shevchenko <andy@kernel.org>,
linux-i2c@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: ls2x-v2: Add driver for Loongson-2K0300 I2C controller
Date: Wed, 28 Jan 2026 11:08:18 +0200 [thread overview]
Message-ID: <aXnSAgPbTZ_IY8mQ@smile.fi.intel.com> (raw)
In-Reply-To: <CAAhV-H5mYypVAXJVpQ7ZJCMd4OvtxkJ6BcKbph1e-JTd5u3xiA@mail.gmail.com>
On Wed, Jan 28, 2026 at 12:15:08PM +0800, Huacai Chen wrote:
> On Tue, Jan 27, 2026 at 10:48 AM Binbin Zhou <zhoubinbin@loongson.cn> wrote:
...
> > F: Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> > +F: drivers/i2c/busses/i2c-ls2x-v2.c
> I still think it is better to move this line below. Though it may
> cause a checkpatch warning, but for checkpatch only errors must be
> fixed, whether warnings need to be eliminated depends on the fact.
>
> > F: drivers/i2c/busses/i2c-ls2x.c
This should be sorted, and
$ cat << EOF | LC_ALL=C sort
> Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> drivers/i2c/busses/i2c-ls2x-v2.c
> drivers/i2c/busses/i2c-ls2x.c
Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
drivers/i2c/busses/i2c-ls2x-v2.c
drivers/i2c/busses/i2c-ls2x.c
The patch is correct AFAICS.
P.S> Remove the unneeded context when you do not comment on it,
do not make others to waste time on reading that.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-28 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 2:47 [PATCH v2 0/2] i2c: Add Loongson-2K0300 I2C controller support Binbin Zhou
2026-01-27 2:47 ` [PATCH v2 1/2] dt-bindings: i2c: loongson,ls2x: Add ls2k0300-i2c compatible Binbin Zhou
2026-01-27 2:47 ` [PATCH v2 2/2] i2c: ls2x-v2: Add driver for Loongson-2K0300 I2C controller Binbin Zhou
2026-01-27 8:18 ` Andy Shevchenko
2026-01-29 8:07 ` Binbin Zhou
2026-01-29 14:38 ` Andy Shevchenko
2026-02-02 6:39 ` Binbin Zhou
2026-02-03 9:53 ` Andy Shevchenko
2026-01-28 4:15 ` Huacai Chen
2026-01-28 9:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXnSAgPbTZ_IY8mQ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox