From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Cc: rodrigo.alencar@analog.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 4/6] iio: amplifiers: ad8366: add device tree support
Date: Wed, 28 Jan 2026 14:39:14 +0200 [thread overview]
Message-ID: <aXoDckvvaqnaA3vc@smile.fi.intel.com> (raw)
In-Reply-To: <knzaphyzfuh4fihlftzh3jhjxbjrdjqezqsd7rc33pmtc4anxi@2uhqhizyfsed>
On Wed, Jan 28, 2026 at 10:23:58AM +0000, Rodrigo Alencar wrote:
> On 26/01/28 12:09PM, Andy Shevchenko wrote:
> > On Wed, Jan 28, 2026 at 09:55:16AM +0000, Rodrigo Alencar wrote:
...
> > So, something like
> >
> > put_unaligned_be16((ch_b << 6) | ch_a, &st->deta[0]);
> >
> > should be better, no? (Note, you would need linux/unaligned.h).
>
> ok, ch_b would have to be u16 and ch_a could be too (for consistency)
Why? u8 should suffice.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-28 12:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 13:51 [PATCH v2 0/6] iio: amplifiers: ad8366: driver update and dt support Rodrigo Alencar via B4 Relay
2026-01-26 13:51 ` [PATCH v2 1/6] MAINTAINERS: Add missing maintainer entry for AD8366 driver Rodrigo Alencar via B4 Relay
2026-01-26 13:51 ` [PATCH v2 2/6] dt-bindings: iio: amplifiers: Add AD8366 support Rodrigo Alencar via B4 Relay
2026-01-26 20:11 ` Conor Dooley
2026-01-27 11:37 ` Rodrigo Alencar
2026-01-27 19:38 ` Conor Dooley
2026-01-28 9:39 ` Rodrigo Alencar
2026-01-28 14:43 ` Conor Dooley
2026-01-31 20:55 ` David Lechner
2026-01-26 13:51 ` [PATCH v2 3/6] iio: amplifiers: ad8366: refactor device resource management Rodrigo Alencar via B4 Relay
2026-01-27 21:12 ` Andy Shevchenko
2026-01-28 9:31 ` Rodrigo Alencar
2026-01-29 18:40 ` Jonathan Cameron
2026-01-26 13:51 ` [PATCH v2 4/6] iio: amplifiers: ad8366: add device tree support Rodrigo Alencar via B4 Relay
2026-01-27 21:21 ` Andy Shevchenko
2026-01-28 9:55 ` Rodrigo Alencar
2026-01-28 10:09 ` Andy Shevchenko
2026-01-28 10:23 ` Rodrigo Alencar
2026-01-28 12:39 ` Andy Shevchenko [this message]
2026-01-31 21:18 ` David Lechner
2026-01-26 13:51 ` [PATCH v2 5/6] iio: amplifiers: ad8366: consume enable gpio Rodrigo Alencar via B4 Relay
2026-01-31 21:19 ` David Lechner
2026-01-26 13:51 ` [PATCH v2 6/6] iio: amplifiers: ad8366: Update device support Rodrigo Alencar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXoDckvvaqnaA3vc@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=455.rodrigo.alencar@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox