Re: [PATCH v4 2/2] iio: light: vcnl4000: add support for Capella CM36686 and CM36672P

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Feb 12, 2026 at 04:42:48PM +0200, Erikas Bitovtas wrote:
> Add support for Capella's CM36686 and CM36672P sensors. Capella
> CM36686 is an ambient light and proximity sensor that is fully
> compatible with VCNL4040 and can be used as is. For CM36672P, which is
> a proximity-only sensor, also remove the IIO_LIGHT channel.

Perfect!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

...

> +	{
> +		.compatible = "capella,cm36672p",
> +		.data = (void *)CM36672P,

Side note: Consider at some point to switch to chip_info, id est use
pointers directly instead of integer indices as pointers here and in
other ID tables. It's for a future development, and not required for
this series.

> +	},
> +	{
> +		.compatible = "capella,cm36686",
> +		.data = (void *)VCNL4040,
> +	},
>  	{
>  		.compatible = "vishay,vcnl4000",
>  		.data = (void *)VCNL4000,

-- 
With Best Regards,
Andy Shevchenko