From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yasin Lee <yasin.lee.x@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
yasin.lee.x@outlook.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq
Date: Thu, 12 Feb 2026 22:01:25 +0200 [thread overview]
Message-ID: <aY4xlfSJwFGt1IPA@smile.fi.intel.com> (raw)
In-Reply-To: <CA+NOmzLMzWqnS0B9B96qJUU2EoYppDKO6_Rdu52_dPqWTSS+ig@mail.gmail.com>
On Fri, Feb 13, 2026 at 12:44:57AM +0800, Yasin Lee wrote:
> On Thu, Feb 12, 2026 at 6:56 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Thu, Feb 12, 2026 at 02:26:53PM +0800, Yasin Lee wrote:
...
> > Not sure about this. Perhaps we should rather do
> >
> > if (!val || !val2)
> > return -EINVAL;
> >
> > ?
>
> Agreed. I will update this in v3 as below .
> ...
> if (!val && !val2)
> return -EINVAL;
> period_ms = div_u64(NANO, val * MEGA + val2);
Then don't touch parentheses, as the line will have nothing to do with
the scope of the patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-12 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 6:26 [PATCH v2 0/4] iio: proximity: hx9023s: firmware property, safety fixes Yasin Lee
2026-02-12 6:26 ` [PATCH v2 1/4] iio: proximity: hx9023s: fix out-of-bounds access when copying firmware Yasin Lee
2026-02-12 10:58 ` Andy Shevchenko
2026-02-12 11:25 ` Krzysztof Kozlowski
2026-02-12 13:48 ` Andy Shevchenko
2026-02-12 16:27 ` Krzysztof Kozlowski
2026-02-12 6:26 ` [PATCH v2 2/4] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq Yasin Lee
2026-02-12 10:55 ` Andy Shevchenko
2026-02-12 16:44 ` Yasin Lee
2026-02-12 20:01 ` Andy Shevchenko [this message]
2026-02-12 6:26 ` [PATCH v2 3/4] dt-bindings: iio: proximity: hx9023s: support firmware-name property Yasin Lee
2026-02-12 11:23 ` Krzysztof Kozlowski
2026-02-12 17:36 ` Yasin Lee
2026-02-12 6:26 ` [PATCH v2 4/4] " Yasin Lee
2026-02-12 10:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY4xlfSJwFGt1IPA@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=yasin.lee.x@gmail.com \
--cc=yasin.lee.x@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox