From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3753B8BDC; Tue, 3 Feb 2026 14:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130572; cv=none; b=p34pxIQ1QPbG0J33u8BiCdCkoJ4l1dr/zvI5DbTTn3riRICwzBUI794HaKCJ7CYPfSEKrKLm4t3lkJMXUMs8GLUY8jCM73rnJ27LsWjhCDO2LfjOa7AKZeaJxm4LQ7U4wEW4DZGKTLHf6Fp+M8qrNToGPDW8GU6aSs5hcdqOndc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130572; c=relaxed/simple; bh=j55JyfW5E2HlW1jVpfenFHxuN+CxSTvPC7IBLTzEJGQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LCD3GLaFM5t9X+JVWE/j74lYPUjWAC9IhIo68WhSsLTdEs+B2rbxu1z8DVzMufrScW6j6pk48D8iFmQ/rEFetjzjtEe2Wf2z48fXMqrBY1XXZ2RChXgcG1ImVuy5avifQye8weec6CZ33ecsTj/hAA9b4wT1H+OyR6pgffKhL00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ErSlCscp; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ErSlCscp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770130569; x=1801666569; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=j55JyfW5E2HlW1jVpfenFHxuN+CxSTvPC7IBLTzEJGQ=; b=ErSlCscphF51EpEHyN7AUfgNkN66rBfWorNcZxErk0Fe8u0zphQvM+qw boEyW15ibcD/dOJXThtotbs6fFbHZFWQrfHVemR58TdBov/SBQSKsFtI5 7oohW5lEe7bsjqtbh5GMH+VnZcDvwLtm1zOGfkATDKA8IG+ylkMHcgYLo dV4s5bp3v3egN8HvTBJIXQ8PkzPZv9UVflbZVKQB853eNlYBtCPkDsMiJ wi+7vVai7ZnjNFZzj/YDABxVWvfNGTGzaSLucvtUpN6YbqPlgM5S+Oyef omxlpedpYguAHVMy+hbEqorWqv6KlRbZ42h5tfwRUJiRZWRghGC+WUpuf g==; X-CSE-ConnectionGUID: DAiJsptnR3aQWIZKFSYsJw== X-CSE-MsgGUID: C5OfcK4ZSY2p7pLZbjDN3A== X-IronPort-AV: E=McAfee;i="6800,10657,11690"; a="75159373" X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="75159373" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 06:56:05 -0800 X-CSE-ConnectionGUID: T2lApN1/RtOJ+k85+n/Egg== X-CSE-MsgGUID: bl/CHXtsTY6/WkNSqz7oIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="209159621" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 06:56:02 -0800 Date: Tue, 3 Feb 2026 16:56:00 +0200 From: Andy Shevchenko To: Oleksij Rempel Cc: Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Andy Shevchenko , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , David Jander Subject: Re: [PATCH v4 06/13] iio: dac: ds4424: use device match data for chip info Message-ID: References: <20260203093434.2548978-1-o.rempel@pengutronix.de> <20260203093434.2548978-7-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Feb 03, 2026 at 01:00:02PM +0100, Oleksij Rempel wrote: > On Tue, Feb 03, 2026 at 01:51:23PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 03, 2026 at 11:17:42AM +0100, Oleksij Rempel wrote: > > > On Tue, Feb 03, 2026 at 12:03:23PM +0200, Andy Shevchenko wrote: > > > > On Tue, Feb 03, 2026 at 10:34:26AM +0100, Oleksij Rempel wrote: ... > > > > > - indio_dev->name = id->name; > > > > > > > > > + indio_dev->name = client->name; > > > > > > > > Isn't this an ABI breakage? > > > > > > I can't confirm it. > > > > > > before all patches: > > > root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name > > > ds4424 > > > > > > after: > > > root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name > > > ds4424 > > > > In ACPI case it might look differently, but I have no means to test this. > > > > id->name comes strictly from an i2c table, while client->name is constructed > > using specifics of the firmware enumeration. In DT due to some (historical?) > > reasons the client->name has no vendor substring and hence matches 1:1 to > > id->name. In ACPI, IIRC, the client->name is ACPI device instance name, > > something like ABCD0123:00. > > Ok, I see. Should I revert this line? Just do not introduce that change (change of the ->name field) in the original patch, in that case no revert churn would be needed. -- With Best Regards, Andy Shevchenko