From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Jander" <david@protonic.nl>
Subject: Re: [PATCH v5 06/13] iio: dac: ds4424: use device match data for chip info
Date: Wed, 4 Feb 2026 16:20:13 +0200 [thread overview]
Message-ID: <aYNVndcMVRj3JsKL@smile.fi.intel.com> (raw)
In-Reply-To: <20260204140045.390677-7-o.rempel@pengutronix.de>
On Wed, Feb 04, 2026 at 03:00:38PM +0100, Oleksij Rempel wrote:
> Refactor the driver to use device match data instead of checking ID enums
> in a switch statement.
>
> Define a `ds4424_chip_info` structure to hold variant-specific attributes
> (currently just the channel count) and attach it directly to the I2C and
> OF device ID tables.
>
> This simplifies the probe function and makes it easier to add support for
> new variants like DS4402/DS4404.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
with a hope that we get rid an I²C ID requirement at some point.
...
> +struct ds4424_chip_info {
> + u8 num_channels;
If you wish, you can provide name here that will go to ->name field.
Linker dedups string literals, so it will be just an additional runtime
pointer.
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-04 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 14:00 [PATCH v5 00/13] iio: dac: ds4424: add DS4402/DS4404 support and scale Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 01/13] iio: dac: ds4424: reject -128 RAW value Oleksij Rempel
2026-02-04 14:13 ` Andy Shevchenko
2026-02-05 20:14 ` Jonathan Cameron
2026-02-04 14:00 ` [PATCH v5 02/13] iio: dac: ds4424: refactor raw access to use bitwise operations Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 03/13] iio: dac: ds4424: ratelimit read errors and use device context Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 04/13] iio: dac: ds4424: sort headers alphabetically Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 05/13] iio: dac: ds4424: rename iio_info struct to avoid ambiguity Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 06/13] iio: dac: ds4424: use device match data for chip info Oleksij Rempel
2026-02-04 14:20 ` Andy Shevchenko [this message]
2026-02-05 20:18 ` Jonathan Cameron
2026-02-04 14:00 ` [PATCH v5 07/13] iio: dac: ds4424: use fsleep() instead of usleep_range() Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 08/13] dt-bindings: iio: dac: maxim,ds4424: add ds4402/ds4404 Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 09/13] iio: dac: ds4424: add DS4402/DS4404 device IDs Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 10/13] iio: dac: ds4424: support per-variant output range limits Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 11/13] iio: dac: ds4424: convert to regmap Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 12/13] dt-bindings: iio: dac: maxim,ds4424: add maxim,rfs-ohms property Oleksij Rempel
2026-02-04 14:00 ` [PATCH v5 13/13] iio: dac: ds4424: add Rfs-based scale and per-variant limits Oleksij Rempel
2026-02-05 20:21 ` [PATCH v5 00/13] iio: dac: ds4424: add DS4402/DS4404 support and scale Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYNVndcMVRj3JsKL@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox