Devicetree
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	s.hauer@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev,
	kernel@pengutronix.de, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] arm64: dts: imx943-evk: add usdhc3 for SDIO WiFi support
Date: Wed, 4 Feb 2026 10:39:49 -0500	[thread overview]
Message-ID: <aYNoRaDA0vCUyyHC@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260204022306.2372889-1-sherry.sun@nxp.com>

On Wed, Feb 04, 2026 at 10:23:06AM +0800, Sherry Sun wrote:
> Add usdhc3 to support M.2 SDIO WiFi on i.MX943 EVK board.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in V2:
> 1. Move the usdhc3_pwrseq node before memory@80000000 node.
> 2. Remove redundant blank lines.
> ---
>  arch/arm64/boot/dts/freescale/imx943-evk.dts | 61 ++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx943-evk.dts b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> index f54404c9bfc9..c8ceabe3d923 100644
> --- a/arch/arm64/boot/dts/freescale/imx943-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> @@ -20,6 +20,7 @@ aliases {
>  		i2c5 = &lpi2c6;
>  		mmc0 = &usdhc1;
>  		mmc1 = &usdhc2;
> +		mmc2 = &usdhc3;
>  		serial0 = &lpuart1;
>  		serial5 = &lpuart6;
>  	};
> @@ -54,6 +55,32 @@ dmic: dmic {
>  		#sound-dai-cells = <0>;
>  	};
>
> +	reg_m2_pwr: regulator-m2-pwr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "M.2-power";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&pcal6416_i2c3_u46 2 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		/*
> +		 * M.2 device only can be enabled(W_DISABLE1#) after all Power
> +		 * Rails reach their minimum operating voltage (PCI Express M.2
> +		 * Specification r5.1 3.1.4 Power-up Timing).
> +		 * Set a delay equal to the max value of Tsettle here.
> +		 */
> +		startup-delay-us = <5000>;
> +	};
> +
> +	reg_m2_wlan: regulator-wlan {
> +		compatible = "regulator-fixed";
> +		regulator-name = "WLAN_EN";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&reg_m2_pwr>;
> +		gpio = <&pcal6416_i2c3_u46 5 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
>  	reg_usdhc2_vmmc: regulator-usdhc2 {
>  		compatible = "regulator-fixed";
>  		off-on-delay-us = <12000>;
> @@ -141,6 +168,11 @@ sound-wm8962 {
>  		model = "wm8962-audio";
>  	};
>
> +	usdhc3_pwrseq: usdhc3_pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&pcal6416_i2c3_u46 4 GPIO_ACTIVE_LOW>;
> +	};
> +
>  	memory@80000000 {
>  		reg = <0x0 0x80000000 0x0 0x80000000>;
>  		device_type = "memory";
> @@ -760,6 +792,18 @@ IMX94_PAD_SD2_RESET_B__GPIO4_IO27	0x31e
>  		>;
>  	};
>
> +	pinctrl_usdhc3: usdhc3grp {
> +		fsl,pins = <
> +			IMX94_PAD_GPIO_IO48__USDHC3_CLK		0x158e
> +			/* Need to config the SION for CMD pad, refer to ERR053138 */
> +			IMX94_PAD_GPIO_IO49__USDHC3_CMD		0x4000138e
> +			IMX94_PAD_GPIO_IO50__USDHC3_DATA0	0x138e
> +			IMX94_PAD_GPIO_IO51__USDHC3_DATA1	0x138e
> +			IMX94_PAD_GPIO_IO52__USDHC3_DATA2	0x138e
> +			IMX94_PAD_GPIO_IO53__USDHC3_DATA3	0x138e
> +		>;
> +	};
> +
>  	pinctrl_xspi1: xspi1grp {
>  		fsl,pins = <
>  			IMX94_PAD_XSPI1_SCLK__XSPI1_A_SCLK	0x3fe
> @@ -802,6 +846,23 @@ &usdhc2 {
>  	status = "okay";
>  };
>
> +&usdhc3 {
> +	/*
> +	 * Only enable SDIO2.0 mode as the corresponding GPIO pads are 3.3V, the
> +	 * max frequency is 50MHz.
> +	 */
> +	pinctrl-0 = <&pinctrl_usdhc3>;
> +	pinctrl-1 = <&pinctrl_usdhc3>;
> +	pinctrl-names = "default", "sleep";
> +	bus-width = <4>;
> +	vmmc-supply = <&reg_m2_wlan>;
> +	mmc-pwrseq = <&usdhc3_pwrseq>;
> +	keep-power-in-suspend;
> +	non-removable;
> +	wakeup-source;
> +	status = "okay";
> +};
> +
>  &wdog3 {
>  	fsl,ext-reset-output;
>  	status = "okay";
> --
> 2.37.1
>

  reply	other threads:[~2026-02-04 15:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  2:23 [PATCH V2] arm64: dts: imx943-evk: add usdhc3 for SDIO WiFi support Sherry Sun
2026-02-04 15:39 ` Frank Li [this message]
2026-03-02 16:09 ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYNoRaDA0vCUyyHC@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox