From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: adc: ad4080: add support for AD4082
Date: Fri, 6 Feb 2026 15:57:41 +0200 [thread overview]
Message-ID: <aYXzVc2FfWnuWpGs@smile.fi.intel.com> (raw)
In-Reply-To: <aYXy-B-b9CpUKZ7C@smile.fi.intel.com>
On Fri, Feb 06, 2026 at 03:56:13PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 06, 2026 at 03:08:21PM +0200, Antoniu Miclaus wrote:
> > Add support for AD4082 20-bit SAR ADC. The AD4082 has the same
> > resolution as AD4080 (20-bit) but differs in LVDS CNV clock count
> > maximum (8 vs 7).
>
> > Changes:
> > - Add AD4082_CHIP_ID definition (0x0052)
> > - Create ad4082_channel with 20-bit resolution and 32-bit storage
> > - Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
> > - Register AD4082 in device ID and OF match tables
>
> TBH, I think this section is too much for the commit message...
>
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
>
> ...and just as good to be placed here.
>
> Otherwise, LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Same comments for the patches 4 & 6. With that being addressed,
feel free to add my Rb there as well.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-06 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 13:08 [PATCH 0/6] iio: adc: ad4080: add support for AD4082, AD4085 and AD4088 Antoniu Miclaus
2026-02-06 13:08 ` [PATCH 1/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4082 Antoniu Miclaus
2026-02-06 13:08 ` [PATCH 2/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-06 13:56 ` Andy Shevchenko
2026-02-06 13:57 ` Andy Shevchenko [this message]
2026-02-08 9:37 ` Nuno Sá
2026-02-06 13:08 ` [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085 Antoniu Miclaus
2026-02-07 10:52 ` Krzysztof Kozlowski
2026-02-07 15:10 ` Jonathan Cameron
2026-02-16 9:23 ` Miclaus, Antoniu
2026-02-16 10:09 ` Krzysztof Kozlowski
2026-02-06 13:08 ` [PATCH 4/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-08 9:36 ` Nuno Sá
2026-02-06 13:08 ` [PATCH 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088 Antoniu Miclaus
2026-02-07 10:53 ` Krzysztof Kozlowski
2026-02-06 13:08 ` [PATCH 6/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-08 9:36 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXzVc2FfWnuWpGs@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox