From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yasin Lee <yasin.lee.x@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
yasin.lee.x@outlook.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq
Date: Mon, 9 Feb 2026 10:46:34 +0200 [thread overview]
Message-ID: <aYme6jXNyPM_AHo-@smile.fi.intel.com> (raw)
In-Reply-To: <20260209-upstream-20260219-v1-2-2b4d74e309d1@gmail.com>
On Mon, Feb 09, 2026 at 11:37:03AM +0800, Yasin Lee wrote:
> Avoid division by zero when sampling frequency is unspecified by
> falling back to a default 100ms sampling period.
Fixes tag?
...
> + if (!val && !val2)
What's wrong with the positive conditional?
if (val || val2)
...
else
...
> + /* Fallback to a safe default sampling period */
> + period_ms = 100;
> + else
> + period_ms = div_u64(NANO, (val * MEGA + val2));
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 8:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 3:37 [PATCH 0/5] iio: proximity: hx9023s: firmware property, safety fixes, and ACPI support Yasin Lee
2026-02-09 3:37 ` [PATCH 1/5] iio: proximity: hx9023s: fix out-of-bounds access when copying firmware Yasin Lee
2026-02-09 8:45 ` Andy Shevchenko
2026-02-10 16:35 ` Yasin Lee
2026-02-14 17:24 ` Jonathan Cameron
2026-02-09 3:37 ` [PATCH 2/5] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq Yasin Lee
2026-02-09 8:46 ` Andy Shevchenko [this message]
2026-02-10 16:29 ` Yasin Lee
2026-02-10 17:34 ` Andy Shevchenko
2026-02-11 6:57 ` Yasin Lee
2026-02-09 3:37 ` [PATCH 3/5] iio: proximity: hx9023s: support firmware-name property Yasin Lee
2026-02-09 8:02 ` Krzysztof Kozlowski
2026-02-10 15:19 ` Yasin Lee
2026-02-09 8:50 ` Andy Shevchenko
2026-02-10 16:14 ` Yasin Lee
2026-02-09 3:37 ` [PATCH 4/5] dt-bindings: " Yasin Lee
2026-02-09 8:01 ` Krzysztof Kozlowski
2026-02-11 6:44 ` Yasin Lee
2026-02-09 3:37 ` [PATCH 5/5] iio: proximity: hx9023s: add ACPI support Yasin Lee
2026-02-09 8:44 ` Andy Shevchenko
2026-02-11 3:54 ` Yasin Lee
2026-02-11 8:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYme6jXNyPM_AHo-@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=yasin.lee.x@gmail.com \
--cc=yasin.lee.x@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox