From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: qcom: add sdm670 lpi tlmm
Date: Tue, 10 Feb 2026 19:35:09 -0500 [thread overview]
Message-ID: <aYvOvYPDnAfYUk_w@rdacayan> (raw)
In-Reply-To: <5fa188b3-d060-4513-bda3-6608a9bdd7ef@oss.qualcomm.com>
On Tue, Feb 10, 2026 at 10:08:19AM +0100, Konrad Dybcio wrote:
> On 2/10/26 3:11 AM, Richard Acayan wrote:
> > The Snapdragon 670 has an Low-Power Island (LPI) TLMM for configuring
> > pins related to audio. Add the driver for this.
> >
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
>
> [...]
>
> > +const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
> > + LPI_PINGROUP(0, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(1, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(2, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(3, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(4, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(5, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(6, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(7, LPI_NO_SLEW, _, _, _, _),
> > +
> > + LPI_PINGROUP(8, LPI_NO_SLEW, _, _, sec_tdm, _),
>
> "i2s1_clk"
>
> > + LPI_PINGROUP(9, LPI_NO_SLEW, _, _, sec_tdm, _),
>
> "i2s1_ws"
>
> > + LPI_PINGROUP(10, LPI_NO_SLEW, _, _, _, sec_tdm_din),
>
> "i2s1_data"
>
> > + LPI_PINGROUP(11, LPI_NO_SLEW, _, sec_tdm_dout, _, _),
>
> "i2s1_data"
What are the pinfunc numbers for these? Or are the pinfuncs the same
between I2S and TDM?
> > +
> > + LPI_PINGROUP(12, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(13, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(14, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(15, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(16, LPI_NO_SLEW, _, _, _, _),
> > + LPI_PINGROUP(17, LPI_NO_SLEW, _, _, _, _),
> > +
> > + LPI_PINGROUP(18, LPI_NO_SLEW, _, pdm_clk, _, _),
>
> "slimbus_clk"
Again, what pinfunc? Is PDM, the protocol between analog and digital
codec, using the SLIM clock?
next prev parent reply other threads:[~2026-02-11 0:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 2:11 [PATCH 0/3] SDM670 LPASS LPI pin controller support Richard Acayan
2026-02-10 2:11 ` [PATCH 1/3] dt-bindings: pinctrl: qcom: Add SDM670 LPI pinctrl Richard Acayan
2026-02-10 7:41 ` Krzysztof Kozlowski
2026-02-11 2:02 ` Richard Acayan
2026-02-12 7:28 ` Krzysztof Kozlowski
2026-02-10 2:11 ` [PATCH 2/3] pinctrl: qcom: add sdm670 lpi tlmm Richard Acayan
2026-02-10 9:08 ` Konrad Dybcio
2026-02-11 0:35 ` Richard Acayan [this message]
2026-02-12 9:07 ` Konrad Dybcio
2026-02-10 2:11 ` [PATCH 3/3] arm64: dts: qcom: sdm670: add lpi pinctrl Richard Acayan
2026-02-10 7:42 ` Krzysztof Kozlowski
2026-02-11 0:23 ` Richard Acayan
2026-02-12 9:08 ` Konrad Dybcio
2026-03-04 23:52 ` Richard Acayan
2026-02-23 10:14 ` [PATCH 0/3] SDM670 LPASS LPI pin controller support Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYvOvYPDnAfYUk_w@rdacayan \
--to=mailingradian@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox