From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com,
dlechner@baylibre.com, jic23@kernel.org,
jean-baptiste.maneyrol@tdk.com,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org,
robh@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 0/3] Add Invensense ICM42607
Date: Tue, 24 Feb 2026 19:41:35 +0200 [thread overview]
Message-ID: <aZ3iz18O3UEDTDqm@smile.fi.intel.com> (raw)
In-Reply-To: <20260224163109.370930-1-macroalpha82@gmail.com>
On Tue, Feb 24, 2026 at 10:31:02AM -0600, Chris Morgan wrote:
> Add support for the ICM42607 IMU. This sensor shares the same
> functionality but a different register layout with the existing
> ICM42600.
>
> This driver should work with the ICM42607 and ICM42607P over both I2C
> and SPI, however only the ICM42607P over I2C could be tested.
Thanks for your contribution, but...
NAK.
It's unreviewable bulk out of 4kLoC! I even won't bother looking at any other
messages in this (too mini) series.
TL;DR: reviewable code is limited at ~750 (or less) ± 150 LoC per patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-24 17:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 16:31 [PATCH 0/3] Add Invensense ICM42607 Chris Morgan
2026-02-24 16:31 ` [PATCH 1/3] dt-bindings: iio: imu: icm42607: Add devicetree binding Chris Morgan
2026-02-24 17:29 ` Rob Herring (Arm)
2026-02-24 16:31 ` [PATCH 2/3] iio: imu: inv_icm42607: add new inv_icm42607 driver Chris Morgan
2026-02-24 20:05 ` kernel test robot
2026-02-25 0:04 ` kernel test robot
2026-02-25 3:21 ` kernel test robot
2026-02-28 18:52 ` Jonathan Cameron
2026-02-24 16:31 ` [PATCH 3/3] arm64: dts: rockchip: Add icm42607p IMU for RG-DS Chris Morgan
2026-02-24 17:41 ` Andy Shevchenko [this message]
2026-02-25 14:20 ` [PATCH 0/3] Add Invensense ICM42607 Chris Morgan
2026-02-25 17:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ3iz18O3UEDTDqm@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=heiko@sntech.de \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox