From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Rodrigo Alencar via B4 Relay
<devnull+rodrigo.alencar.analog.com@kernel.org>,
rodrigo.alencar@analog.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v4 05/11] iio: amplifiers: ad8366: use devm_mutex_init() and drop mutex_init()
Date: Sun, 15 Feb 2026 09:50:58 +0200 [thread overview]
Message-ID: <aZF64mqQ-SDjzbe5@smile.fi.intel.com> (raw)
In-Reply-To: <20260214183616.14f790bc@jic23-huawei>
On Sat, Feb 14, 2026 at 06:36:16PM +0000, Jonathan Cameron wrote:
> On Tue, 10 Feb 2026 19:42:05 +0000
> Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> > Adopt proper mutex lifecycle with devm_mutex_init(), replacing
> > mutex_init(). Also, Include linux/mutex.h header.
>
> Why move the *mutex_init()? Even if it is just because it looks better there,
> not breaking up spi related stuff, then say that.
Yes, this needs to be recorded. But actually initialising mutex (and lock
in general) earlier is usually a good thing and in some cases might even
fix a hidden bug.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-15 7:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 19:42 [PATCH v4 00/11] iio: amplifiers: ad8366: driver update and dt support Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 01/11] MAINTAINERS: Add missing maintainer entry for AD8366 driver Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 02/11] dt-bindings: iio: amplifiers: Add AD8366 support Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 03/11] iio: amplifiers: ad8366: remove unused include headers Rodrigo Alencar via B4 Relay
2026-02-10 19:57 ` Andy Shevchenko
2026-02-11 12:55 ` Rodrigo Alencar
2026-02-11 13:35 ` Andy Shevchenko
2026-02-14 18:30 ` Jonathan Cameron
2026-02-15 7:31 ` Andy Shevchenko
2026-02-15 16:03 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 04/11] iio: amplifiers: ad8366: add local dev pointer to the probe function Rodrigo Alencar via B4 Relay
2026-02-10 19:58 ` Andy Shevchenko
2026-02-10 20:03 ` Andy Shevchenko
2026-02-14 18:34 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 05/11] iio: amplifiers: ad8366: use devm_mutex_init() and drop mutex_init() Rodrigo Alencar via B4 Relay
2026-02-10 20:00 ` Andy Shevchenko
2026-02-14 18:36 ` Jonathan Cameron
2026-02-15 7:50 ` Andy Shevchenko [this message]
2026-02-10 19:42 ` [PATCH v4 06/11] iio: amplifiers: ad8366: replace reset-gpio with reset controller Rodrigo Alencar via B4 Relay
2026-02-14 18:37 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management Rodrigo Alencar via B4 Relay
2026-02-10 20:05 ` Andy Shevchenko
2026-02-11 12:10 ` Rodrigo Alencar
2026-02-11 13:30 ` Andy Shevchenko
2026-02-14 18:44 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 08/11] iio: amplifiers: ad8366: prepare for device-tree support Rodrigo Alencar via B4 Relay
2026-02-14 18:56 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 09/11] iio: amplifiers: ad8366: add device tree support Rodrigo Alencar via B4 Relay
2026-02-14 19:00 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 10/11] iio: amplifiers: ad8366: consume enable gpio Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 11/11] iio: amplifiers: ad8366: update device support Rodrigo Alencar via B4 Relay
2026-02-14 19:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZF64mqQ-SDjzbe5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+rodrigo.alencar.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox