[PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA234 device

[PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA234 device

[Ian Ray]

Add a compatible string for the INA234 device, which is like INA226 but
has different scaling.

Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
---
 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index d3cde8936686..009d78b30859 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -29,6 +29,7 @@ properties:
       - ti,ina230
       - ti,ina231
       - ti,ina233
+      - ti,ina234
       - ti,ina237
       - ti,ina238
       - ti,ina260
@@ -113,6 +114,7 @@ allOf:
               - ti,ina228
               - ti,ina230
               - ti,ina231
+              - ti,ina234
               - ti,ina237
               - ti,ina238
               - ti,ina260
@@ -134,6 +136,7 @@ allOf:
               - ti,ina226
               - ti,ina230
               - ti,ina231
+              - ti,ina234
               - ti,ina260
               - ti,ina700
               - ti,ina780
-- 
2.49.0

Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA234 device

[Krzysztof Kozlowski]

On 17/02/2026 10:23, Ian Ray wrote:
> Add a compatible string for the INA234 device, which is like INA226 but
> has different scaling.
> 
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> ---
>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 3 +++

I got 1/2 but no cover letter, no 2/2 and no explanation in the
changelog of that. Usually I use driver code to avoid you questions
about compatibility, but since you decided not to send it to me, then
you have question:

Does "different scaling" mean devices are not compatible in terms of DT
compatibility (subset/superset)?

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA234 device

[Ian Ray]

On Tue, Feb 17, 2026 at 11:05:47AM +0100, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of GE HealthCare. Only open links or attachments if you trust the sender. Report suspicious emails using Outlook’s “Report” button.
> 
> On 17/02/2026 10:23, Ian Ray wrote:
> > Add a compatible string for the INA234 device, which is like INA226 but
> > has different scaling.
> >
> > Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> > ---
> >  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 3 +++
> 
> I got 1/2 but no cover letter, no 2/2 and no explanation in the
> changelog of that. Usually I use driver code to avoid you questions
> about compatibility, but since you decided not to send it to me, then
> you have question:

Sincere apologies, I used scripts/get_maintainer.pl with git-send-email
and failed to notice that you were not cc'd.

Patch [2/2] is here:
https://lore.kernel.org/all/20260217092325.15867-2-ian.ray@gehealthcare.com/

> 
> Does "different scaling" mean devices are not compatible in terms of DT
> compatibility (subset/superset)?

That's correct, the device tree compatible must be different since the
driver uses the compatible to configure the scaling.

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA234 device

[Krzysztof Kozlowski]

On 17/02/2026 10:23, Ian Ray wrote:
> Add a compatible string for the INA234 device, which is like INA226 but
> has different scaling.
> 
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> ---
>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof