* [PATCH 0/3] Add wiko-chuppito devictree
@ 2026-02-15 20:02 Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Paul Adam via B4 Relay @ 2026-02-15 20:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel, Paul Adam
Add bindings vor Wiko SAS and wiko-chuppito
which are used in the devicetree.
Then introduce an initial device tree for Wiko PULP 4G.
Includes support for:
- UART
- USB (no OTG)
- Internal storage
- MicroSD
- Volume keys + Power button
- Touchscreen
- Backlight
- Accelerometer: Invensense MPU6880
- Magnetometer: Asahi Kasei AK09911
- Hall sensor: Rohm BU52021HFV
- Proximity sensor
- Vibrator
- Earpiece
- Microphone 1
- Headphones
- Wifi
- Bluetooth
- GPU
Signed-off-by: Paul Adam <adamp@posteo.de>
---
Paul Adam (3):
dt-bindings: vendor-prefixes: add WIKO SAS
dt-bindings: arm: qcom: add wiko,chuppito compatible string
arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts | 371 +++++++++++++++++++++
4 files changed, 375 insertions(+)
---
base-commit: cee73b1e840c154f64ace682cb477c1ae2e29cc4
change-id: 20260215-wiko-chuppito-ae8af4843e67
Best regards,
--
Paul Adam <adamp@posteo.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS
2026-02-15 20:02 [PATCH 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay
@ 2026-02-15 20:02 ` Paul Adam via B4 Relay
2026-02-16 7:35 ` Krzysztof Kozlowski
2026-02-15 20:02 ` [PATCH 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay
2 siblings, 1 reply; 8+ messages in thread
From: Paul Adam via B4 Relay @ 2026-02-15 20:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel, Paul Adam
From: Paul Adam <adamp@posteo.de>
Wiko is a french smartphone company: https://wikomobile.com
Signed-off-by: Paul Adam <adamp@posteo.de>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index edbce100cae4..187089eef983 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1819,6 +1819,8 @@ patternProperties:
description: Wi2Wi, Inc.
"^widora,.*":
description: Beijing Widora Technology Co., Ltd.
+ "^wiko,.*":
+ description: Wiko SAS
"^wiligear,.*":
description: Wiligear, Ltd.
"^willsemi,.*":
--
2.52.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string
2026-02-15 20:02 [PATCH 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
@ 2026-02-15 20:02 ` Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay
2 siblings, 0 replies; 8+ messages in thread
From: Paul Adam via B4 Relay @ 2026-02-15 20:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel, Paul Adam
From: Paul Adam <adamp@posteo.de>
Add a compatible for Wiko PULP 4G
Signed-off-by: Paul Adam <adamp@posteo.de>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index d48c625d3fc4..c9525b61f8ff 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -186,6 +186,7 @@ properties:
- samsung,serranove
- thwc,uf896
- thwc,ufi001c
+ - wiko,chuppito
- wingtech,wt86518
- wingtech,wt86528
- wingtech,wt88047
--
2.52.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
2026-02-15 20:02 [PATCH 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay
@ 2026-02-15 20:02 ` Paul Adam via B4 Relay
2026-02-16 11:18 ` Konrad Dybcio
2 siblings, 1 reply; 8+ messages in thread
From: Paul Adam via B4 Relay @ 2026-02-15 20:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel, Paul Adam
From: Paul Adam <adamp@posteo.de>
Add an initial device tree for Wiko PULP 4G.
Includes support for:
- UART
- USB (no OTG)
- Internal storage
- MicroSD
- Volume keys + Power button
- Touchscreen
- Backlight
- Accelerometer: Invensense MPU6880
- Magnetometer: Asahi Kasei AK09911
- Hall sensor: Rohm BU52021HFV
- Proximity sensor
- Vibrator
- Earpiece
- Microphone 1
- Headphones
- Wifi
- Bluetooth
- GPU
Signed-off-by: Paul Adam <adamp@posteo.de>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts | 371 +++++++++++++++++++++
2 files changed, 372 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index f80b5d9cf1e8..5a3a9a823503 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-rossa.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-uf896.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-ufi001c.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8916-wiko-chuppito.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86518.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86528.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts
new file mode 100644
index 000000000000..9e185c8f8f54
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts
@@ -0,0 +1,371 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-pm8916.dtsi"
+#include "msm8916-modem-qdsp6.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
+
+/ {
+ model = "Wiko Pulp 4G";
+ compatible = "wiko,chuppito", "qcom,msm8916";
+ chassis-type = "handset";
+
+ aliases {
+ mmc0 = &sdhc_1; /* eMMC */
+ mmc1 = &sdhc_2; /* SD card */
+ serial0 = &blsp_uart2;
+ };
+
+ chosen {
+ stdout-path = "serial0";
+ };
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pm8916_pwm 0 100000>;
+ brightness-levels = <0 255>;
+ num-interpolated-steps = <255>;
+ default-brightness-level = <255>;
+ enable-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&button_backlight_default>;
+ pinctrl-1 = <&button_backlight_off>;
+ pinctrl-names = "default", "off";
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&gpio_keys_default>;
+ pinctrl-names = "default";
+ label = "GPIO Buttons";
+
+ button-volume-up {
+ label = "Volume up";
+ gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ };
+ };
+
+ gpio-hall-sensor {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&gpio_hall_sensor_default>;
+ pinctrl-names = "default";
+ label = "GPIO Hall Effect Sensor";
+
+ event-hall-sensor {
+ label = "Hall Effect Sensor";
+ gpios = <&tlmm 117 GPIO_ACTIVE_LOW>;
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_LID>;
+ linux,can-disable;
+ };
+ };
+
+ usb_id: usb-id {
+ compatible = "linux,extcon-usb-gpio";
+ id-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&usb_id_default>;
+ pinctrl-names = "default";
+ };
+};
+
+&blsp_uart2 {
+ status = "okay";
+};
+
+&blsp_i2c2 {
+ status = "okay";
+
+ magnetometer@c {
+ compatible = "asahi-kasei,ak09911";
+ reg = <0x0c>;
+ vdd-supply = <&pm8916_l17>;
+ vid-supply = <&pm8916_l6>;
+ reset-gpios = <&tlmm 120 GPIO_ACTIVE_LOW>;
+ pinctrl-0 = <&mag_reset_default>;
+ pinctrl-1 = <&mag_reset_suspend>;
+ pinctrl-names = "default", "suspend";
+ mount-matrix = "1", "0", "0",
+ "0", "1", "0",
+ "0", "0", "1";
+ };
+
+ proximity@48 {
+ // downstream devicetree only specifies "stk,stk3x1x"
+ compatible = "sensortek,stk3310";
+ reg = <0x48>;
+ interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>;
+ pinctrl-0 = <&proximity_int_default>;
+ pinctrl-1 = <&proximity_int_suspend>;
+ pinctrl-names = "default", "suspend";
+ };
+
+ imu@68 {
+ compatible = "invensense,mpu6880";
+ reg = <0x68>;
+ interrupts-extended = <&tlmm 115 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8916_l17>;
+ vddio-supply = <&pm8916_l6>;
+ pinctrl-0 = <&imu_int_default>;
+ pinctrl-1 = <&imu_int_suspend>;
+ pinctrl-names = "default", "suspend";
+ mount-matrix = "0", "-1", "0",
+ "-1", "0", "0",
+ "0", "0", "-1";
+ };
+};
+
+&blsp_i2c5 {
+ status = "okay";
+
+ rmi4@39 {
+ compatible = "syna,rmi4-i2c";
+ reg = <0x39>;
+ interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8916_l17>;
+ vio-supply = <&pm8916_l6>;
+ pinctrl-0 = <&touchscreen_default>;
+ pinctrl-1 = <&touchscreen_suspend>;
+ pinctrl-names = "default", "suspend";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ syna,startup-delay-ms = <100>;
+ syna,reset-delay-ms = <160>;
+
+ rmi4-f01@1 {
+ reg = <0x1>;
+ syna,nosleep-mode = <1>;
+ };
+
+ rmi4-f11@11 {
+ reg = <0x11>;
+ syna,sensor-type = <1>;
+ };
+ };
+};
+
+// make sure gcc is probed with display disabled.
+&gcc {
+ clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>;
+};
+
+&gpu {
+ status = "okay";
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mpss_mem {
+ reg = <0x0 0x86800000 0x0 0x5600000>;
+};
+
+&pm8916_l6 {
+ regulator-always-on;
+};
+
+&pm8916_pwm {
+ pinctrl-0 = <&pwm_out>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&pm8916_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&pm8916_rpm_regulators {
+ pm8916_l17: l17 {
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <2850000>;
+ regulator-always-on;
+ };
+};
+
+&pm8916_vib {
+ status = "okay";
+};
+
+&sdhc_1 {
+ status = "okay";
+};
+
+&sdhc_2 {
+ pinctrl-0 = <&sdc2_default>, <&sdc2_cd_default>;
+ pinctrl-1 = <&sdc2_sleep>, <&sdc2_cd_default>;
+ pinctrl-names = "default", "sleep";
+ cd-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+};
+
+&sound {
+ audio-routing =
+ "AMIC1", "MIC BIAS Internal1",
+ "AMIC2", "MIC BIAS Internal2",
+ "AMIC3", "MIC BIAS Internal1";
+};
+
+&usb {
+ extcon = <&usb_id>, <&usb_id>;
+ status = "okay";
+};
+
+&usb_hs_phy {
+ extcon = <&usb_id>;
+};
+
+&venus {
+ status = "okay";
+};
+
+&venus_mem {
+ status = "okay";
+};
+
+&wcnss {
+ status = "okay";
+};
+
+&wcnss_iris {
+ compatible = "qcom,wcn3620";
+};
+
+&wcnss_mem {
+ status = "okay";
+};
+
+&tlmm {
+ button_backlight_default: button-backlight-default-state {
+ pins = "gpio119";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ button_backlight_off: button-backlight-off-state {
+ pins = "gpio119";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-low;
+ };
+
+ gpio_keys_default: gpio-keys-default-state {
+ pins = "gpio107";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ gpio_hall_sensor_default: gpio-hall-sensor-default-state {
+ pins = "gpio117";
+ function = "gpio";
+ drive-strength = <6>;
+ bias-pull-up;
+ };
+
+ imu_int_default: imu-int-default-state {
+ pins = "gpio115";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ imu_int_suspend: imu-int-suspend-state {
+ pins = "gpio115";
+ function = "gpio";
+ drive-strength = <2>;
+ };
+
+ mag_reset_default: mag-reset-default-state {
+ pins = "gpio120";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ mag_reset_suspend: mag-reset-suspend-state {
+ pins = "gpio120";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ proximity_int_default: proximity-int-default-state {
+ pins = "gpio113";
+ function = "gpio";
+ drive-strength = <6>;
+ bias-pull-up;
+ };
+
+ proximity_int_suspend: proximity-int-suspend-state {
+ pins = "gpio113";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ sdc2_cd_default: sdc2-cd-default-state {
+ pins = "gpio38";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ touchscreen_default: touchscreen-default-state {
+ touchscreen-pins {
+ pins = "gpio13";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ reset-pins {
+ pins = "gpio12";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+
+ touchscreen_suspend: touchscreen-suspend-state {
+ touchscreen-pins {
+ pins = "gpio13";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ reset-pins {
+ pins = "gpio12";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ usb_id_default: usb-id-default-state {
+ pins = "gpio110";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+};
+
+&pm8916_codec {
+ qcom,hphl-jack-type-normally-open;
+};
+
+&pm8916_mpps {
+ pwm_out: mpp4-state {
+ pins = "mpp4";
+ function = "digital";
+ power-source = <PM8916_MPP_VPH>;
+ output-low;
+ qcom,dtest = <1>;
+ };
+};
--
2.52.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS
2026-02-15 20:02 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
@ 2026-02-16 7:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-16 7:35 UTC (permalink / raw)
To: Paul Adam
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel
On Sun, Feb 15, 2026 at 09:02:01PM +0100, Paul Adam wrote:
> Wiko is a french smartphone company: https://wikomobile.com
>
> Signed-off-by: Paul Adam <adamp@posteo.de>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index edbce100cae4..187089eef983 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1819,6 +1819,8 @@ patternProperties:
> description: Wi2Wi, Inc.
> "^widora,.*":
> description: Beijing Widora Technology Co., Ltd.
> + "^wiko,.*":
Domain is wikomobile, so use that one... unless wiko.com is the same -
looks kind of as, but then use correct address.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
2026-02-15 20:02 ` [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay
@ 2026-02-16 11:18 ` Konrad Dybcio
2026-02-17 10:57 ` Paul Adam
0 siblings, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2026-02-16 11:18 UTC (permalink / raw)
To: adamp, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel
On 2/15/26 9:02 PM, Paul Adam via B4 Relay wrote:
> From: Paul Adam <adamp@posteo.de>
>
> Add an initial device tree for Wiko PULP 4G.
> Includes support for:
> - UART
> - USB (no OTG)
> - Internal storage
> - MicroSD
> - Volume keys + Power button
> - Touchscreen
> - Backlight
> - Accelerometer: Invensense MPU6880
> - Magnetometer: Asahi Kasei AK09911
> - Hall sensor: Rohm BU52021HFV
> - Proximity sensor
> - Vibrator
> - Earpiece
> - Microphone 1
> - Headphones
> - Wifi
> - Bluetooth
> - GPU
>
> Signed-off-by: Paul Adam <adamp@posteo.de>
> ---
Hello, just a couple comments below
[...]
> + chosen {
> + stdout-path = "serial0";
> + };
> + backlight: backlight {
Please add a \n above to separate these blocks
> + compatible = "pwm-backlight";
> + pwms = <&pm8916_pwm 0 100000>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <255>;
> + default-brightness-level = <255>;
> + enable-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&button_backlight_default>;
> + pinctrl-1 = <&button_backlight_off>;
> + pinctrl-names = "default", "off";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&gpio_keys_default>;
> + pinctrl-names = "default";
> + label = "GPIO Buttons";
I think the GPIO prefix is unnecesary here and below
> +
> + button-volume-up {
> + label = "Volume up";
> + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> + };
> +
> + gpio-hall-sensor {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&gpio_hall_sensor_default>;
> + pinctrl-names = "default";
> + label = "GPIO Hall Effect Sensor";
[...]
> + proximity@48 {
> + // downstream devicetree only specifies "stk,stk3x1x"
> + compatible = "sensortek,stk3310";
Looks like the driver has a number of CHIP_IDs - you can be sure which chip
specifically this is by printing it out
[...]
> +// make sure gcc is probed with display disabled.
> +&gcc {
> + clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>;
> +};
Do things break if you remove this line?
> +
> +&gpu {
> + status = "okay";
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mpss_mem {
> + reg = <0x0 0x86800000 0x0 0x5600000>;
> +};
> +
> +&pm8916_l6 {
> + regulator-always-on;
Is there a reason for this?
[...]
> +&sound {
> + audio-routing =
> + "AMIC1", "MIC BIAS Internal1",
Please unbreak this line after '='
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
2026-02-16 11:18 ` Konrad Dybcio
@ 2026-02-17 10:57 ` Paul Adam
2026-02-17 11:04 ` Konrad Dybcio
0 siblings, 1 reply; 8+ messages in thread
From: Paul Adam @ 2026-02-17 10:57 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel
On 26/02/16 12:18, Konrad Dybcio wrote:
> Hello, just a couple comments below
Thanks for the feedback!
> > +// make sure gcc is probed with display disabled.
> > +&gcc {
> > + clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>;
> > +};
>
> Do things break if you remove this line?
I tested it without and it still works. I just included it because
it was on the pmos msm8916 mainlining wiki page.
> > +
> > +&gpu {
> > + status = "okay";
> > +};
> > +
> > +&mdss {
> > + status = "okay";
> > +};
> > +
> > +&mpss_mem {
> > + reg = <0x0 0x86800000 0x0 0x5600000>;
> > +};
> > +
> > +&pm8916_l6 {
> > + regulator-always-on;
>
> Is there a reason for this?
I removed the always-on property, it was for testing purposes.
mpss_mem is needed for audio to work.
I removed mdss since it is only needed for the panel.
Should the gpu only be enabled when the panel is added?
Also should I wait some time for additional comments or immediatly
send a new version when all remarks are addressed?
Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
2026-02-17 10:57 ` Paul Adam
@ 2026-02-17 11:04 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2026-02-17 11:04 UTC (permalink / raw)
To: Paul Adam
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel
On 2/17/26 11:57 AM, Paul Adam wrote:
> On 26/02/16 12:18, Konrad Dybcio wrote:
>> Hello, just a couple comments below
>
> Thanks for the feedback!
>
>>> +// make sure gcc is probed with display disabled.
>>> +&gcc {
>>> + clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>;
>>> +};
>>
>> Do things break if you remove this line?
>
> I tested it without and it still works. I just included it because
> it was on the pmos msm8916 mainlining wiki page.
If nothing breaks, let's remove it :)
>>> +
>>> +&gpu {
>>> + status = "okay";
>>> +};
>>> +
>>> +&mdss {
>>> + status = "okay";
>>> +};
>>> +
>>> +&mpss_mem {
>>> + reg = <0x0 0x86800000 0x0 0x5600000>;
>>> +};
>>> +
>>> +&pm8916_l6 {
>>> + regulator-always-on;
>>
>> Is there a reason for this?
>
> I removed the always-on property, it was for testing purposes.
> mpss_mem is needed for audio to work.
> I removed mdss since it is only needed for the panel.
> Should the gpu only be enabled when the panel is added?
Ah, I only meant the regulator-always-on part specifically
The rest is OK, including the GPU and MDSS
> Also should I wait some time for additional comments or immediatly
> send a new version when all remarks are addressed?
Normally one would wait some 2-3 days after sending. Because we're now in
the special part of the cycle (post stable release, pre -rc1 release where no
new patches are accepted yet), some people will be grumpy and actively refuse
to review your changes but I wouldn't pay too much attention to that
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-02-17 11:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-15 20:02 [PATCH 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
2026-02-16 7:35 ` Krzysztof Kozlowski
2026-02-15 20:02 ` [PATCH 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay
2026-02-15 20:02 ` [PATCH 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay
2026-02-16 11:18 ` Konrad Dybcio
2026-02-17 10:57 ` Paul Adam
2026-02-17 11:04 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox