From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ariana.Lazar@microchip.com
Cc: dlechner@baylibre.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, jic23@kernel.org, andy@kernel.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH 2/2] iio: dac: add support for Microchip MCP48FEB02
Date: Tue, 17 Feb 2026 14:12:33 +0200 [thread overview]
Message-ID: <aZRbMaavH14pV2Mv@smile.fi.intel.com> (raw)
In-Reply-To: <d910218942390c6cbb9be403b6ff6261b84260d3.camel@microchip.com>
On Tue, Feb 17, 2026 at 11:38:10AM +0000, Ariana.Lazar@microchip.com wrote:
> > I think something like a second variant. But as it seems going to be
> > an
> > agreement that this driver is not needed and rather we need to
> > refactor
> > existing one to add the support for SPI chips, these comments won't
> > make
> > much value.
> >
> > --
> Thank you fo the review. I think these comments are revelent because
> that code is common for both drivers, the SPI and I2C.
> I will refactor both drivers to be merged into a single one and in
> order to avoid multiple code refactoring, if you agree, I will
> implement those changes as well.
Sure, if you have time for that. I'm not insisting...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-17 12:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 12:48 [PATCH 0/2] Add support for Microchip MCP48FxBy1/2/4/8 DAC with an SPI Interface Ariana Lazar
2026-02-12 12:48 ` [PATCH 1/2] dt-bindings: iio: dac: add support for Microchip MCP48FEB02 Ariana Lazar
2026-02-12 17:31 ` Rob Herring (Arm)
2026-02-12 18:00 ` Conor Dooley
2026-02-12 20:04 ` Andy Shevchenko
2026-02-16 13:31 ` Ariana.Lazar
2026-02-16 15:37 ` David Lechner
2026-02-16 17:34 ` Conor Dooley
2026-02-16 18:38 ` David Lechner
2026-02-12 12:48 ` [PATCH 2/2] " Ariana Lazar
2026-02-12 14:42 ` Andy Shevchenko
2026-02-16 14:29 ` Ariana.Lazar
2026-02-17 7:54 ` Andy Shevchenko
2026-02-17 11:38 ` Ariana.Lazar
2026-02-17 12:12 ` Andy Shevchenko [this message]
2026-02-15 17:58 ` Jonathan Cameron
2026-02-12 13:39 ` [PATCH 0/2] Add support for Microchip MCP48FxBy1/2/4/8 DAC with an SPI Interface Andy Shevchenko
2026-02-12 17:58 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZRbMaavH14pV2Mv@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Ariana.Lazar@microchip.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox