From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Michal Simek <michal.simek@amd.com>
Cc: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Nuno Sa <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, saikrishna12468@gmail.com,
git@amd.com
Subject: Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions
Date: Fri, 20 Feb 2026 10:09:34 +0200 [thread overview]
Message-ID: <aZgWvjWBusT_JQgE@smile.fi.intel.com> (raw)
In-Reply-To: <fab2599c-e749-4aa1-8157-c7ac358c6f36@amd.com>
On Fri, Feb 20, 2026 at 08:54:26AM +0100, Michal Simek wrote:
> On 2/20/26 08:52, Andy Shevchenko wrote:
> > On Fri, Feb 20, 2026 at 11:09:39AM +0530, Sai Krishna Potthuri wrote:
> > > Replace module_platform_driver() macro with custom init and exit functions
> > > to prepare for supporting multiple bus interfaces (platform + I2C).
> >
> > No, this is not how it should be done.
>
> And how should it be done? separate file?
I answered somewhere else, but I can elaborate here as well.
The idea, yes, to have the driver in the parts:
_core.c
_platform.c
_i2c.c
To achieve that, it needs first to split the driver followed by likely
conversion to regmap. With that done it may be used in i2c with a little
code added into _i2c.c.
We have examples in kernel for that.
0daede80f870 ("i2c: designware: Convert driver to using regmap API")
fcb82a939df8 ("i2c: designware: Add Baikal-T1 System I2C support")
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-20 8:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 5:39 [PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard Sai Krishna Potthuri
2026-02-20 5:39 ` [PATCH 1/5] iio: adc: xilinx-xadc: Add helper functions for the device setup Sai Krishna Potthuri
2026-02-20 7:50 ` Andy Shevchenko
2026-02-20 5:39 ` [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure Sai Krishna Potthuri
2026-02-20 7:52 ` Andy Shevchenko
2026-02-20 5:39 ` [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions Sai Krishna Potthuri
2026-02-20 7:52 ` Andy Shevchenko
2026-02-20 7:54 ` Michal Simek
2026-02-20 8:09 ` Andy Shevchenko [this message]
2026-03-18 9:13 ` Sai Krishna Potthuri
2026-03-18 9:46 ` Andy Shevchenko
2026-02-20 5:39 ` [PATCH 4/5] iio: adc: xilinx-xadc: Add I2C interface support Sai Krishna Potthuri
2026-02-20 7:58 ` Andy Shevchenko
2026-02-20 5:39 ` [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format Sai Krishna Potthuri
2026-02-21 10:38 ` Krzysztof Kozlowski
2026-03-19 13:52 ` Sai Krishna Potthuri
2026-03-19 14:23 ` David Lechner
2026-03-19 14:49 ` Sai Krishna Potthuri
2026-03-19 14:58 ` David Lechner
2026-03-19 15:10 ` Sai Krishna Potthuri
2026-03-19 15:35 ` David Lechner
2026-03-19 15:49 ` Sai Krishna Potthuri
2026-03-19 16:49 ` Krzysztof Kozlowski
2026-03-19 19:07 ` David Lechner
2026-03-22 9:55 ` Krzysztof Kozlowski
2026-02-21 10:39 ` Krzysztof Kozlowski
2026-02-20 8:00 ` [PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZgWvjWBusT_JQgE@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=git@amd.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox