From: "Otto Pflüger" <otto.pflueger@abscue.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: regulator: Document Unisoc SC2730 PMIC bindings
Date: Sat, 21 Feb 2026 14:02:40 +0100 [thread overview]
Message-ID: <aZms8JbARbxmZDVS@abscue.de> (raw)
In-Reply-To: <20260221-crimson-beaver-of-discourse-7ef24d@quoll>
On Sat, Feb 21, 2026 at 11:52:55AM +0100, Krzysztof Kozlowski wrote:
> [...]
> > +properties:
> > + compatible:
> > + const: sprd,sc2730-regulator
>
> Let's drop the compatible (which changes my comment on other patch as
> you can put only $ref in oneOf).
Sorry, I don't quite understand this part. It seems that you are
suggesting to change the top-level MFD bindings in the other patch to
look like this:
regulators:
type: object
oneOf:
- $ref: /schemas/regulator/sprd,sc2730-regulator.yaml#
- $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#
If that's the case, how should the regulator bindings for SC2730 be
distinguished from SC2731 without the compatible? Would it be fine to
keep the compatible here if I drop the additional if/then constraints in
the other patch?
next prev parent reply other threads:[~2026-02-21 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 17:01 [PATCH 0/3] regulator: Add support for Unisoc SC2730 PMIC regulators Otto Pflüger
2026-02-20 17:01 ` [PATCH 1/3] dt-bindings: regulator: Document Unisoc SC2730 PMIC bindings Otto Pflüger
2026-02-21 10:52 ` Krzysztof Kozlowski
2026-02-21 13:02 ` Otto Pflüger [this message]
2026-02-21 13:17 ` Krzysztof Kozlowski
2026-02-20 17:01 ` [PATCH 2/3] dt-bindings: mfd: sprd,sc2731: Reference sprd,sc2730-regulator bindings Otto Pflüger
2026-02-21 10:50 ` Krzysztof Kozlowski
2026-02-20 17:01 ` [PATCH 3/3] regulator: Add regulator driver for Unisoc SC2730 PMIC Otto Pflüger
2026-02-24 6:28 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZms8JbARbxmZDVS@abscue.de \
--to=otto.pflueger@abscue.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox