From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FDBC433EF for ; Fri, 13 May 2022 08:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378538AbiEMIsw (ORCPT ); Fri, 13 May 2022 04:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378569AbiEMIst (ORCPT ); Fri, 13 May 2022 04:48:49 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02BF14C752 for ; Fri, 13 May 2022 01:48:44 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id ba17so9160157edb.5 for ; Fri, 13 May 2022 01:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gxWA2eI2ibgIIaNeL9BTiWwh7yepFkmtPplmsANljIU=; b=fyAZtNkVRet3CqlJuO3iUCqEInUUV7abCdfI3nC47/p+HyZW30V2Vqrf+fPT60vTKA RIuPeM4ArUI5eLAdjAKZQlwWMpVBe3YHq8m6AFAKoSHbW2UCn/1O45utYv3zKHj99jYH 7Vs127/rj4k8sttyEIiDotLztO82wNJUWMXn0JP9Sw8Lz0wTSXkt4vMVhCJQTbHW1e24 ggBUS7baKZHkD6jhr+yDbGdUDjhWt2DvJTbc9fknVHrdW7CRUGYKSvyhbwgVe0xdQW6a tWpxs/pQH0PQzsJlKjLbOXBaIxyNC/jpLdLnDPRZsnMXjLyjvjMRm5/2z9xy7gwQDfc3 yckA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gxWA2eI2ibgIIaNeL9BTiWwh7yepFkmtPplmsANljIU=; b=akMK/tZEyM1bH1MVpGaD1TqBHY8wRn7oQNU6QIVXyE6AauAOBCaDgxp9GM4ruan5l3 KLmqAplUQEJdR7jDPRTd8MrArkDgpCQUAMwZGr9I6apKDd10YUD5oj53E3McAzTegawq yPyCX0rCguZu3vFfoqFzf9HZ62KOxq4bsQ+galA+swfVG/Spge9yXGaqYPAqThvTqO3/ 2BwUkxoDohNgUv4q2+LTal7cFayG9zCQ1FvLbiq+bwovVGbbNiJhN8Eg+zdkwQbMBQsn vXAuzdK2jQ3s5z8J6kx8tlEi3zZluZHNcwMZuMartCkIReXeKSlfZrVL/YXWeJCcK5kE zlAw== X-Gm-Message-State: AOAM530MqSoTpPU2zSwjJLG8875ANNAwUUyf0k2dQ/hOZeK/6FyTGZ32 YSUOQf00K+kyIfCM2WuumbnYHg== X-Google-Smtp-Source: ABdhPJwlWwvXgU7aF6Cscno2USHQ0ZXgPfK8ccIxhOVwMYKRXjcKM9wagMsXjaQh8FIahP3a0yeKUw== X-Received: by 2002:a05:6402:3490:b0:427:b471:9e1e with SMTP id v16-20020a056402349000b00427b4719e1emr38861806edc.36.1652431723172; Fri, 13 May 2022 01:48:43 -0700 (PDT) Received: from [192.168.0.169] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id t20-20020a056402525400b0042617ba63ccsm667368edd.86.2022.05.13.01.48.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 01:48:42 -0700 (PDT) Message-ID: Date: Fri, 13 May 2022 10:48:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] dt-bindings: iio: humidity: Add si7020 bindings Content-Language: en-US To: Eddie James , linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dbarksdale@uplogix.com References: <20220511190835.51046-1-eajames@linux.ibm.com> <20220511190835.51046-2-eajames@linux.ibm.com> From: Krzysztof Kozlowski In-Reply-To: <20220511190835.51046-2-eajames@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/05/2022 21:08, Eddie James wrote: > Document the si7020 bindings with a new "silabs,skip-reset" property. > > Signed-off-by: Eddie James Thank you for your patch. There is something to discuss/improve. > --- > .../bindings/iio/humidity/silabs,si7020.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > > diff --git a/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml b/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > new file mode 100644 > index 000000000000..ab53bb8d9606 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/silabs,si7020.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SI7020 humidity + temperature sensor > + > +maintainers: > + - David Barksdale > + > +description: | > + The Silicon Labs Si7013/20/21 Relative Humidity and Temperature Sensors > + are i2c devices which have an identical programming interface for > + measuring relative humidity and temperature. > + > +properties: > + compatible: > + const: silabs,si7020 > + > + reg: > + maxItems: 1 > + > + siliabs,skip-reset: Do not describe implementation (driver) behavior, but the device hardware. > + $ref: /schemas/types.yaml#/definitions/flag "type:boolean" is shorter > + description: > + Disables resetting of the device during probe > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + si7021-a20@40 { Generic node name, so "sensor"? > + silabs,skip-reset; > + compatible = "silabs,si7020"; > + reg = <0x40>; Order the properties: 1. compatible, 2. reg, then the rest. > + }; > +... Best regards, Krzysztof