From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74CFE1CC898 for ; Tue, 27 Aug 2024 16:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724776002; cv=none; b=oiVhdOV6O8uHc7/hTfbagFtHTiY+ErPwjBxynB/31GPMNYP+wXTlJZQAeU2ddjQTya04A44vm3xv5L+VVufphxdJZzoCFF5qG/GZXFtw+DmPb2mwBsiY+zcJ6q1010bhZp6h8pDnsAmxt6FgMVdkfsTRbv6G5+gwMP0bg+kXi4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724776002; c=relaxed/simple; bh=e8CooLDyjqVzLqCwIuVAsXY+x0H9Iip9UWRM8TAkzXc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=IUEdu2XlL+ONbi8KazyAtLgHcyHhHZdM2vCRwXqTjdgeVz+Hv625GmHeOmAcxAc4T9sR2eV7/7NhDwhITeQfk43ip8GBP9yUI83Gu8+879Kw9s+KZIsxNzSOzdtfxfszPfQS9TqURFYWuH/FXDi7CR8x+NEhQDIHqSY4PaYCh00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WipV0yn/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WipV0yn/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4280c55e488so31348265e9.0 for ; Tue, 27 Aug 2024 09:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724775998; x=1725380798; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=v8CXfOImNZAPo+0QEI9EfNOPJJp994RZWBU+MZvr+8c=; b=WipV0yn/IOr74mX0aWaZnPihkrpRFFyo99+LjPa8YBB2LfRKT/3AL3eMnS6iqA5h/n m1gMAIs2oO7HAsZ2lcn9eeRBZbMPzzg26lHgBJ1Y1OHvgv1DTV0T5UToAoGagE7UQJRJ Vxt2GLQP0uMX3mZzGzg70Sn2l5rK08K9vqgbODPgzDi3uo619WlGO+gwKY/weXS3Mwyc oWKmvY/5WdTDz9nQrzACyTx2/ROOZuFnnA1XYLp1FMmZuHPayqf6D4ArWxXNWZudNlGy cnd1wdRP5JlJSBOPJEq2FuxrTvlChyPM4ss6Vu6HB+XnswUG3lEl/Sir6NMaVprU3uyh rYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724775998; x=1725380798; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=v8CXfOImNZAPo+0QEI9EfNOPJJp994RZWBU+MZvr+8c=; b=TpR8f57GqD23TNPsse/Valdbrwpzx8s98z+u1UgCqPW1rrNw8oeU4gvVbTwHIFK9U7 0/lJeNTI+MfdkeEauKqj2z8sY4L1FfYFHO8oSB8vLLmh/vBq7cdNyn/AzTE91p27aDXQ avz66gsq8AX/FJ1WdQ8dHrRqAJzonSYwP9T6HMLskrvIhFwzQKXI/Zqw43WvlRHVvQuC uejla2nc7ogdyjLWVw3pERMc9WK3mV04SEgaqZ/dqPiR7i8S2wbyBFtteHd/1YHGsfy+ YSRRQVe+0s4VdD03a8WQXLioJg0Bkd8w/gW4Tz1nqhI2F5xu8OQ1bi0IwU3jpWj/6p+a eecw== X-Forwarded-Encrypted: i=1; AJvYcCXLUcUeTdSUEN9LfrbGGc2RJboK7Rns/8JZh0xxnivp3wlR3LFVM9DaqemV0NEnQ6kqrI6UiUdr30et@vger.kernel.org X-Gm-Message-State: AOJu0Yyxuy2Y6hScONRe9OWyA6l35BA/AjlSINdzjphDkwApCTQ4as1l W7lsfxoCeoVYx+IXl0Jt5g3oIJlJBPdrfOy+bTgrJiJSS8MVMF04wLNL7klRaZk= X-Google-Smtp-Source: AGHT+IESU8S9DEVBMpyZfWscDxO0CMagekuQ/YRK6C4x9dg34h8I1OCh7vzpCcvK6gT1EZnV3jT6HQ== X-Received: by 2002:a05:600c:8aa:b0:42a:a749:e6 with SMTP id 5b1f17b1804b1-42b9a471114mr23411325e9.10.1724775996955; Tue, 27 Aug 2024 09:26:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:cedc:30f:887e:7717? ([2a01:e0a:982:cbb0:cedc:30f:887e:7717]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abefc627asm231269735e9.34.2024.08.27.09.26.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 09:26:36 -0700 (PDT) Message-ID: Date: Tue, 27 Aug 2024 18:26:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" To: Doug Anderson Cc: Stephan Gerhold , Bjorn Andersson , Konrad Dybcio , Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> <7daa3c0d-cecf-4f50-be32-ae116b920db0@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/08/2024 17:36, Doug Anderson wrote: > Hi, > > On Mon, Jul 22, 2024 at 8:49 AM Doug Anderson wrote: >> >> Hi, >> >> On Mon, Jul 15, 2024 at 6:51 AM Doug Anderson wrote: >>> >>> Hi, >>> >>> On Mon, Jul 15, 2024 at 6:02 AM Neil Armstrong >>> wrote: >>>> >>>> On 15/07/2024 14:54, Stephan Gerhold wrote: >>>>> On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: >>>>>> On 15/07/2024 14:15, Stephan Gerhold wrote: >>>>>>> This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. >>>>>>> >>>>>>> The panel should be handled through the samsung-atna33xc20 driver for >>>>>>> correct power up timings. Otherwise the backlight does not work correctly. >>>>>>> >>>>>>> We have existing users of this panel through the generic "edp-panel" >>>>>>> compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only >>>>>>> partially in that configuration: It works after boot but once the screen >>>>>>> gets disabled it does not turn on again until after reboot. It behaves the >>>>>>> same way with the default "conservative" timings, so we might as well drop >>>>>>> the configuration from the panel-edp driver. That way, users with old DTBs >>>>>>> will get a warning and can move to the new driver. >>>>>>> >>>>>>> Reviewed-by: Douglas Anderson >>>>>>> Signed-off-by: Stephan Gerhold >>>>>>> --- >>>>>>> drivers/gpu/drm/panel/panel-edp.c | 2 -- >>>>>>> 1 file changed, 2 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c >>>>>>> index 3a574a9b46e7..d2d682385e89 100644 >>>>>>> --- a/drivers/gpu/drm/panel/panel-edp.c >>>>>>> +++ b/drivers/gpu/drm/panel/panel-edp.c >>>>>>> @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { >>>>>>> EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), >>>>>>> EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), >>>>>>> - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), >>>>>>> - >>>>>>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), >>>>>>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), >>>>>>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), >>>>>>> >>>>>> >>>>>> How will we handle current/old crd DT with new kernels ? >>>>>> >>>>> >>>>> I think this is answered in the commit message: >>>>> >>>>>>> We have existing users of this panel through the generic "edp-panel" >>>>>>> compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only >>>>>>> partially in that configuration: It works after boot but once the screen >>>>>>> gets disabled it does not turn on again until after reboot. It behaves the >>>>>>> same way with the default "conservative" timings, so we might as well drop >>>>>>> the configuration from the panel-edp driver. That way, users with old DTBs >>>>>>> will get a warning and can move to the new driver. >>>>> >>>>> Basically with the entry removed, the panel-edp driver will fallback to >>>>> default "conservative" timings when using old DTBs. There will be a >>>>> warning in dmesg, but otherwise the panel will somewhat work just as >>>>> before. I think this is a good way to remind users to upgrade. >>>> >>>> I consider this as a regression >>>> >>>>> >>>>>> Same question for patch 3, thie serie introduces a bindings that won't be valid >>>>>> if we backport patch 3. I don't think patch should be backported, and this patch >>>>>> should be dropped. >>>>> >>>>> There would be a dtbs_check warning, yeah. Functionally, it would work >>>>> just fine. Is that reason enough to keep display partially broken for >>>>> 6.11? We could also apply the minor binding change for 6.11 if needed. >>>> >>>> I don't know how to answer this, I'll let the DT maintainer comment this. >>>> >>>> The problem is I do not think we can pass the whole patchset as fixes >>>> for v6.11, patches 2 & 3 could, patches 1 & 4 definitely can't. >>>> >>>> Neil >>> >>> IMO: patch #3 (dts) and #4 (CONFIG) go through the Qualcomm tree >>> whenever those folks agree to it. If we're worried about the >>> dtbs_check breakage I personally wouldn't mind "Ack"ing patch #1 to go >>> through the Qualcomm tree as long as it made it into 6.11-rc1. I have >>> a hunch that there are going to be more Samsung OLED panels in the >>> future that will need to touch the same file, but if the change is in >>> -rc1 it should make it back into drm-misc quickly, right? >>> >>> Personally I think patch #2 could go in anytime since, as people have >>> said, things are pretty broken today and the worst that happens is >>> that someone gets an extra warning. That would be my preference. That >>> being said, we could also snooze that patch for a month or two and >>> land it later. There's no real hurry. >> >> For now I'm going to snooze this patch for a month just to avoid any >> controversy. I'll plan to apply it (to drm-misc-next) when I see the >> device tree patch land. Since the device tree patch should land as a >> fix that should keep things landing in the correct order. ...and, as >> per above, the worst case is that if someone has an old DTS and a new >> kernel then a panel that was already not working well will print a fat >> warning and startup a bit slower. >> >> If somehow I mess up and forget about this patch, feel free to send me >> a poke when the device tree patch is landed. > > More than a month has passed now. One last warning before I apply this > revert in a few more days. It's fine if you apply it now Neil > > -Doug >