From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84C1C3DA7D for ; Wed, 28 Dec 2022 13:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbiL1Njv (ORCPT ); Wed, 28 Dec 2022 08:39:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232873AbiL1Nju (ORCPT ); Wed, 28 Dec 2022 08:39:50 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE252F5BF for ; Wed, 28 Dec 2022 05:39:47 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id f34so23633449lfv.10 for ; Wed, 28 Dec 2022 05:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eivbSK/iggE609kMctsDa0t3SvfhXTo/TwRgMrcMZFg=; b=Oks7pXiC6qUVeemn/v839Rt/lL5d0+dpW7V5//V9fTgHM0F+TQk8VhMY/RPv2P39Lb R0eO5V2rw+d7TK8xJLau8DchNPeGTLolBqgbafOygs2YtBpCbp1ThuAmiqIQ80EqVdol Vga3XhjoJDwGjxpgNzwDbiuWmS0OqRTi896coKzyjiUv05XxbHIsjCYlpTaRjCDWmyIF znxoAUjsu+EWPgEiSEp7B+w/RFPaB4ti6ebz51P9vH+Huckps0gFv4cMaVEWfVFt5JGD s2+6WlzPDTNG3ZHDmPkKeyy7RTwBgw2/TmRxRXvUBi0MbBzK/18Nv3ZrsKBEOMVIHGbV 5wFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eivbSK/iggE609kMctsDa0t3SvfhXTo/TwRgMrcMZFg=; b=I3vb6i9MA1EwWG1U86Mz/BNqQ57e4C+EkKW4o3u0bwazzrB4q/pUI/ktS6r6IHrEnb ywwheYHYRGDJQL76WPs0IonlRFnfte3JW4cuR9GTimp+APeBEOsb3w0vCrhh8v5lZV7/ PPKZ7+k8WCoF4dkU11Rrk0qGjU9oMmZINMKPKLNuiGPsAm89X5RZpbrem0QIE24xPYst vKIIjX7RPfnfu6Fi5sIdtkaKFqr5vo+XEYU5VhpuqBq3NNmX5lVRMeRaRCF0Vl+eUOne Hik7K2GNqOs2rduuGWewc6ZNBDUFEIqNG39q+aS6VnwmLHjS8SgLiiYA3RFQ4Stot5AO RM9A== X-Gm-Message-State: AFqh2koJakCK7wS0jke40n6xYqYegUEDRzGPy9vq3doDI9XMj7wPdXOG vypzY4TgXJU4Gus2/RegtITb2w== X-Google-Smtp-Source: AMrXdXvfhxQizm2dgNBqqEymbFkmBWtNN8ZdGdsPnNC7WrUaeLCdhGb3DFY0xYgMOfCjt2LITR/RmQ== X-Received: by 2002:a05:6512:ac4:b0:4ca:5013:b0e7 with SMTP id n4-20020a0565120ac400b004ca5013b0e7mr10964106lfu.59.1672234786292; Wed, 28 Dec 2022 05:39:46 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id b3-20020ac25623000000b004b4bae1a05asm2625055lff.293.2022.12.28.05.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Dec 2022 05:39:45 -0800 (PST) Message-ID: Date: Wed, 28 Dec 2022 14:39:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 11/16] clk: qcom: gcc-sdx55: use ARRAY_SIZE instead of specifying num_parents Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20221228133243.3052132-1-dmitry.baryshkov@linaro.org> <20221228133243.3052132-12-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20221228133243.3052132-12-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28.12.2022 14:32, Dmitry Baryshkov wrote: > Use ARRAY_SIZE() instead of manually specifying num_parents. This makes > adding/removing entries to/from parent_data/names/hws easy and errorproof. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/clk/qcom/gcc-sdx55.c | 52 ++++++++++++++++++------------------ > 1 file changed, 26 insertions(+), 26 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sdx55.c b/drivers/clk/qcom/gcc-sdx55.c > index 4fca19006a77..758b295e1bfa 100644 > --- a/drivers/clk/qcom/gcc-sdx55.c > +++ b/drivers/clk/qcom/gcc-sdx55.c > @@ -232,7 +232,7 @@ static struct clk_rcg2 gcc_blsp1_qup1_i2c_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup1_i2c_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -258,7 +258,7 @@ static struct clk_rcg2 gcc_blsp1_qup1_spi_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup1_spi_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -272,7 +272,7 @@ static struct clk_rcg2 gcc_blsp1_qup2_i2c_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup2_i2c_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -286,7 +286,7 @@ static struct clk_rcg2 gcc_blsp1_qup2_spi_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup2_spi_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -300,7 +300,7 @@ static struct clk_rcg2 gcc_blsp1_qup3_i2c_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup3_i2c_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -314,7 +314,7 @@ static struct clk_rcg2 gcc_blsp1_qup3_spi_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup3_spi_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -328,7 +328,7 @@ static struct clk_rcg2 gcc_blsp1_qup4_i2c_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup4_i2c_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -342,7 +342,7 @@ static struct clk_rcg2 gcc_blsp1_qup4_spi_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_qup4_spi_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -386,7 +386,7 @@ static struct clk_rcg2 gcc_blsp1_uart1_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_uart1_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -400,7 +400,7 @@ static struct clk_rcg2 gcc_blsp1_uart2_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_uart2_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -414,7 +414,7 @@ static struct clk_rcg2 gcc_blsp1_uart3_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_uart3_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -428,7 +428,7 @@ static struct clk_rcg2 gcc_blsp1_uart4_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_blsp1_uart4_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -450,7 +450,7 @@ static struct clk_rcg2 gcc_cpuss_ahb_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_cpuss_ahb_clk_src", > .parent_data = gcc_parents_0_ao, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0_ao), > .ops = &clk_rcg2_ops, > }, > }; > @@ -469,7 +469,7 @@ static struct clk_rcg2 gcc_cpuss_rbcpr_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_cpuss_rbcpr_clk_src", > .parent_data = gcc_parents_0_ao, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0_ao), > .ops = &clk_rcg2_ops, > }, > }; > @@ -493,7 +493,7 @@ static struct clk_rcg2 gcc_emac_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_emac_clk_src", > .parent_data = gcc_parents_5, > - .num_parents = 5, > + .num_parents = ARRAY_SIZE(gcc_parents_5), > .ops = &clk_rcg2_ops, > }, > }; > @@ -514,7 +514,7 @@ static struct clk_rcg2 gcc_emac_ptp_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_emac_ptp_clk_src", > .parent_data = gcc_parents_2, > - .num_parents = 6, > + .num_parents = ARRAY_SIZE(gcc_parents_2), > .ops = &clk_rcg2_ops, > }, > }; > @@ -537,7 +537,7 @@ static struct clk_rcg2 gcc_gp1_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_gp1_clk_src", > .parent_data = gcc_parents_3, > - .num_parents = 5, > + .num_parents = ARRAY_SIZE(gcc_parents_3), > .ops = &clk_rcg2_ops, > }, > }; > @@ -551,7 +551,7 @@ static struct clk_rcg2 gcc_gp2_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_gp2_clk_src", > .parent_data = gcc_parents_3, > - .num_parents = 5, > + .num_parents = ARRAY_SIZE(gcc_parents_3), > .ops = &clk_rcg2_ops, > }, > }; > @@ -565,7 +565,7 @@ static struct clk_rcg2 gcc_gp3_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_gp3_clk_src", > .parent_data = gcc_parents_3, > - .num_parents = 5, > + .num_parents = ARRAY_SIZE(gcc_parents_3), > .ops = &clk_rcg2_ops, > }, > }; > @@ -579,7 +579,7 @@ static struct clk_rcg2 gcc_pcie_aux_phy_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_pcie_aux_phy_clk_src", > .parent_data = gcc_parents_4, > - .num_parents = 3, > + .num_parents = ARRAY_SIZE(gcc_parents_4), > .ops = &clk_rcg2_ops, > }, > }; > @@ -598,7 +598,7 @@ static struct clk_rcg2 gcc_pcie_rchng_phy_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_pcie_rchng_phy_clk_src", > .parent_data = gcc_parents_3, > - .num_parents = 5, > + .num_parents = ARRAY_SIZE(gcc_parents_3), > .ops = &clk_rcg2_ops, > }, > }; > @@ -619,7 +619,7 @@ static struct clk_rcg2 gcc_pdm2_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_pdm2_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -633,7 +633,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_sdcc1_apps_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -652,7 +652,7 @@ static struct clk_rcg2 gcc_usb30_master_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_usb30_master_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -671,7 +671,7 @@ static struct clk_rcg2 gcc_usb30_mock_utmi_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_usb30_mock_utmi_clk_src", > .parent_data = gcc_parents_0, > - .num_parents = 4, > + .num_parents = ARRAY_SIZE(gcc_parents_0), > .ops = &clk_rcg2_ops, > }, > }; > @@ -691,7 +691,7 @@ static struct clk_rcg2 gcc_usb3_phy_aux_clk_src = { > .clkr.hw.init = &(struct clk_init_data){ > .name = "gcc_usb3_phy_aux_clk_src", > .parent_data = gcc_parents_4, > - .num_parents = 3, > + .num_parents = ARRAY_SIZE(gcc_parents_4), > .ops = &clk_rcg2_ops, > }, > };