devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Depeng Shao <quic_depengs@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <rfoss@kernel.org>,
	<todor.too@gmail.com>, <bryan.odonoghue@linaro.org>,
	<mchehab@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@quicinc.com>, Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding
Date: Fri, 16 Aug 2024 15:45:52 +0800	[thread overview]
Message-ID: <aa12fd2e-4869-4909-a04f-6bf24f76ed51@quicinc.com> (raw)
In-Reply-To: <cb905d5e-6d70-4395-894c-55b3542e2ebe@kernel.org>

Hi Krzysztof,

On 8/16/2024 3:01 PM, Krzysztof Kozlowski wrote:

>> +required:
>> +  - compatible
>> +  - clocks
>> +  - clock-names
>> +  - interconnects
>> +  - interconnect-names
>> +  - interrupts
>> +  - interrupt-names
>> +  - iommus
>> +  - power-domains
>> +  - power-domain-names
>> +  - reg
>> +  - reg-names
>> +  - vdda-phy-supply
>> +  - vdda-pll-supply
> 
> Order is still not as expected. I already commented on this - keep the
> same order as in "properties:" block.
> 
> With the order fixed:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Thanks for catching this, the order was correct in my local build, then 
Vladimir posted a new comment, so I updated it again and forgot to 
update the required item, I will correct the order in next version series.

Vladimir: "I would suggest to put 'compatible', 'reg' and 'reg-names' 
properties as the first ones. 'clock-names' should follow 'clocks' 
property in the list."

Thanks,
Depeng

  reply	other threads:[~2024-08-16  7:46 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 14:41 [PATCH v4 00/13] media: qcom: camss: Add sm8550 support Depeng Shao
2024-08-12 14:41 ` [PATCH 01/13] media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines Depeng Shao
2024-08-12 14:41 ` [PATCH 02/13] media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop Depeng Shao
2024-08-12 14:41 ` [PATCH 03/13] media: qcom: camss: csiphy-3ph: Rename struct Depeng Shao
2024-08-12 14:41 ` [PATCH 04/13] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices Depeng Shao
2024-08-19  0:17   ` Vladimir Zapolskiy
2024-09-04 14:20     ` Depeng Shao
2024-09-04 14:51       ` Bryan O'Donoghue
2024-08-12 14:41 ` [PATCH 05/13] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct Depeng Shao
2024-08-19  0:01   ` Vladimir Zapolskiy
2024-08-28 14:11     ` Depeng Shao
2024-08-12 14:41 ` [PATCH 06/13] media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao
2024-08-18 23:59   ` Vladimir Zapolskiy
2024-08-12 14:41 ` [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-08-16  7:01   ` Krzysztof Kozlowski
2024-08-16  7:45     ` Depeng Shao [this message]
2024-09-30  7:17       ` Krzysztof Kozlowski
2024-09-05 15:20   ` Vladimir Zapolskiy
2024-09-05 15:54     ` Depeng Shao
2024-09-06 15:56   ` Vladimir Zapolskiy
2024-09-25 15:13     ` Depeng Shao
2024-09-30  7:16       ` Krzysztof Kozlowski
2024-09-30  8:46         ` Vladimir Zapolskiy
2024-09-30  8:55           ` Bryan O'Donoghue
2024-09-30  9:15             ` Vladimir Zapolskiy
2024-09-30  7:26       ` Krzysztof Kozlowski
2024-09-30  8:32         ` Vladimir Zapolskiy
2024-09-30  9:03         ` Bryan O'Donoghue
2024-09-12  8:22   ` Vladimir Zapolskiy
2024-09-12 11:41     ` Bryan O'Donoghue
2024-09-12 12:44       ` Vladimir Zapolskiy
2024-09-12 15:11         ` Bryan O'Donoghue
2024-09-12 20:57           ` Vladimir Zapolskiy
2024-09-12 22:41             ` Bryan O'Donoghue
2024-09-13  5:06               ` Vladimir Zapolskiy
2024-09-17 22:40                 ` Bryan O'Donoghue
2024-09-17 23:16                   ` Vladimir Zapolskiy
2024-09-25 15:40                     ` Depeng Shao
2024-09-30  9:26                       ` Depeng Shao
2024-10-08 13:50                         ` Vladimir Zapolskiy
2024-10-08 14:06                           ` Bryan O'Donoghue
2024-10-08 15:47                             ` Depeng Shao
2024-09-30 10:21                       ` Bryan O'Donoghue
2024-09-13  4:17           ` Dmitry Baryshkov
2024-09-12 13:48       ` Neil Armstrong
2024-08-12 14:41 ` [PATCH 08/13] media: qcom: camss: csid: Move common code into csid core Depeng Shao
2024-08-14 23:53   ` Bryan O'Donoghue
2024-08-24 12:50     ` Vladimir Zapolskiy
2024-08-12 14:41 ` [PATCH 09/13] media: qcom: camss: vfe: Move common code into vfe core Depeng Shao
2024-08-15  0:09   ` Bryan O'Donoghue
2024-08-16 13:07     ` Depeng Shao
2024-08-24 13:06     ` Vladimir Zapolskiy
2024-08-28  0:07       ` Bryan O'Donoghue
2024-09-02 13:11       ` Depeng Shao
2024-08-12 14:41 ` [PATCH 10/13] media: qcom: camss: Add sm8550 compatible Depeng Shao
2024-08-13 12:57   ` Bryan O'Donoghue
2024-08-12 14:41 ` [PATCH 11/13] media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support Depeng Shao
2024-08-12 14:41 ` [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for sm8550 Depeng Shao
2024-08-14 16:08   ` Bryan O'Donoghue
2024-08-15 15:14     ` Depeng Shao
2024-08-15 16:10       ` Bryan O'Donoghue
2024-08-16 11:34   ` Bryan O'Donoghue
2024-08-16 13:11     ` Depeng Shao
2024-08-16 14:21   ` Bryan O'Donoghue
2024-08-19 13:23     ` Depeng Shao
2024-08-16 14:45   ` Bryan O'Donoghue
2024-08-19 13:18     ` Depeng Shao
2024-08-16 14:49   ` Bryan O'Donoghue
2024-08-24 13:19   ` Vladimir Zapolskiy
2024-09-30  9:23   ` Vladimir Zapolskiy
2024-09-30  9:38     ` Depeng Shao
2024-08-12 14:41 ` [PATCH 13/13] media: qcom: camss: Add support for VFE hardware version Titan 780 Depeng Shao
2024-08-14 11:13   ` Vladimir Zapolskiy
2024-08-14 13:10     ` Depeng Shao
2024-08-14 23:20       ` Vladimir Zapolskiy
2024-08-15 14:42         ` Depeng Shao
2024-08-15 14:57           ` Vladimir Zapolskiy
2024-08-15 15:43             ` Depeng Shao
2024-08-15 21:31               ` Vladimir Zapolskiy
2024-08-16 12:42                 ` Depeng Shao
2024-08-20 14:01                   ` Vladimir Zapolskiy
2024-08-14 16:23   ` Bryan O'Donoghue
2024-08-15 13:33     ` Depeng Shao
2024-08-15 16:16       ` Bryan O'Donoghue
2024-08-15  0:16   ` Bryan O'Donoghue
2024-08-15 14:24     ` Depeng Shao
2024-08-15  0:25   ` Bryan O'Donoghue
2024-08-15 14:21     ` Depeng Shao
2024-08-15 16:17       ` Bryan O'Donoghue
2024-09-29  1:28       ` Depeng Shao
2024-09-29 23:57         ` Bryan O'Donoghue
2024-09-30  5:37           ` Depeng Shao
2024-08-19 11:05   ` Bryan O'Donoghue
2024-08-19 13:07     ` Depeng Shao
2024-08-21 11:11   ` Vladimir Zapolskiy
2024-08-24 13:31     ` Vladimir Zapolskiy
2024-08-27 13:16   ` Bryan O'Donoghue
2024-08-13 12:35 ` [PATCH v4 00/13] media: qcom: camss: Add sm8550 support Bryan O'Donoghue
2024-08-13 12:42   ` Depeng Shao
  -- strict thread matches above, loose matches on Subject: below --
2024-07-09 16:06 [PATCH V3 " Depeng Shao
2024-07-09 16:06 ` [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-07-09 20:21   ` Rob Herring (Arm)
2024-07-10  9:37   ` Bryan O'Donoghue
2024-07-10 10:59     ` Depeng Shao
2024-07-10 11:07   ` Krzysztof Kozlowski
2024-07-11 10:43     ` Depeng Shao
2024-08-01  0:05   ` Vladimir Zapolskiy
2024-08-01  2:02     ` Depeng Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa12fd2e-4869-4909-a04f-6bf24f76ed51@quicinc.com \
    --to=quic_depengs@quicinc.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_yon@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).