From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: interconnect: qcom,sm6115: Drop incorrect children if:then: block
Date: Mon, 4 May 2026 09:57:32 +0200 [thread overview]
Message-ID: <aa237c49-4b41-4d5a-9ce0-79d09b07408a@oss.qualcomm.com> (raw)
In-Reply-To: <20260503161653.60785-5-krzysztof.kozlowski@oss.qualcomm.com>
On 5/3/26 6:16 PM, Krzysztof Kozlowski wrote:
> This binding has children, so any if:then: block restricting them,
> cannot be defined in top-level allOf:if:then:properties:, because it
> simply does not match these children. The block, if it was useful,
> should be defined within patternProperties for the children, however
> since child nodes do not have clocks at all, there is little point in
> disallowing them in the first place.
>
> Remove completely redundant and ineffective piece of code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
Good find, this wasn't obvious
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-05-04 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 16:16 [PATCH 1/3] dt-bindings: interconnect: qcom,sdm660: Disallow clocks when appropriate Krzysztof Kozlowski
2026-05-03 16:16 ` [PATCH 2/3] dt-bindings: interconnect: qcom,sm6115: Drop incorrect children if:then: block Krzysztof Kozlowski
2026-05-04 7:57 ` Konrad Dybcio [this message]
2026-05-03 16:16 ` [PATCH 3/3] dt-bindings: interconnect: qcom,sm6115: Restrict children and clocks Krzysztof Kozlowski
2026-05-04 8:00 ` Konrad Dybcio
2026-05-04 7:53 ` [PATCH 1/3] dt-bindings: interconnect: qcom,sdm660: Disallow clocks when appropriate Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa237c49-4b41-4d5a-9ce0-79d09b07408a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox