From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C735C001DE for ; Mon, 24 Jul 2023 13:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjGXN1K (ORCPT ); Mon, 24 Jul 2023 09:27:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjGXN1J (ORCPT ); Mon, 24 Jul 2023 09:27:09 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C241B8 for ; Mon, 24 Jul 2023 06:26:53 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9936b3d0286so774846666b.0 for ; Mon, 24 Jul 2023 06:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690205212; x=1690810012; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j3RBb+0rdI0PV2BXiS1JbrEVU9RxO+lG8P/0tc+GO2k=; b=BgBI17fdQ/GbfAC+tyBQqZDxHUVtXE2gyuA+iY6fgjJRj2mM7rPqhup90hSQ0GMKuD 7wQ2ysntk6ex6WlxX7SrnKsvpJs2XA6FdwaYllJ+DEfSaRXKA57bbjh0+H8WmO0PbduE hrODJiSi61B02+5Ei0iTz2CxXlU0gPoTvKGb/qskxos6EM8nX6Z0Zr5RWs/4S1ce0q/N ewa2Czwe1HfC8hwPsJJlRUA9Sga7nleuaCd3v6zKnmsf6dsxOFoGgEoNjtbEkbTeYVBV hMOsEi72t6F9OD58sdW77RkqaZzv0XJTAqv4tHh1PLqpdLK/NXeUG7khR0cxshjIisfl rRTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690205212; x=1690810012; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j3RBb+0rdI0PV2BXiS1JbrEVU9RxO+lG8P/0tc+GO2k=; b=DELzMHH1XCGYDaKGAZ9D+grKYSYz611Jw5cl3dxwrEpiEAyxXUNDUOQLuWvXyPYtm8 mJDwf9RO4iPMVuhxFzSKJ5glohU/8OShsFHRnq4aTjwtCCPPJZdj5VluyZaX91/XJBIo 7fMw/5jmJECfSdtCL0WH3WQNNbEgvGAlaxA90nmtbE6JTXP0S5Ek9k58UJBx/LRqyKvD Fi+CEyguFbS3c873ng2yeSgyFMnTT5Hw0/oHqtmP6Dial4ghFimv/heGWRcbC3ZGHWfa wEguLvXnmzrRCWCNjHwHatg9OBrwgwVLxm0ZtTq2lxh5wYnilSmq7OuyjNg5dN43f/kO KDbQ== X-Gm-Message-State: ABy/qLZXm0wqHv/4whwOa9bSsooFXuYCohuKxlM9E+dtw6kBQ4ZMmuYM xcMyIxhE+KfgsGtoJsnqhoX0iZct/HNgKYRpZeLBlg== X-Google-Smtp-Source: APBJJlG+MYBK5sVdt/kiSQV3ZDPpauvV89+zavgwzbGMZNg+Lkas7YB/9OEJZ5Op6rZW781mBlqpIg== X-Received: by 2002:a17:907:2bea:b0:98d:f4a7:71cf with SMTP id gv42-20020a1709072bea00b0098df4a771cfmr9317640ejc.62.1690205211882; Mon, 24 Jul 2023 06:26:51 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id h19-20020a1709062dd300b0097073f1ed84sm6754521eji.4.2023.07.24.06.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 06:26:51 -0700 (PDT) Message-ID: Date: Mon, 24 Jul 2023 15:26:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 2/6] soc: qcom: llcc: Refactor llcc driver to support multiple configuration Content-Language: en-US To: Mukesh Ojha , Komal Bajaj , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srinivas.kandagatla@linaro.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230724084155.8682-1-quic_kbajaj@quicinc.com> <20230724084155.8682-3-quic_kbajaj@quicinc.com> <39b4bafd-410f-cae8-13ae-e18d751b51a2@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <39b4bafd-410f-cae8-13ae-e18d751b51a2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/07/2023 14:28, Mukesh Ojha wrote: > On 7/24/2023 2:11 PM, Komal Bajaj wrote: >> Refactor driver to support multiple configuration for llcc on a target. >> >> Signed-off-by: Komal Bajaj >> --- >> drivers/soc/qcom/llcc-qcom.c | 264 +++++++++++++++++++++++------------ >> 1 file changed, 178 insertions(+), 86 deletions(-) >> >> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c >> index 67c19ed2219a..321f8d2079f7 100644 >> --- a/drivers/soc/qcom/llcc-qcom.c >> +++ b/drivers/soc/qcom/llcc-qcom.c >> @@ -127,6 +127,12 @@ struct qcom_llcc_config { >> bool no_edac; >> }; >> >> +struct qcom_sct_config > > const ? What (and how) should be const above? Best regards, Krzysztof