* [PATCH 1/2] dt-bindings: clock: gs101: rename cmu_misc clock-names
@ 2023-12-21 9:00 Tudor Ambarus
2023-12-21 9:00 ` [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names Tudor Ambarus
0 siblings, 1 reply; 4+ messages in thread
From: Tudor Ambarus @ 2023-12-21 9:00 UTC (permalink / raw)
To: peter.griffin, robh+dt, krzysztof.kozlowski+dt
Cc: conor+dt, mturquette, alim.akhtar, semen.protsenko,
linux-arm-kernel, linux-samsung-soc, linux-clk, devicetree,
linux-kernel, kernel-team, Tudor Ambarus, Rob Herring
'bus' and 'ip' are sufficient because naming is local to the module.
As the bindings have not made a release yet, rename the cmu_misc
clock-names.
Fixes: 0a910f160638 ("dt-bindings: clock: Add Google gs101 clock management unit bindings")
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
.../devicetree/bindings/clock/google,gs101-clock.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
index 3eebc03a309b..ca7fdada3ff2 100644
--- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
@@ -85,8 +85,8 @@ allOf:
clock-names:
items:
- - const: dout_cmu_misc_bus
- - const: dout_cmu_misc_sss
+ - const: bus
+ - const: sss
additionalProperties: false
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names
2023-12-21 9:00 [PATCH 1/2] dt-bindings: clock: gs101: rename cmu_misc clock-names Tudor Ambarus
@ 2023-12-21 9:00 ` Tudor Ambarus
2023-12-21 17:22 ` André Draszik
2023-12-21 17:23 ` Tudor Ambarus
0 siblings, 2 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-12-21 9:00 UTC (permalink / raw)
To: peter.griffin, robh+dt, krzysztof.kozlowski+dt
Cc: conor+dt, mturquette, alim.akhtar, semen.protsenko,
linux-arm-kernel, linux-samsung-soc, linux-clk, devicetree,
linux-kernel, kernel-team, Tudor Ambarus, Rob Herring
The cmu_misc clock-names were renamed to just "bus" and "sss" because
naming is local to the module, so cmu_misc is implied. As the bindings
and the device tree have not made a release yet, comply with the
renamed clocks.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 9747cb3fa03a..d838e3a7af6e 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -289,7 +289,7 @@ cmu_misc: clock-controller@10010000 {
#clock-cells = <1>;
clocks = <&cmu_top CLK_DOUT_CMU_MISC_BUS>,
<&cmu_top CLK_DOUT_CMU_MISC_SSS>;
- clock-names = "dout_cmu_misc_bus", "dout_cmu_misc_sss";
+ clock-names = "bus", "sss";
};
watchdog_cl0: watchdog@10060000 {
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names
2023-12-21 9:00 ` [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names Tudor Ambarus
@ 2023-12-21 17:22 ` André Draszik
2023-12-21 17:23 ` Tudor Ambarus
1 sibling, 0 replies; 4+ messages in thread
From: André Draszik @ 2023-12-21 17:22 UTC (permalink / raw)
To: tudor.ambarus
Cc: alim.akhtar, conor+dt, devicetree, kernel-team,
krzysztof.kozlowski+dt, linux-arm-kernel, linux-clk, linux-kernel,
linux-samsung-soc, mturquette, peter.griffin, robh+dt, robh,
semen.protsenko
Hi Tudor,
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 9747cb3fa03a..d838e3a7af6e 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -289,7 +289,7 @@ cmu_misc: clock-controller@10010000 {
> #clock-cells = <1>;
> clocks = <&cmu_top CLK_DOUT_CMU_MISC_BUS>,
> <&cmu_top CLK_DOUT_CMU_MISC_SSS>;
> - clock-names = "dout_cmu_misc_bus", "dout_cmu_misc_sss";
> + clock-names = "bus", "sss";
> };
>
With this change, parent clock enablement fails, and we get:
exynos_arm64_register_cmu: could not enable bus clock dout_cmu_misc_bus; err = -2
during boot.
Cheers,
Andre'
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names
2023-12-21 9:00 ` [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names Tudor Ambarus
2023-12-21 17:22 ` André Draszik
@ 2023-12-21 17:23 ` Tudor Ambarus
1 sibling, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2023-12-21 17:23 UTC (permalink / raw)
To: peter.griffin, robh+dt, krzysztof.kozlowski+dt
Cc: conor+dt, mturquette, alim.akhtar, semen.protsenko,
linux-arm-kernel, linux-samsung-soc, linux-clk, devicetree,
linux-kernel, kernel-team, Rob Herring
On 12/21/23 09:00, Tudor Ambarus wrote:
> The cmu_misc clock-names were renamed to just "bus" and "sss" because
> naming is local to the module, so cmu_misc is implied. As the bindings
> and the device tree have not made a release yet, comply with the
> renamed clocks.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 9747cb3fa03a..d838e3a7af6e 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -289,7 +289,7 @@ cmu_misc: clock-controller@10010000 {
> #clock-cells = <1>;
> clocks = <&cmu_top CLK_DOUT_CMU_MISC_BUS>,
> <&cmu_top CLK_DOUT_CMU_MISC_SSS>;
> - clock-names = "dout_cmu_misc_bus", "dout_cmu_misc_sss";
> + clock-names = "bus", "sss";
> };
>
> watchdog_cl0: watchdog@10060000 {
argh, please ignore the patch set. It seems that the clock driver has to
be updated as well:
[ 0.050947] exynos_arm64_register_cmu: could not enable bus clock
dout_cmu_misc_bus; err = -2
[ 0.052385] exynos_arm64_register_cmu: could not enable bus clock
dout_cmu_peric0_bus; err = -2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 9:00 [PATCH 1/2] dt-bindings: clock: gs101: rename cmu_misc clock-names Tudor Ambarus
2023-12-21 9:00 ` [PATCH 2/2] arm64: dts: exynos: gs101: comply with the new cmu_misc clock names Tudor Ambarus
2023-12-21 17:22 ` André Draszik
2023-12-21 17:23 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).