From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2704A341AC6 for ; Mon, 22 Dec 2025 13:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766411442; cv=none; b=VAZyjlNeJcuyA2Vn0QeK7Hf0fbmglUIBx1VrfHRnL2s/Db5fXELYvrEZhpRQH1UueVIb7TWI6HXJlJOsQqV1QFOm7l/iV31/t4NOB+S8RfW0Ci4HMWf4rWyGaIkN7ekz/NtPhsi8w7E5IBHCgjnW43ovESjuQmwse1OzoUKuse8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766411442; c=relaxed/simple; bh=k+WlEjGFs5Rkzrhieb+Ls4G8ju4EL+kjwknMhVtHuZc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h+YECl+WWA90vjcNXDsttlZiT/GUbKNgCHHPlRUq770lIiOFwegKWRj2vfZRfqEDL5ABURB72KoqmTVAk08H86Bq3GTmXxhxuZQDwfSAbOENXnPLG+IB28kXzxxuAKswgPTNJl5I1Kv02zu8WufDWaAemLCMdVwyAmwgPlZu4HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AzBdwSf9; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AzBdwSf9" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-7d26a7e5639so4528187b3a.1 for ; Mon, 22 Dec 2025 05:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766411439; x=1767016239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8BaR3k+5zrCCB1XIcd8osL/EF92HXoyzBz26/MVuE/I=; b=AzBdwSf9WIshU7q07vYyHUpPA2tgnCfSYywc9VqwNX7ogLOWbYb+BzaTIwjKvfFs7s mexcE0JrX2w/pwBANmibYyzaZm80yP95KJLbiQPY3om4L8+g1KMI6VK9CTVra64sbe4Y Odj5Xp22WUtOZU2aVcii3Eerq1s7dyH1hnrs4kuFu8CNn/RA4q/WCkFby5S5yrsrceXC 3Ms4G4Iaq1xphs48MdQHX+9TSeKXYCU8TPFlVshDKy5obBqsV1jmhi9QlUHKRdOX0T/t uiBhjjec6KGHg0icCC/KfUHXij2a011JctSanad2bNRc0FaHom3O58G1u1ImeOIVEvnw sFDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766411439; x=1767016239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8BaR3k+5zrCCB1XIcd8osL/EF92HXoyzBz26/MVuE/I=; b=d+toYuYrMNCXHrBIIH2SJSXk1+OZ7UlLgrErePtHLaLhGo/qmCUDeY8Ll/e3ZHNABY r0TVDOlLX4JCm3DtutNFjmuI4YknGQrkNNMArycNui4npCrrE/MASBCi0Q4WO5m79Vlp /bGWcqairXxeFOpqIcFnKrXacF+4Wwuf7NSHwweltWadpYCmCAgkKhA/8f0Q1ChOlbjA vpXFnapS4tRZ1r6VG0gtiw25ArlajMX0XVu0P6dHVlScMJv62W6nhVVpCHqlxIkFfB2l iUgUqqgW0MnuyzzEbO8XX3hVSaakb95KTBHY9i/dOvp2/Q49VjkZDNrvAtngN9XmVLzN Du6w== X-Forwarded-Encrypted: i=1; AJvYcCWTZEpXua4fs+lqsgIfF82yw6WUBX91Pgm32Q7rQMvcfJrUTpE2zrpt/M5d4eInr2NlpDAzDiH7Gs/N@vger.kernel.org X-Gm-Message-State: AOJu0YzmkMAL+hih8JHnfLJ5k5eUnTbBFTGoTZGEcTOvGA29cRqefH85 nfZkol9KWhhO1U4ltu/dPq5NGG+7lbapa1HTjp9gdWAqG4SmsKBtRw+9 X-Gm-Gg: AY/fxX6gTWQGx7iBlJjH+sYOPhzR6xAfYyjAaU2r3TESdu6clyBgVRB48ZLfjrTFCOw FyYdepCzusSsoJtfF8SC6d0xZpiVl1j5MoIWRQyWn7wj2Ty5+xy5XILlqRKX4fVgKzsnK/92FGs nbXl2SwD+y1KYtN1UPuu1Iw6DQQsfCsv+feuIgHdRXjhSdalJNzgIVQ600udBGJogXA92xMi9j0 Rez2nqURZN6OuobhQGg+wodQFAE/r0ArCIxNAlkRhad8Cyex0mxD0323DH+bf1zJxi/17/gJHsM IgFqeGueDCtyEEPN9qQp9+Dd5ZDOzcj6YUHq1Y1FCI1bbsUzRTn0ha7hDx+ytNK6JCDKxRz3h2j 3mxUPqjEOOFRikM7yDqNGPgJZ3YdE6y2xTUyq/O0Gt0EhcT+pnskEcQXPiDl0m6fCfIDeaaffXy JQIkVJRQOpTPh0XtarXrzT3IlAR1KD X-Google-Smtp-Source: AGHT+IEyXSAJPi4cc8ok6Aq+xnI2o3obyF+3x23oU5Ir+vtxQzV06aOtv7kzKDFrV13w830o83jyfg== X-Received: by 2002:aa7:930b:0:b0:7e8:450c:61b8 with SMTP id d2e1a72fcca58-7ff6607e842mr10207742b3a.40.1766411439404; Mon, 22 Dec 2025 05:50:39 -0800 (PST) Received: from [192.168.1.115] ([59.188.211.98]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm10542320b3a.50.2025.12.22.05.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 05:50:38 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2025 21:50:33 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/11] input: macsmc-input: New driver to handle the Apple Mac SMC buttons/lid To: James Calligeros , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Belloni , Jean Delvare , Guenter Roeck , Dmitry Torokhov , Jonathan Corbet Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-doc@vger.kernel.org, Hector Martin References: <20251112-macsmc-subdevs-v5-0-728e4b91fe81@gmail.com> <20251112-macsmc-subdevs-v5-8-728e4b91fe81@gmail.com> Content-Language: en-MW From: Nick Chan In-Reply-To: <20251112-macsmc-subdevs-v5-8-728e4b91fe81@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 12/11/2025 19:16, James Calligeros wrote: > From: Hector Martin > > This driver implements power button and lid switch support for Apple Mac > devices using SMC controllers driven by the macsmc driver. > > In addition to basic input support, this also responds to the final > shutdown warning (when the power button is held down long enough) by > doing an emergency kernel poweroff. This allows the NVMe controller to > be cleanly shut down, which prevents data loss for in-cache data. > > Reviewed-by: Neal Gompa > Signed-off-by: Hector Martin > Co-developed-by: Sven Peter > Signed-off-by: Sven Peter > Signed-off-by: James Calligeros > --- > MAINTAINERS | 1 + > drivers/input/misc/Kconfig | 11 ++ > drivers/input/misc/Makefile | 1 + > drivers/input/misc/macsmc-input.c | 207 +++++++++++++++++++++++++ > 4 files changed, 220 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fb55a167699e..48bdca6943f3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2455,6 +2455,7 @@ F: drivers/hwmon/macsmc-hwmon.c > F: drivers/pmdomain/apple/ > F: drivers/i2c/busses/i2c-pasemi-core.c > F: drivers/i2c/busses/i2c-pasemi-platform.c > +F: drivers/input/misc/macsmc-input.c > F: drivers/input/touchscreen/apple_z2.c > F: drivers/iommu/apple-dart.c > F: drivers/iommu/io-pgtable-dart.c > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index cc2558630797..1144ba151dbf 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -992,4 +992,15 @@ config INPUT_STPMIC1_ONKEY > To compile this driver as a module, choose M here: the > module will be called stpmic1_onkey. > > +config INPUT_MACSMC > + tristate "Apple Mac SMC lid/buttons" > + depends on MFD_MACSMC > + help > + Say Y here if you want to use the input events delivered via the > + SMC controller on Apple Mac machines using the macsmc driver. > + This includes lid open/close and the power button. > + > + To compile this driver as a module, choose M here: the > + module will be called macsmc-input. > + > endif > diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile > index f5ebfa9d9983..c6394105252f 100644 > --- a/drivers/input/misc/Makefile > +++ b/drivers/input/misc/Makefile > @@ -52,6 +52,7 @@ obj-$(CONFIG_INPUT_IQS7222) += iqs7222.o > obj-$(CONFIG_INPUT_KEYSPAN_REMOTE) += keyspan_remote.o > obj-$(CONFIG_INPUT_KXTJ9) += kxtj9.o > obj-$(CONFIG_INPUT_M68K_BEEP) += m68kspkr.o > +obj-$(CONFIG_INPUT_MACSMC_INPUT) += macsmc-input.o should be CONFIG_INPUT_MACSMC (alternatively change Kconfig instead) > obj-$(CONFIG_INPUT_MAX7360_ROTARY) += max7360-rotary.o > obj-$(CONFIG_INPUT_MAX77650_ONKEY) += max77650-onkey.o > obj-$(CONFIG_INPUT_MAX77693_HAPTIC) += max77693-haptic.o > diff --git a/drivers/input/misc/macsmc-input.c b/drivers/input/misc/macsmc-input.c > new file mode 100644 > index 000000000000..f4598e65fc80 > --- /dev/null > +++ b/drivers/input/misc/macsmc-input.c > @@ -0,0 +1,207 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR MIT > +/* > + * Apple SMC input event driver > + * Copyright The Asahi Linux Contributors > + * > + * This driver exposes certain events from the SMC as an input device. > + * This includes the lid open/close and power button notifications. > + */ > + > +#include > +#include > +#include Missing #include > +#include > +#include > + > +/** > + * struct macsmc_input > + * @dev: Underlying struct device for the input sub-device > + * @smc: Pointer to apple_smc struct of the mfd parent > + * @input: Allocated input_dev; devres managed > + * @nb: Notifier block used for incoming events from SMC (e.g. button pressed down) > + * @wakeup_mode: Set to true when system is suspended and power button events should wake it > + */ > +struct macsmc_input { > + struct device *dev; > + struct apple_smc *smc; > + struct input_dev *input; > + struct notifier_block nb; > + bool wakeup_mode; > +}; > + > +#define SMC_EV_BTN 0x7201 > +#define SMC_EV_LID 0x7203 > + > +#define BTN_POWER 0x01 /* power button on e.g. Mac Mini chasis pressed */ > +#define BTN_TOUCHID 0x06 /* combined TouchID / power button on MacBooks pressed */ > +#define BTN_POWER_HELD_SHORT 0xfe /* power button briefly held down */ > +#define BTN_POWER_HELD_LONG 0x00 /* power button held down; sent just before forced poweroff */ > + > +static void macsmc_input_event_button(struct macsmc_input *smcin, unsigned long event) > +{ > + u8 button = (event >> 8) & 0xff; > + u8 state = !!(event & 0xff); > + > + switch (button) { > + case BTN_POWER: > + case BTN_TOUCHID: > + pm_wakeup_dev_event(smcin->dev, 0, (smcin->wakeup_mode && state)); > + > + /* Suppress KEY_POWER event to prevent immediate shutdown on wake */ > + if (smcin->wakeup_mode) > + return; > + > + input_report_key(smcin->input, KEY_POWER, state); > + input_sync(smcin->input); > + break; > + case BTN_POWER_HELD_SHORT: /* power button held down; ignore */ > + break; > + case BTN_POWER_HELD_LONG: > + /* > + * If we get here the power button has been held down for a while and > + * we have about 4 seconds before forced power-off is triggered by SMC. > + * Try to do an emergency shutdown to make sure the NVMe cache is > + * flushed. macOS actually does this by panicing (!)... > + */ > + if (state) { > + dev_crit(smcin->dev, "Triggering forced shutdown!\n"); > + if (kernel_can_power_off()) > + kernel_power_off(); > + else /* Missing macsmc-reboot driver? */ > + kernel_restart("SMC power button triggered restart"); > + } > + break; > + default: > + dev_warn(smcin->dev, "Unknown SMC button event: %04lx\n", event & 0xffff); > + } > +} > + > +static void macsmc_input_event_lid(struct macsmc_input *smcin, unsigned long event) > +{ > + u8 lid_state = !!((event >> 8) & 0xff); > + > + pm_wakeup_dev_event(smcin->dev, 0, (smcin->wakeup_mode && !lid_state)); > + input_report_switch(smcin->input, SW_LID, lid_state); > + input_sync(smcin->input); > +} > + > +static int macsmc_input_event(struct notifier_block *nb, unsigned long event, void *data) > +{ > + struct macsmc_input *smcin = container_of(nb, struct macsmc_input, nb); > + u16 type = event >> 16; > + > + switch (type) { > + case SMC_EV_BTN: > + macsmc_input_event_button(smcin, event); > + return NOTIFY_OK; > + case SMC_EV_LID: > + macsmc_input_event_lid(smcin, event); > + return NOTIFY_OK; > + default: > + /* SMC event meant for another driver */ > + return NOTIFY_DONE; > + } > +} > + > +static int macsmc_input_probe(struct platform_device *pdev) > +{ > + struct apple_smc *smc = dev_get_drvdata(pdev->dev.parent); > + struct macsmc_input *smcin; > + bool have_lid, have_power; > + int error; > + > + /* Bail early if this SMC neither supports power button nor lid events */ > + have_lid = apple_smc_key_exists(smc, SMC_KEY(MSLD)); > + have_power = apple_smc_key_exists(smc, SMC_KEY(bHLD)); > + if (!have_lid && !have_power) > + return -ENODEV; > + > + smcin = devm_kzalloc(&pdev->dev, sizeof(*smcin), GFP_KERNEL); > + if (!smcin) > + return -ENOMEM; > + > + smcin->dev = &pdev->dev; > + smcin->smc = smc; > + platform_set_drvdata(pdev, smcin); > + > + smcin->input = devm_input_allocate_device(&pdev->dev); > + if (!smcin->input) > + return -ENOMEM; > + > + smcin->input->phys = "macsmc-input (0)"; > + smcin->input->name = "Apple SMC power/lid events"; > + > + if (have_lid) > + input_set_capability(smcin->input, EV_SW, SW_LID); > + if (have_power) > + input_set_capability(smcin->input, EV_KEY, KEY_POWER); > + > + if (have_lid) { > + u8 val; > + > + error = apple_smc_read_u8(smc, SMC_KEY(MSLD), &val); > + if (error < 0) > + dev_warn(&pdev->dev, "Failed to read initial lid state\n"); > + else > + input_report_switch(smcin->input, SW_LID, val); > + } > + > + if (have_power) { > + u32 val; > + > + error = apple_smc_read_u32(smc, SMC_KEY(bHLD), &val); > + if (error < 0) > + dev_warn(&pdev->dev, "Failed to read initial power button state\n"); > + else > + input_report_key(smcin->input, KEY_POWER, val & 1); > + } > + > + error = input_register_device(smcin->input); > + if (error) { > + dev_err(&pdev->dev, "Failed to register input device: %d\n", error); > + return error; > + } > + > + input_sync(smcin->input); > + > + smcin->nb.notifier_call = macsmc_input_event; > + blocking_notifier_chain_register(&smc->event_handlers, &smcin->nb); > + > + device_init_wakeup(&pdev->dev, true); > + > + return 0; > +} > + > +static int macsmc_input_pm_prepare(struct device *dev) > +{ > + struct macsmc_input *smcin = dev_get_drvdata(dev); > + > + smcin->wakeup_mode = true; > + return 0; > +} > + > +static void macsmc_input_pm_complete(struct device *dev) > +{ > + struct macsmc_input *smcin = dev_get_drvdata(dev); > + > + smcin->wakeup_mode = false; > +} > + > +static const struct dev_pm_ops macsmc_input_pm_ops = { > + .prepare = macsmc_input_pm_prepare, > + .complete = macsmc_input_pm_complete, > +}; > + > +static struct platform_driver macsmc_input_driver = { > + .driver = { > + .name = "macsmc-input", > + .pm = &macsmc_input_pm_ops, > + }, > + .probe = macsmc_input_probe, > +}; > +module_platform_driver(macsmc_input_driver); > + > +MODULE_AUTHOR("Hector Martin "); > +MODULE_LICENSE("Dual MIT/GPL"); > +MODULE_DESCRIPTION("Apple SMC input driver"); > +MODULE_ALIAS("platform:macsmc-input"); > Best regards, Nick Chan