[PATCH 0/2] phy: qcom: snps-eusb2: Add support for X1E80100

[PATCH 0/2] phy: qcom: snps-eusb2: Add support for X1E80100

[Abel Vesa]

This patchset adds the compatible (and documents it) for the X1E80100
eUSB2 PHY.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (2):
      dt-bindings: phy: qcom: snps-eusb2: Document the X1E80100 compatible
      phy: qcom: snps-eusb2: Add X1E80100 Compatible

 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 +
 drivers/phy/qualcomm/phy-qcom-snps-eusb2.c                     | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: 07b677953b9dca02928be323e2db853511305fa9
change-id: 20231122-phy-qualcomm-eusb2-x1e80100-36dacab8fd52

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

[PATCH 1/2] dt-bindings: phy: qcom: snps-eusb2: Document the X1E80100 compatible

[Abel Vesa]

Add the X1E80100 compatible to the list of supported PHYs.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
index 8f5d7362046c..ea1809efbf56 100644
--- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
@@ -21,6 +21,7 @@ properties:
               - qcom,sm8650-snps-eusb2-phy
           - const: qcom,sm8550-snps-eusb2-phy
       - const: qcom,sm8550-snps-eusb2-phy
+      - const: qcom,x1e80100-snps-eusb2-phy
 
   reg:
     maxItems: 1

-- 
2.34.1

[PATCH 2/2] phy: qcom: snps-eusb2: Add X1E80100 Compatible

[Abel Vesa]

Add the X1E80100 to the list of supported PHYs for eUSB2
SNPS driver.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 1484691a41d5..6420f342dc85 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
 
 static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = {
 	{ .compatible = "qcom,sm8550-snps-eusb2-phy", },
+	{ .compatible = "qcom,x1e80100-snps-eusb2-phy", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table);

-- 
2.34.1

Re: [PATCH 2/2] phy: qcom: snps-eusb2: Add X1E80100 Compatible

[Dmitry Baryshkov]

On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote:
>
> Add the X1E80100 to the list of supported PHYs for eUSB2
> SNPS driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
> index 1484691a41d5..6420f342dc85 100644
> --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
> @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
>
>  static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = {
>         { .compatible = "qcom,sm8550-snps-eusb2-phy", },
> +       { .compatible = "qcom,x1e80100-snps-eusb2-phy", },

Do we need a separate compatible string or is it fully compatible with
sm8550? If it is the same IP block, maybe you can use a fallback
compatible instead?

>         { },
>  };
>  MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table);
>
> --
> 2.34.1
>
>


-- 
With best wishes
Dmitry

Re: [PATCH 1/2] dt-bindings: phy: qcom: snps-eusb2: Document the X1E80100 compatible

[Dmitry Baryshkov]

On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote:
>
> Add the X1E80100 compatible to the list of supported PHYs.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 8f5d7362046c..ea1809efbf56 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> @@ -21,6 +21,7 @@ properties:
>                - qcom,sm8650-snps-eusb2-phy
>            - const: qcom,sm8550-snps-eusb2-phy

Ah, I think this answers my question for patch2. Can we instead reuse
the existing compat string as it was done for sm8650?

>        - const: qcom,sm8550-snps-eusb2-phy
> +      - const: qcom,x1e80100-snps-eusb2-phy
>
>    reg:
>      maxItems: 1
>
> --
> 2.34.1
>
>


-- 
With best wishes
Dmitry

Re: [PATCH 2/2] phy: qcom: snps-eusb2: Add X1E80100 Compatible

[Krzysztof Kozlowski]

On 22/11/2023 12:01, Dmitry Baryshkov wrote:
> On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote:
>>
>> Add the X1E80100 to the list of supported PHYs for eUSB2
>> SNPS driver.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>>  drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> index 1484691a41d5..6420f342dc85 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
>>
>>  static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = {
>>         { .compatible = "qcom,sm8550-snps-eusb2-phy", },
>> +       { .compatible = "qcom,x1e80100-snps-eusb2-phy", },
> 
> Do we need a separate compatible string or is it fully compatible with
> sm8550? If it is the same IP block, maybe you can use a fallback
> compatible instead?

Yep. This should use fallback.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: phy: qcom: snps-eusb2: Document the X1E80100 compatible

[Krzysztof Kozlowski]

On 22/11/2023 12:02, Dmitry Baryshkov wrote:
> On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote:
>>
>> Add the X1E80100 compatible to the list of supported PHYs.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>> index 8f5d7362046c..ea1809efbf56 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>> @@ -21,6 +21,7 @@ properties:
>>                - qcom,sm8650-snps-eusb2-phy
>>            - const: qcom,sm8550-snps-eusb2-phy
> 
> Ah, I think this answers my question for patch2. Can we instead reuse
> the existing compat string as it was done for sm8650?

If not, commit msg should explain why it cannot.

Best regards,
Krzysztof