From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev,
Fabien Poussin <fabien.poussin@gmail.com>
Subject: Re: [PATCH 5/5] clk: sunxi-ng: d1: Add CAN bus gates and resets
Date: Sun, 27 Nov 2022 21:51:54 +0100 [thread overview]
Message-ID: <aa4da52a-c07c-2f3e-24b2-8a45b4c4cc77@linaro.org> (raw)
In-Reply-To: <20221126191319.6404-6-samuel@sholland.org>
On 26/11/2022 20:13, Samuel Holland wrote:
> From: Fabien Poussin <fabien.poussin@gmail.com>
>
> The D1 CCU contains gates and resets for two CAN buses. While the CAN
> bus controllers are only documented for the T113 SoC, the CCU is the
> same across all SoC variants.
>
> Signed-off-by: Fabien Poussin <fabien.poussin@gmail.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/clk/sunxi-ng/ccu-sun20i-d1.c | 11 +++++++++++
> drivers/clk/sunxi-ng/ccu-sun20i-d1.h | 2 +-
> include/dt-bindings/clock/sun20i-d1-ccu.h | 2 ++
> include/dt-bindings/reset/sun20i-d1-ccu.h | 2 ++
Don't mix bindings with driver changes. Checkpatch should complain here...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-27 20:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 19:13 [PATCH 0/5] clk: sunxi-ng: Allwinner R528/T113 clock support Samuel Holland
2022-11-26 19:13 ` [PATCH 1/5] clk: sunxi-ng: Remove duplicate ARCH_SUNXI dependencies Samuel Holland
2022-12-03 0:14 ` Andre Przywara
2022-12-03 1:52 ` Samuel Holland
2022-12-03 13:57 ` Andre Przywara
2022-12-05 20:19 ` Jernej Škrabec
2022-11-26 19:13 ` [PATCH 2/5] clk: sunxi-ng: Move SoC driver conditions to dependencies Samuel Holland
2022-12-05 20:16 ` Jernej Škrabec
2022-11-26 19:13 ` [PATCH 3/5] clk: sunxi-ng: d1: Allow building for R528/T113 Samuel Holland
2022-12-03 0:15 ` Andre Przywara
2022-12-05 20:14 ` Jernej Škrabec
2022-11-26 19:13 ` [PATCH 4/5] clk: sunxi-ng: d1: Mark cpux clock as critical Samuel Holland
2022-12-03 0:22 ` Andre Przywara
2022-12-05 20:13 ` Jernej Škrabec
2022-11-26 19:13 ` [PATCH 5/5] clk: sunxi-ng: d1: Add CAN bus gates and resets Samuel Holland
2022-11-27 20:51 ` Krzysztof Kozlowski [this message]
2022-12-03 0:40 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa4da52a-c07c-2f3e-24b2-8a45b4c4cc77@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.poussin@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).