From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: airoha: en7581: Add switch node to to EN7581 SoC
Date: Mon, 9 Mar 2026 20:48:47 +0100 [thread overview]
Message-ID: <aa8kH8_4NO3y2zeJ@lore-desk> (raw)
In-Reply-To: <a9638d70-c474-4c03-b57c-5c15e9ef273e@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
> > + gsw_phy1: ethernet-phy@1 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <9>;
>
> The @1 should match the reg value. So this is wrong.
ack, I will fix it in v2.
>
> > + phy-mode = "internal";
>
> phy-mode is actually a MAC property, not a PHY property. It is not
> listed in
> Documentation/devicetree/bindings/net/ethernet-phy.yaml. Which also
> suggest this has not been tested using the DT validation tools.
ack, right. I guess this just a leftover of a previous implementation, I will
remove it in v2. Anyway I compiled the dts with the command below:
$make CHECK_DTBS=y W=1 airoha/en7581-evb.dtb
Regards,
Lorenzo
>
> Andrew
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-03-09 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:03 [PATCH] arm64: dts: airoha: en7581: Add switch node to to EN7581 SoC Lorenzo Bianconi
2026-03-09 18:36 ` Andrew Lunn
2026-03-09 19:48 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa8kH8_4NO3y2zeJ@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox